MantisBT - Open CASCADE
View Issue Details
0026593Open CASCADE[OCCT] OCCT:Codingpublic2015-08-24 15:062016-04-20 15:48
kgv 
bugmaster 
highmajor 
closedfixed 
 
[OCCT] 7.0.0[OCCT] 7.0.0 
Not needed
0026593: Coding rules - revert compatibility of NCollection_CellFilter constructor with old code
Last cosmetic modifications of NCollection_CellFilter has been introduced API changes that even have not been documented:
-  NCollection_CellFilter (Standard_Real theCellSize=0,
-                          const Handle(NCollection_IncAllocator)& theAlloc=0) 
-  {
-    Reset (theCellSize, theAlloc);
-  }
+  NCollection_CellFilter (const Standard_Integer theDim,
+                          const Standard_Real theCellSize = 0,
+                          const Handle(NCollection_IncAllocator)& theAlloc = 0)
+  : myCellSize(0, theDim - 1)

The changed arguments list is dangerous because it makes old code silently compilable with just a minor warning of double->int implicit conversion.

It is better to make old code to work.
N/A
No tags attached.
child of 0026395closed bugmaster Merge clasees NCollection_CellFilter_NDim and NCollection_CellFilter 
child of 0026184closed bugmaster GeomAPI_ExtremaCurveCurve hangs on parallel b-spline curves 
Issue History
2015-08-24 15:06kgvNew Issue
2015-08-24 15:06kgvAssigned To => kgv
2015-08-24 15:06kgvRelationship addedchild of 0026395
2015-08-24 15:06kgvRelationship addedchild of 0026184
2015-08-24 15:07kgvAssigned Tokgv => msv
2015-08-24 15:07kgvPrioritynormal => high
2015-08-24 15:07kgvStatusnew => assigned
2015-08-24 16:05msvNote Added: 0044553
2015-08-24 16:05msvAssigned Tomsv => aml
2015-08-24 20:17gitNote Added: 0044579
2015-08-25 09:20amlNote Added: 0044581
2015-08-25 09:20amlAssigned Toaml => msv
2015-08-25 09:20amlStatusassigned => resolved
2015-08-26 15:54msvNote Added: 0044669
2015-08-26 15:54msvAssigned Tomsv => aml
2015-08-26 15:54msvStatusresolved => assigned
2015-08-26 16:50gitNote Added: 0044676
2015-08-26 16:53amlNote Added: 0044677
2015-08-26 16:53amlAssigned Toaml => msv
2015-08-26 16:53amlStatusassigned => resolved
2015-08-26 19:33msvNote Added: 0044688
2015-08-26 19:33msvAssigned Tomsv => bugmaster
2015-08-26 19:33msvStatusresolved => reviewed
2015-08-28 14:46apvAssigned Tobugmaster => apv
2015-08-28 15:51gitNote Added: 0044821
2015-08-28 15:55apvNote Added: 0044826
2015-09-02 14:46apvTest case number => Not needed
2015-09-02 14:49apvNote Added: 0044965
2015-09-02 14:49apvAssigned Toapv => bugmaster
2015-09-02 14:49apvStatusreviewed => tested
2015-09-04 13:02bugmasterChangeset attached => occt master a7653f4f
2015-09-04 13:02bugmasterStatustested => verified
2015-09-04 13:02bugmasterResolutionopen => fixed
2015-09-07 13:50gitNote Added: 0045137
2015-10-16 16:08gitNote Added: 0046859
2015-10-16 16:14gitNote Added: 0046884
2016-04-20 15:44aivFixed in Version => 7.0.0
2016-04-20 15:48aivStatusverified => closed

Notes
(0044553)
msv   
2015-08-24 16:05   
Alexander, I propose to restore the old constructor, and it should get the dimension from the inspector, as earlier. The new behavior constructor will get dimension from its arguments.
(0044579)
git   
2015-08-24 20:17   
Branch CR26593 has been created by aml.

SHA-1: b5ffc4f7fec8a877d57b8916f40d694d694c9ee2


Detailed log of new commits:

Author: aml
Date: Mon Aug 24 19:32:38 2015 +0300

    0026593: Coding rules - revert compatibility of NCollection_CellFilter constructor with old code
    
    Restored old constructor and old behavior where possible.
(0044581)
aml   
2015-08-25 09:20   
Dear msv,

Proposed solution pushed to CR26593 branches in OCCT and products repositories. Please check current state of CR26593 branches.
(0044669)
msv   
2015-08-26 15:54   
This fix reverts some changes made by the fix "0026395: Merge clasees NCollection_CellFilter_NDim and NCollection_CellFilter". Why the following file is not reverted as well:

src\Extrema\Extrema_GenExtCC.gxx
(0044676)
git   
2015-08-26 16:50   
Branch CR26593 has been updated by aml.

SHA-1: c76b2bbe1aeba00b176ef0d312ff11f790f92021


Detailed log of new commits:

Author: aml
Date: Wed Aug 26 16:48:14 2015 +0300

    Minor correction.

(0044677)
aml   
2015-08-26 16:53   
Dear msv,

I forgot to add this file into fix. Please check updated branch.
(0044688)
msv   
2015-08-26 19:33   
Reviewed.
(0044821)
git   
2015-08-28 15:51   
Branch CR26593 has been updated forcibly by apv.

SHA-1: cf9c582d935bad86b77a79523c308653215e1320
(0044826)
apv   
2015-08-28 15:55   
Branches CR26593 (from occt and products repositories) have been rebased on the current master
(0044965)
apv   
2015-09-02 14:49   
Dear BugMaster,

Branch CR26593 from occt git-repository (and CR26593 from products git-repository) was compiled on Linux and Windows platforms and tested.
SHA-1: cf9c582d935bad86b77a79523c308653215e1320
SHA-1: 453830bbf3de575dbb052a6a9d4a376729e50638

Number of compiler warnings:
occt component:
   Linux: 15 (15 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 39 (39 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
occt component:
Total MEMORY difference: 91006720 / 91198451 [-0.21%]
Total CPU difference: 17827.679999998993 / 17164.509999999384 [+3.86%]
products component:
Total MEMORY difference: 25237304 / 25226546 [+0.04%]
Total CPU difference: 7384.669999999988 / 7039.5099999999975 [+4.90%]

Testing on Windows:
occt component:
Total MEMORY difference: 57079247 / 57088288 [-0.02%]
Total CPU difference: 16474.111202598862 / 16439.744182298913 [+0.21%]
products component:
Total MEMORY difference: 16224716 / 16228570 [-0.02%]
Total CPU difference: 5360.631162799972 / 5334.079792599963 [+0.50%]
(0045137)
git   
2015-09-07 13:50   
Branch CR26593_1 has been created by kgv.

SHA-1: 7c4740f8549d77b45dd3eaf7da3565f793a4fa1e


Detailed log of new commits:

Author: kgv
Date: Mon Sep 7 13:48:23 2015 +0300

    BRepMesh_CircleInspector - fix vc12 compiler error after 0026593
(0046859)
git   
2015-10-16 16:08   
Branch CR26593 has been deleted by kgv.

SHA-1: cf9c582d935bad86b77a79523c308653215e1320
(0046884)
git   
2015-10-16 16:14   
Branch CR26593_1 has been deleted by kgv.

SHA-1: 7c4740f8549d77b45dd3eaf7da3565f793a4fa1e