MantisBT - Community
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026451Community[OCCT] OCCT:Data Exchangepublic2015-07-16 16:352020-09-07 13:20
Reporterventu 
Assigned Tobugmaster 
PrioritynormalSeveritymajor 
StatusclosedResolutionreopened 
PlatformOSOS Version
Product Version[OCCT] 6.8.0 
Target Version[OCCT] 7.0.0Fixed in Version[OCCT] 7.0.0 
Test case numberbugs step bug26451
Summary0026451: Crash importing STeP file
DescriptionImporting the attached file crashes OC.

I guess there are some invalid entities within, but other products seem to import the file fine (perhaps skipping them?).
Steps To ReproduceReadStep D test_STEP.stp
>> no exceptions should be caught
Additional information
and documentation updates
TagsNo tags attached.
Relationships
related to 0031756assigned dpasukhi Open CASCADE Data Exchange - broken parsing of STEP entity in case of missing last parameter 
Attached Fileszip sample.zip (1,396,425) 2015-07-16 16:35
https://tracker.dev.opencascade.org/
Issue History
Date ModifiedUsernameFieldChange
2015-07-16 16:35ventuNew Issue
2015-07-16 16:35ventuAssigned To => gka
2015-07-16 16:35ventuFile Added: sample.zip
2015-08-20 15:48gkaAssigned Togka => ika
2015-08-20 15:48gkaStatusnew => assigned
2015-08-27 12:05gitNote Added: 0044713
2015-08-27 12:08ikaNote Added: 0044715
2015-08-27 12:08ikaAssigned Toika => gka
2015-08-27 12:08ikaStatusassigned => resolved
2015-08-27 12:08ikaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11360#r11360
2015-08-27 12:59gkaNote Added: 0044730
2015-08-27 12:59gkaAssigned Togka => bugmaster
2015-08-27 12:59gkaStatusresolved => reviewed
2015-08-27 18:51gitNote Added: 0044765
2015-08-27 19:00mkvAssigned Tobugmaster => mkv
2015-08-28 15:40mkvNote Added: 0044817
2015-08-28 15:41mkvNote Added: 0044818
2015-08-28 15:41mkvAssigned Tomkv => ika
2015-08-28 15:41mkvStatusreviewed => feedback
2015-08-28 15:41gitNote Added: 0044819
2015-08-28 15:41mkvNote Added: 0044820
2015-08-28 15:42mkvTest case number => bugs step bug26451
2015-08-31 14:22ikaNote Added: 0044882
2015-08-31 14:22ikaAssigned Toika => mkv
2015-08-31 14:22ikaStatusfeedback => reviewed
2015-08-31 15:12mkvNote Added: 0044886
2015-08-31 15:12mkvAssigned Tomkv => bugmaster
2015-08-31 15:12mkvStatusreviewed => tested
2015-09-04 13:02bugmasterChangeset attached => occt master d18c1ac0
2015-09-04 13:02bugmasterStatustested => verified
2015-09-04 13:02bugmasterResolutionopen => fixed
2015-09-11 14:33abvTarget Version => 6.9.1
2015-10-16 14:55aivStatusverified => closed
2015-10-16 16:37gitNote Added: 0046980
2015-10-23 20:50aivFixed in Version => 6.9.1
2015-11-03 20:05ventuNote Added: 0047778
2015-11-03 20:05ventuStatusclosed => feedback
2015-11-03 20:05ventuResolutionfixed => reopened
2015-11-05 10:25bugmasterAssigned Tobugmaster => ika
2015-11-05 10:25bugmasterStatusfeedback => assigned
2015-11-06 12:02gitNote Added: 0047868
2015-11-06 12:06ikaNote Added: 0047869
2015-11-06 12:06ikaAssigned Toika => gka
2015-11-06 12:06ikaStatusassigned => resolved
2015-11-06 12:06ikaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12151#r12151
2015-11-17 11:11gkaNote Added: 0048272
2015-11-17 11:11gkaAssigned Togka => bugmaster
2015-11-17 11:11gkaStatusresolved => reviewed
2015-11-17 15:12bugmasterAssigned Tobugmaster => apv
2015-11-17 16:51gitNote Added: 0048307
2015-11-17 16:52apvNote Added: 0048308
2015-11-20 12:43apvNote Added: 0048407
2015-11-20 12:43apvAssigned Toapv => bugmaster
2015-11-20 12:43apvStatusreviewed => tested
2015-11-26 11:49abvFixed in Version6.9.1 =>
2015-11-26 11:49abvTarget Version6.9.1 => 7.0.0
2015-11-27 12:21bugmasterChangeset attached => occt master 53711314
2015-11-27 12:21bugmasterStatustested => verified
2016-04-17 14:14gitNote Added: 0053095
2016-04-20 15:42aivFixed in Version => 7.0.0
2016-04-20 15:50aivStatusverified => closed
2020-09-07 13:20abvRelationship addedrelated to 0031756

Notes
(0044713)
git   
2015-08-27 12:05   
Branch CR26451 has been created by ika.

SHA-1: d508df35f4387d8914fae61278f04b0524878598


Detailed log of new commits:

Author: ika
Date: Thu Aug 27 12:02:35 2015 +0300

    0026451: Crash importing STeP file
    
    Add check for NULL.
(0044715)
ika   
2015-08-27 12:08   
Dear GKA,

could you please review branch CR26451?
(0044730)
gka   
2015-08-27 12:59   
Branch CR26451 is ready to be tested.
(0044765)
git   
2015-08-27 18:51   
Branch CR26451 has been updated forcibly by mkv.

SHA-1: 52fd9db47ff64a09251474e478cb072d174291af
(0044817)
mkv   
2015-08-28 15:40   
Dear BugMaster,
Branch CR26451 was rebased on branch IR-2015-08-27 of occt git-repository.
SHA-1: 52fd9db47ff64a09251474e478cb072d174291af
(0044818)
mkv   
2015-08-28 15:41   
Dear BugMaster,
Branch CR26451 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 52fd9db47ff64a09251474e478cb072d174291af

Number of compiler warnings:

occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)

products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR26451-master-occt-64/Debian70-64/bugs/step/bug26451.html [^]
http://occt-tests/CR26451-master-occt-64/Windows-64-VC10/bugs/step/bug26451.html [^]
bugs step bug26451: OK

Testing on Linux:
occt component :
Total MEMORY difference: 91691452 / 91194310 [+0.55%]
Total CPU difference: 17791.019999999047 / 17162.189999999384 [+3.66%]
products component :
Total MEMORY difference: 25222027 / 25216901 [+0.02%]
Total CPU difference: 7036.710000000023 / 7037.939999999998 [-0.02%]

Testing on Windows:
occt component :
Total MEMORY difference: 57104601 / 57097637 [+0.01%]
Total CPU difference: 16486.092079399015 / 16461.10071919891 [+0.15%]
products component :
Total MEMORY difference: 16228596 / 16228570 [+0.00%]
Total CPU difference: 5317.169284199959 / 5334.079792599963 [-0.32%]

There are following differences in images found by testdiff.
There are no differences in images found by testdiff.
(0044819)
git   
2015-08-28 15:41   
Branch CR26451 has been updated by mkv.

SHA-1: 7ae8975493e515945f428404a88e2128920c4b52


Detailed log of new commits:

Author: mkv
Date: Fri Aug 28 15:41:17 2015 +0300

    Test case for issue CR26451
(0044820)
mkv   
2015-08-28 15:41   
Dear ika,
could you please review following test case
bugs step bug26451
(0044882)
ika   
2015-08-31 14:22   
Dear MKV,

the test case is OK.
(0044886)
mkv   
2015-08-31 15:12   
Dear BugMaster,
Branch CR26451 is TESTED.
(0046980)
git   
2015-10-16 16:37   
Branch CR26451 has been deleted by kgv.

SHA-1: 7ae8975493e515945f428404a88e2128920c4b52
(0047778)
ventu   
2015-11-03 20:05   
Thanks, but this bug hasn't been fixed.

Consider the following code (more or less taken from the manuals):

Handle(XCAFApp_Application) App(XCAFApp_Application::GetApplication());
Handle(TDocStd_Document) Doc;
App->NewDocument("MDTV-XCAF",Doc);
STEPCAFControl_Reader reader;
if (reader.ReadFile(FileName)!=IFSelect_RetDone) throw
  std::runtime_error("OpenCASCADE STEP reading failed");
if (!reader.Transfer(Doc)) throw std::runtime_error("OpenCASCADE transfer failed");

6.9.0 would crash on "reader.ReadFile"; 6.9.1 will go on, but still crash on "reader.Trasnfer(Doc)".
There are still several null pointer checks needed.
(0047868)
git   
2015-11-06 12:02   
Branch CR26451 has been created by ika.

SHA-1: dae80243549749bf489b59dfd587c7b99b900702


Detailed log of new commits:

Author: ika
Date: Fri Nov 6 11:47:53 2015 +0300

    0026451: Crash importing STeP file
    
    Add check for NULL.
(0047869)
ika   
2015-11-06 12:06   
Dear GKA,

could you please review branch CR26451?
(0048272)
gka   
2015-11-17 11:11   
Branch CR26451 is ready to be tested
(0048307)
git   
2015-11-17 16:51   
Branch CR26451 has been updated forcibly by apv.

SHA-1: e0770a62b70f51ddcdb67b5a9e517c965cbcae18
(0048308)
apv   
2015-11-17 16:52   
Branch CR26451 has been rebased on the current master
(0048407)
apv   
2015-11-20 12:43   
Dear BugMaster,

Branch CR26451 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: e0770a62b70f51ddcdb67b5a9e517c965cbcae18

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MacOS: 129 (129 on master)
products component:
   Linux: 39 (39 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing cases:
bugs step bug26451 - OK
http://occt-tests/CR26451-master-occt-64/Debian70-64/bugs/step/bug26451.html [^]
http://occt-tests/CR26451-master-occt-64/Windows-64-VC10/bugs/step/bug26451.html [^]

Testing on Linux:
Total MEMORY difference: 92790930 / 92928671 [-0.15%]
Total CPU difference: 19870.069999999738 / 19784.679999999877 [+0.43%]

Testing on Windows:
Total MEMORY difference: 58087879 / 58096109 [-0.01%]
Total CPU difference: 18117.893739598912 / 18232.367273398875 [-0.63%]
(0053095)
git   
2016-04-17 14:14   
Branch CR26451 has been deleted by kgv.

SHA-1: e0770a62b70f51ddcdb67b5a9e517c965cbcae18