MantisBT - Open CASCADE
View Issue Details
0026256Open CASCADE[OCCT] OCCT:Application Frameworkpublic2015-05-22 11:332018-06-29 21:19
ibs 
bugmaster 
normalintegration request 
closedfixed 
 
[OCCT] 7.3.0[OCCT] 7.3.0 
persist fsd B1
0026256: FSD_File and FSD_CmpFile are almost twins
FSD_CmpFile is a almost copy of FSD_File. Why FSF_CmpFile is not child of FSD_File?
N/A (Only optimization of architecture).
No tags attached.
? bug26256.cmp (13,940) 2017-09-13 16:47
https://tracker.dev.opencascade.org/
Issue History
2015-05-22 11:33ibsNew Issue
2015-05-22 11:33ibsAssigned To => szy
2015-05-22 17:12szyStatusnew => assigned
2015-05-22 17:19szyNote Added: 0041453
2015-05-22 17:19szyStatusassigned => feedback
2015-05-22 17:49ibsNote Added: 0041455
2015-05-22 17:49ibsStatusfeedback => assigned
2015-12-30 16:08szyAssigned Toszy => vro
2015-12-30 16:09szyNote Added: 0049688
2016-04-16 07:59abvTarget Version6.9.0 => 7.1.0
2016-11-03 17:21abvTarget Version7.1.0 => 7.2.0
2017-07-27 09:43abvTarget Version7.2.0 => 7.4.0
2017-08-23 17:46szyAssigned Tovro => szy
2017-09-13 16:45gitNote Added: 0070506
2017-09-13 16:47szyFile Added: bug26256.cmp
2017-09-13 16:48szyNote Added: 0070508
2017-09-14 11:35bugmasterNote Added: 0070523
2017-09-14 12:51szyNote Added: 0070527
2017-09-14 12:51szyAssigned Toszy => vro
2017-09-14 12:51szyStatusassigned => resolved
2017-09-14 12:51szySteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17571#r17571
2017-09-14 13:07bugmasterTest case number => persist fsd B1
2017-09-14 14:31vroAssigned Tovro => bugmaster
2017-09-14 14:31vroStatusresolved => reviewed
2017-09-15 11:13bugmasterNote Added: 0070575
2017-09-15 11:13bugmasterStatusreviewed => tested
2017-09-17 23:32kgvSeverityjust a question => integration request
2017-09-17 23:32kgvProduct VersionUnscheduled =>
2017-09-21 19:33bugmasterChangeset attached => occt master 547ba1a6
2017-09-21 19:33bugmasterStatustested => verified
2017-09-21 19:33bugmasterResolutionopen => fixed
2017-09-21 19:50apnTarget Version7.4.0 => 7.2.0
2017-09-22 12:05bugmasterTarget Version7.2.0 => 7.4.0
2017-09-29 13:26bugmasterChangeset attached => occt master 46216226
2017-09-29 17:11gitNote Added: 0070992
2018-02-20 12:59aivTarget Version7.4.0 => 7.3.0
2018-06-29 21:15aivFixed in Version => 7.3.0
2018-06-29 21:19aivStatusverified => closed

Notes
(0041453)
szy   
2015-05-22 17:19   
It is not correct definition.
Both inherit from BaseDriver from Storage which defines
in general the framework of a specific driver implementation.
Both as BinaryFile as CmpFile implement the same methods in different way
taking into account that input data have different nature and structure.
I.e. here is used separation by type approach.
What is strange here?
(0041455)
ibs   
2015-05-22 17:49   
90% of the code is the same for both the classes. Would a parent class containing shared code be better approach for further development and support?
(0049688)
szy   
2015-12-30 16:09   
Vlad,
Check optimization possibility, please.
(0070506)
git   
2017-09-13 16:45   
Branch CR26256 has been created by szy.

SHA-1: d8295a297a4526f117d7c03fca040b5bd312b3ec


Detailed log of new commits:

Author: szy
Date: Wed Sep 13 16:43:32 2017 +0300

    0026256: FSD_File and FSD_CmpFile are almost twins.
    
    //CmpFile inheritance schema is changed.
    //Additional test - B1 is added to persist/fsd folder.
(0070508)
szy   
2017-09-13 16:48   
Test case B1 requires file bug26256.cmp (attached).
(0070523)
bugmaster   
2017-09-14 11:35   
bug26256.cmp has been pushed to shape database.
Results of testing:

http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/view/TESTING/job/CR26256-master-SZY-OCCT-Debian70-64-opt-test-restart/HTML_Report/ [^]

http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/view/TESTING/job/CR26256-master-SZY-OCCT-Windows-64-VC10-opt-test-restart/HTML_Report/ [^]
(0070527)
szy   
2017-09-14 12:51   
Review it, please.
Jenkins result =>http://jenkins-test-10.nnov.opencascade.com/view/CR26256-master-SZY/. [^]
Testgrid relevant to test modifications: 'persist/fsd'
New test case: B1
(0070575)
bugmaster   
2017-09-15 11:13   
Combination:
Branch OCCT : CR26256 SHA-1: d8295a297a4526f117d7c03fca040b5bd312b3ec
Branch products : master
was compiled on Linux, MacOS and Windows platforms and tested on Release mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Detected differences have been agreed with developer

Image differences :
Detected differences have been agreed with developer

Memory differences :
No differences that require special attention

New test cases are OK
(0070992)
git   
2017-09-29 17:11   
Branch CR26256 has been deleted by kgv.

SHA-1: d8295a297a4526f117d7c03fca040b5bd312b3ec