|
Notes |
|
|
(0046436)
|
|
git
|
|
2015-10-05 09:35
|
|
Branch CR26252_1 has been created by azv.
SHA-1: c26b13356a5abe9c88b41cfdbf2a0b47e046e659
Detailed log of new commits:
Author: azv
Date: Mon Oct 5 09:00:04 2015 +0300
0026252: GeomAdaptor_Surface should use inner adaptor to calculate values of complex surfaces
* Implement GeomEvaluator package
* Inject evaluators to GeomAdaptor_Surface to calculate values of complex surfaces
* Inject evaluators to Geom_Surface classes to calculate values for offset surfaces, surfaces of revolution and surfaces of extrusion
* Code optimizations
* Update test cases
|
|
|
|
(0046437)
|
|
azv
|
|
2015-10-05 09:36
|
|
Dear Mikhail,
Could you, please, review branch CR26252_1?
Moreover, I think such approach (using evaluators for both surfaces and adaptors) may be applied to calculation of Offset curves (2D and 3D). It will help to unify calculation of complex curves and surfaces and will allow to get rid of CSLib_Offset namespace introduced in scope of issue 0024682. |
|
|
|
(0046487)
|
|
msv
|
|
2015-10-05 18:46
|
|
Remarks:
General ones:
1) The word Standard_EXPORT is used only for methods that are to be exported. Inline methods and pure virtual methods (=0) are not exported, and this word should not be used for them.
2) Please wrap too long lines (more than 90-100 characters wide).
src\Geom\Geom_OffsetSurface.cxx:
3) The variables defined in the lines 190-200 are to be defined nearer to the place where they are used.
4) In function ReplaceDerivative, there is no need to alter U if DU is null, and the same for V and DV. So, it is needed to make two separate branches for U and V instead of nested for loops.
5) In function ReplaceDerivative, stepping 1/100 of the bounds range is too dangerous, because this step can be very large or very small and is not controlled. Instead, it may be better to compute the step using local resolution in the direction of non-null derivative evaluating delta parameter as Precision::Confusion() divided by derivative modulus.
To be continued. |
|
|
|
(0046544)
|
|
git
|
|
2015-10-07 11:47
|
|
Branch CR26252_1 has been updated by azv.
SHA-1: ee7c955d6518202bf0912291f186bee7e303a32a
Detailed log of new commits:
Author: azv
Date: Wed Oct 7 11:42:03 2015 +0300
Remarks
|
|
|
|
(0046555)
|
|
msv
|
|
2015-10-07 13:07
|
|
Continuation.
src\GeomEvaluator\GeomEvaluator_SurfaceOfExtrusion.cxx:
6) The method Shift() can be written more short and clear in one line:
thePoint.ChangeCoord() += myDirection.XYZ() * theShift;
7) The logic of DN() is ill:
114: else if (theDerV == 0 && theDerV == 1)
src\GeomEvaluator\GeomEvaluator_SurfaceOfRevolution.hxx:
8) The fields myDirection and myLocation are extra as they duplicate myRotAxis.
src\GeomEvaluator\GeomEvaluator_SurfaceOfRevolution.cxx:
9) The following condition is ill, as it compares linear and trigonometric values to each other:
71: if (theD1U.SquareMagnitude() < Precision::SquareConfusion() * aCQ.SquareModulus())
The same is in the lines 95, 125.
src\Geom\Geom_OffsetSurface.cxx:
10) Instead of defining the macro myOffsetEvaluator, it is better to declare myEvaluator to be of type GeomEvaluator_OffsetSurface.
11) myEvaluator is used only when equivSurf is null. So, I propose to omit creation of evaluator in the case if equivSurf is well created. But take care of creation of evaluator in the method Transform, where equivSurf is nullified.
src\Geom\Geom_SweptSurface.hxx:
12) The field myEvaluator is not used in this class. It is better to declare it in each of derivative class using particular type in each case.
src\Geom\Geom_SurfaceOfLinearExtrusion.cxx:
13) Avoid macro mySExtrEvaluator definition. See 12.
src\Geom\Geom_SurfaceOfRevolution.cxx:
14) Avoid macro mySRevEvaluator definition. See 12.
src\GeomAdaptor\GeomAdaptor_Surface.cxx:
15) Please avoid definition of downcasting macros myExtSurf, myRevSurf, myOffSurf. Aside from they make the code non-transparent they involve calling of downcast procedure several times in the same scope. It is better to make honest downcast where it is needed. |
|
|
|
(0047429)
|
|
git
|
|
2015-10-26 11:01
|
|
Branch CR26252_1 has been updated forcibly by azv.
SHA-1: cf8ba8e96e5cdc79411039bf09afe404bc7719ed |
|
|
|
(0047430)
|
|
git
|
|
2015-10-26 11:03
|
|
Branch CR26252_2 has been created by azv.
SHA-1: bb70bb0ee19c1ceb65911cafe37bb5e65313010d
Detailed log of new commits:
Author: azv
Date: Mon Oct 26 11:02:33 2015 +0300
0026252: GeomAdaptor_Surface should use inner adaptor to calculate values of complex surfaces
* Implement GeomEvaluator package
* Inject evaluators to GeomAdaptor_Surface to calculate values of complex surfaces
* Inject evaluators to Geom_Surface classes to calculate values for offset surfaces, surfaces of revolution and surfaces of extrusion
* Code optimizations
* Update test cases
|
|
|
|
(0047431)
|
|
azv
|
|
2015-10-26 11:05
|
|
Dear Mikhail,
I've updated the changes according your remarks. Could you, please, review branch CR26252_2. Note, that branch CR26252_1 contains same modifications but divided on several commits. |
|
|
|
(0047456)
|
|
msv
|
|
2015-10-26 17:56
|
|
|
|
|
(0047457)
|
|
git
|
|
2015-10-26 18:36
|
|
Branch CR26252_2 has been updated forcibly by mkv.
SHA-1: f95032a563af10b48821b03d053372ea410cd73d |
|
|
|
|
|
|
|
(0047474)
|
|
git
|
|
2015-10-27 12:16
|
|
Branch CR26252_2 has been updated forcibly by azv.
SHA-1: f2efb472744f078dfb3dae301805d6a6c05b939e |
|
|
|
(0047475)
|
|
azv
|
|
2015-10-27 12:17
|
|
Dear Mikhail,
Compilation errors are eliminated. Please rebuild and retest branch CR26252_2 |
|
|
|
(0047536)
|
|
mkv
|
|
2015-10-28 15:09
|
|
|
|
|
(0047537)
|
|
mkv
|
|
2015-10-28 15:09
|
|
Dear azv,
Branch CR26252_2 has been rejected due to:
- regressions/differences/improvements
- differences in images
|
|
|
|
(0047549)
|
|
azv
|
|
2015-10-28 16:15
|
|
Dear Mikhail,
bugs modalg_2 bug5805_18 - is not a regression
should be updated because offsetperform produces a result instead of master
de step_4 G7
de iges_2 D1
please update reference data according to new behavior
bfit pnt100 A4
bfit pnt1000 A4
bfit pnt1000 A7
bfit pnt10000 A4
please update reference data because of unstable algorithm (see comments for issue #26368)
parasolid doc_3 B3 - is not a regression
its reference data was broken by the fix of issue 0024682, but now it is OK
parasolid doc_3 C3
parasolid doc_3 E4
sat doc_5 H6
please update reference data according to new behavior
Image in test case offset with_intersect_80 L7 is better than on master.
|
|
|
|
(0047551)
|
|
msv
|
|
2015-10-28 16:39
|
|
Artem, I have noticed the test "de step_4 G7" gives different results under Linux and Windows with your fix.
Please analyze the cause. We should try to reduce instability. |
|
|
|
(0047614)
|
|
git
|
|
2015-10-29 16:31
|
|
Branch CR26252_3 has been created by azv.
SHA-1: d471f272e86fe84f0e51e272d92c421e14f53180
Detailed log of new commits:
Author: azv
Date: Mon Oct 26 11:02:33 2015 +0300
0026252: GeomAdaptor_Surface should use inner adaptor to calculate values of complex surfaces
* Implement GeomEvaluator package
* Inject evaluators to GeomAdaptor_Surface to calculate values of complex surfaces
* Inject evaluators to Geom_Surface classes to calculate values for offset surfaces, surfaces of revolution and surfaces of extrusion
* Code optimizations
* Update test cases
|
|
|
|
(0047615)
|
|
azv
|
|
2015-10-29 16:33
|
|
Dear Mikhail,
Please review branch CR26252_3. The change should avoid difference in test case de step_4 G7 on Linux and Windows platforms |
|
|
|
(0047620)
|
|
git
|
|
2015-10-29 16:44
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: d5eae7d1f9a402f2f8eb10aeece21966d77a0e90 |
|
|
|
(0047622)
|
|
msv
|
|
2015-10-29 17:03
|
|
|
|
|
(0047629)
|
|
mkv
|
|
2015-10-29 18:53
|
|
Dear azv,
could you please rebase branch CR26252_3 on IR-2015-10-29, there are conflict files.
|
|
|
|
(0047634)
|
|
git
|
|
2015-10-30 09:11
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: c930e0863fbf5c5c424e1f727facad09f8b2698f |
|
|
|
(0047635)
|
|
azv
|
|
2015-10-30 09:12
|
|
|
|
|
(0047664)
|
|
git
|
|
2015-10-30 16:21
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: 77056aa7d921f5eef6f88ff22ea5a353ea294ac8 |
|
|
|
(0047665)
|
|
azv
|
|
2015-10-30 16:22
|
|
Dear Mikhail,
Please review branch CR26252_3 once again. |
|
|
|
(0047668)
|
|
git
|
|
2015-10-30 17:01
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: 77fa084142edc269aed95db1cae919f048e5120b |
|
|
|
(0047669)
|
|
msv
|
|
2015-10-30 17:05
|
|
|
|
|
(0047716)
|
|
mkv
|
|
2015-11-02 16:10
|
|
Dear BugMaster,
Branch CR26252_3 from occt git-repository (and current master ( IR-2015-10-22) from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: d5eae7d1f9a402f2f8eb10aeece21966d77a0e90
Number of compiler warnings:
occt component :
Linux: 1 (1 on master)
Windows: 0 (0 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences/Improvements:
http://occt-tests/CR26252-3-master-occt-64/Debian70-64/summary.html [^]
http://occt-tests/CR26252-3-master-occt-64/Windows-64-VC10/summary.html [^]
Improvements:
de step_4 G7
Failed:
bugs modalg_2 bug5805_18
bugs moddata_3 bug25487_1
de iges_1 L5, N9, R5
de iges_2 D1, G9
de iges_3 A4
de step_1 Q6
de step_2 S1
de step_3 F2
http://occt-tests/CR26252-3-master-products-64/Debian70-64/summary.html [^]
http://occt-tests/CR26252-3-master-products-64/Windows-64-VC10/summary.html [^]
Improvements:
sat doc_6 D5
Failed:
bfit pnt100 A4, A7
bfit pnt1000 A7
bfit pnt10000 A4
parasolid doc_3 B3, E4
sat doc_5 H6
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 92180966 / 91499650 [+0.74%]
Total CPU difference: 20255.35999999964 / 19397.50999999992 [+4.42%]
products component :
Total MEMORY difference: 26129577 / 26158739 [-0.11%]
Total CPU difference: 7623.730000000001 / 7295.550000000015 [+4.50%]
Testing on Windows:
occt component :
http://occt-tests/CR26252-3-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html [^]
CPU de step_2 T5: 1.9968128 / 1.3104084 [+52.38%]
CPU de step_2 X6: 3.7596241 / 2.3712152 [+58.55%]
CPU de step_2 L3: 2.5584164 / 1.7004109 [+50.46%]
CPU de step_2 X7: 3.7908243 / 2.4180155 [+56.77%]
CPU de step_2 R4: 4.3836281 / 2.5740165 [+70.30%]
CPU de step_2 U5: 1.9032122 / 1.1700075 [+62.67%]
CPU de step_2 K6: 2.0436131 / 1.3572087 [+50.57%]
CPU de step_2 K7: 2.5896166 / 1.5444099 [+67.68%]
CPU de step_2 J1: 3.9624254 / 2.3244149 [+70.47%]
CPU de step_3 D6: 5.7252367 / 3.6348233 [+57.51%]
CPU de step_3 D2: 7.9716511 / 1.8408118 [+333.05%]
CPU de step_3 D5: 6.1620395 / 2.9328188 [+110.11%]
CPU de step_3 D4: 6.1620395 / 2.8236181 [+118.23%]
CPU de step_3 C4: 25.116161 / 15.0540965 [+66.84%]
CPU de step_4 A3: 9.8436631 / 6.0216386 [+63.47%]
CPU de step_4 A5: 14.976096 / 2.4024154 [+523.38%]
CPU de step_4 H5: 93.2105975 / 34.4294207 [+170.73%]
CPU de step_5 A3: 91.0577837 / 34.32022 [+165.32%]
CPU de step_5 A9: 7.5972487 / 3.900025 [+94.80%]
CPU de iges_1 L2: 25.3501625 / 11.9496766 [+112.14%]
CPU de step_1 E4: 2.3244149 / 1.3884089 [+67.42%]
CPU de step_1 V5: 2.964019 / 1.6224104 [+82.69%]
CPU de step_1 F8: 2.2464144 / 1.4352092 [+56.52%]
CPU heal wire_tails_real A7: 69.0304425 / 45.7550933 [+50.87%]
CPU mesh advanced_shading A8: 2.1684139 / 1.3884089 [+56.18%]
CPU mesh advanced_mesh A8: 1.9812127 / 1.1856076 [+67.11%]
CPU bugs iges buc60823: 3.1044199 / 1.9812127 [+56.69%]
CPU bugs step bug55: 62.7592023 / 32.1518061 [+95.20%]
CPU bugs heal bug210: 18.7825204 / 8.5176546 [+120.51%]
CPU bugs moddata_2 bug22993: 2.3712152 / 0.4524029 [+424.14%]
CPU bugs moddata_3 bug25487_2: 486.3331175 / 150.6813659 [+222.76%]
CPU bugs moddata_3 bug23943_2: 1.2948083 / 0.4992032 [+159.37%]
CPU bugs moddata_3: 1015.5197096999988 / 554.411953899999 [+83.17%]
CPU bugs modalg_2 bug5157_1: 156.5626036 / 68.7184405 [+127.83%]
CPU bugs modalg_2 bug5157_2: 156.8590055 / 67.704434 [+131.68%]
Total MEMORY difference: 57386078 / 57356945 [+0.05%]
Total CPU difference: 19179.917347398656 / 17788.747229699107 [+7.82%]
products component :
Total MEMORY difference: 17058399 / 17051415 [+0.04%]
Total CPU difference: 6004.6188909 / 5552.761994399979 [+8.14%]
There are following differences in images found by testdiff.
http://occt-tests/CR26252-3-master-occt-64/Debian70-64/diff-Debian70-64.html [^]
http://occt-tests/CR26252-3-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html [^]
IMAGE offset with_intersect_80 L7: L7.png differs
IMAGE bugs modalg_6 bug26640: bug26640.png differs |
|
|
|
(0047717)
|
|
mkv
|
|
2015-11-02 16:10
|
|
|
|
|
(0047718)
|
|
mkv
|
|
2015-11-02 16:10
|
|
|
|
|
(0047719)
|
|
mkv
|
|
2015-11-02 16:11
|
|
Dear azv,
Branch CR25252_3 has been rejected due to:
- regressions/differences/improvements
- differences in images
|
|
|
|
(0047858)
|
|
git
|
|
2015-11-06 08:43
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: d13b47c98e9195e9b4ab4312a2253430d88619b4 |
|
|
|
(0047899)
|
|
git
|
|
2015-11-06 18:26
|
|
Branch CR26252_3 has been updated by azv.
SHA-1: 71487106a30ba560ce7a7520ba9a652d488f1219
Detailed log of new commits:
Author: azv
Date: Fri Nov 6 18:20:45 2015 +0300
Move Adaptor3d_SurfaceOfLinearExtrusion and Adaptor3d_SurfaceOfRevolution to GeomAdaptor and unify calculation of their values and derivatives
|
|
|
|
(0047968)
|
|
git
|
|
2015-11-10 09:05
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: c544a4550787ae3bf5e19dbad307a822146b7f4c |
|
|
|
(0047969)
|
|
git
|
|
2015-11-10 09:09
|
|
Branch CR26252_4 has been created by azv.
SHA-1: 6e11955128aa2182aacbc6af7836977b3d48ac4f
Detailed log of new commits:
Author: azv
Date: Tue Nov 10 09:09:15 2015 +0300
0026252: GeomAdaptor_Surface should use inner adaptor to calculate values of complex surfaces
* Implement GeomEvaluator package
* Inject evaluators to GeomAdaptor_Surface to calculate values of complex surfaces
* Inject evaluators to Geom_Surface classes to calculate values for offset surfaces, surfaces of revolution and surfaces of extrusion
* Move Adaptor3d_SurfaceOfLinearExtrusion and Adaptor3d_SurfaceOfRevolution to GeomAdaptor and unify calculation of their values and derivatives
* Code optimizations
* Update test cases
|
|
|
|
(0047970)
|
|
azv
|
|
2015-11-10 09:12
|
|
Dear Mikhail,
Please, review branch CR26252_4. Note, branch CR26252_3 contains changes commit-by-commit.
Unfortunately, I still observe hang up on test parasolid read C9. The problem is that the shape has several faces based on B-spline surfaces with bad poles' distribution (see attached pictures). As a result, the test on the branch CR26252_4 takes a long time to build mesh for such face to show it in 3D viewer.
So, I propose to change this test case as far as it is BAD on master. There are two ways to change it:
* Do not show the shape in 3D viewer.
* Add one more TODO in test case to trap the exit on time limit.
Please, share your thoughts about this problem.
|
|
|
|
(0048011)
|
|
msv
|
|
2015-11-10 16:02
|
|
src\Adaptor3d\Adaptor3d_SurfaceOfLinearExtrusion.cxx
1) Why this file was removed and added in GeomAdaptor while the other files were just renamed?
src\GeomAdaptor\GeomAdaptor_Surface.cxx
2) It seems the downcasting operation in the following lines is extra:
166: Handle(Adaptor3d_HCurve)::DownCast(aBaseAdaptor),
179: Handle(Adaptor3d_HCurve)::DownCast(aBaseAdaptor), myExtSurf->Direction());
src\GeomAdaptor\GeomAdaptor_SurfaceOfRevolution.hxx
3) Why the field myHaveAxis has been gone?
src\GeomAdaptor\GeomAdaptor_SurfaceOfRevolution.cxx
4) It is bad to load data to evaluator if myAxis has not been initialized yet. See 3).
5) In the method Axis(), why don't you return myAxeRev as it is in ref?
src\ShapeAnalysis\ShapeAnalysis_Surface.cxx
6) Why have you returned back the old version?
|
|
|
|
(0048012)
|
|
msv
|
|
2015-11-10 16:04
|
|
|
Concerning the case test parasolid read C9, I do not agree to change the test here. It is a real regression, and we should find the cause and eliminate it. |
|
|
|
(0048034)
|
|
git
|
|
2015-11-11 09:15
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: 65f24a6c97cd56e3c145278742c06f743e86fb46 |
|
|
|
(0048035)
|
|
git
|
|
2015-11-11 09:15
|
|
Branch CR26252_3 has been updated by azv.
SHA-1: 083d13a0561ac5e926e0bdfa678fc38c24e55631
Detailed log of new commits:
Author: azv
Date: Wed Nov 11 09:13:04 2015 +0300
Remarks
|
|
|
|
(0048036)
|
|
azv
|
|
2015-11-11 09:27
|
|
Branch CR26252_3 contains changes commit-by-commit including latest remarks:
1) Git removes Adaptor3d_SurfaceOfExtrusion.cxx and adds corresponding file in GeomAdaptor probably because of quantity of changes. Now it is fixed, the history of this file should be stored in Git
2) Downcasting is necessary to avoid compiler problems regarding to handles
3) Field myHaveAxis is recovered
4) Done
5) This was a mistake. Reverted
6) The core of the problem was not in ShapeAnalysis_Surface, so it is reverted to initial state |
|
|
|
(0048040)
|
|
msv
|
|
2015-11-11 10:08
|
|
|
The source code has been reviewed. |
|
|
|
(0048160)
|
|
git
|
|
2015-11-13 15:19
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: cdd4f1dfed222d8e3702ddc4571c44384d3b4abb |
|
|
|
(0048161)
|
|
git
|
|
2015-11-13 15:33
|
|
Branch CR26252_4 has been updated forcibly by azv.
SHA-1: 023a689b7dbf512412856f08793b6ef7ab42bc3b |
|
|
|
(0048162)
|
|
azv
|
|
2015-11-13 15:33
|
|
Dear Mikhail,
Please review branch CR26252_4. It contains single commit. As usual, you can find same changes commit-by-commit on branch CR26252_3. |
|
|
|
(0048201)
|
|
git
|
|
2015-11-16 09:42
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: fb2ad168949a2f9a9bdf3475eaa93e1cf40ecd81 |
|
|
|
(0048202)
|
|
git
|
|
2015-11-16 09:45
|
|
Branch CR26252_4 has been updated forcibly by azv.
SHA-1: d1f8dfd116e94ba21ebc43994bd120d21b68786a |
|
|
|
(0048203)
|
|
azv
|
|
2015-11-16 09:45
|
|
Dear Mikhail,
Branch CR26252_4 is ready for review. |
|
|
|
(0048219)
|
|
git
|
|
2015-11-16 15:44
|
|
Branch CR26252_3 has been updated forcibly by azv.
SHA-1: 9b84e3f12bbad9333d1cea1973d6f563011f826a |
|
|
|
(0048220)
|
|
git
|
|
2015-11-16 15:48
|
|
Branch CR26252_4 has been updated forcibly by azv.
SHA-1: 265d5e85b2f4ea551d6d44d3725b89e53bdb5b57 |
|
|
|
(0048225)
|
|
msv
|
|
2015-11-16 16:02
|
|
|
|
|
(0048279)
|
|
apv
|
2015-11-17 13:42
(edited on: 2015-11-17 13:47) |
|
Dear BugMaster,
Branch CR26252_4 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 265d5e85b2f4ea551d6d44d3725b89e53bdb5b57
Number of compiler warnings:
occt component:
Linux: 3 (0 on master)
Windows: 0 (0 on master)
MacOS: 133 (129 on master)
products component :
Linux: 42 (39 on master)
Windows: 0 (0 on master)
There are new additional warnings:
on Linux (occt part):
http://jenkins-test-02.nnov.opencascade.com/view/CR26252-4-master/job/CR26252-4-master_build_occt_linux/1/warnings17Result/ [^]
on Linux (products part):
http://jenkins-test-02.nnov.opencascade.com/view/CR26252-4-master/job/CR26252-4-master_build_occt_products_linux/1/warnings17Result/ [^]
on MacOS (occt part):
http://jenkins-test-02.nnov.opencascade.com/view/CR26252-4-master/job/CR26252-4-master_prepare_build_occt_MacOS/1/warnings7Result/ [^]
Regressions/Differences:
http://occt-tests/CR26252-4-master-occt-64/Debian70-64/summary.html [^]
http://occt-tests/CR26252-4-master-occt-64/Windows-64-VC10/summary.html [^]
bugs modalg_2 bug5805_18
de iges_1 H8, N7, Q3, R1, R5
de iges_2 A7, C6, F9, G9
de iges_3 A4
de step_4 G7
http://occt-tests/CR26252-4-master-products-64/Debian70-64/summary.html [^]
http://occt-tests/CR26252-4-master-products-64/Windows-64-VC10/summary.html [^]
bfit pnt100 A4 (Windows only), A7
bfit pnt1000 A4
parasolid doc_3 B3, C3 (Windows only), E4
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 92331354 / 92305794 [+0.03%]
Total CPU difference: 19731.420000000006 / 19664.189999999875 [+0.34%]
Testing on Windows:
Total MEMORY difference: 57624822 / 57597574 [+0.05%]
Total CPU difference: 17897.183524798886 / 18115.101321698887 [-1.20%]
There are differences in images found by testdiff:
http://occt-tests/CR26252-4-master-occt-64/Debian70-64/diff-Debian70-64.html [^]
http://occt-tests/CR26252-4-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html [^]
offset with_intersect_80 L7
bugs modalg_4 bug697_4
bugs modalg_4 bug697_7
bugs modalg_4 bug697_8
bugs modalg_2 bug5805_45
bugs modalg_2 bug5805_46
bugs modalg_2 bug5805_47
bugs modalg_2 bug5805_48
|
|
|
|
(0048280)
|
|
apv
|
2015-11-17 13:44
(edited on: 2015-11-17 13:45) |
|
Dear azv,
Branch CR26252_4 has been rejected due to:
- additional warnings
- regressions/differences/improvements
- differences in images
|
|
|
|
(0048316)
|
|
git
|
|
2015-11-17 18:21
|
|
Branch CR26252_4 has been updated forcibly by azv.
SHA-1: e1473fbb3e7de082d57b0d9bb5f0532453a90471 |
|
|
|
(0048317)
|
|
azv
|
|
2015-11-17 18:24
|
|
Dear Alexey,
Branch CR26252_4 has been updated to eliminate additional warnings. Could you, please, rebuild it?
Regarding failed test cases:
* bugs modalg_2 bug5805_18
works better than master: offsetperform operation returns a result now
* de iges_1 H8 N7 Q3 R1 R5
de iges_2 F9 G9
have only differences in labels
* de iges_2 A7
already has difference in tolerance values on master, so the additional difference is in labels only
* de iges_2 C6
is an improvement: CHECKSHAPE faulty is eliminated
* de iges_3 A4
has changes in already bad data
* de step_4 G7
is really improvement
* bfit pnt100 A4 A7
bfit pnt1000 A4
are unstable and should be corrected according to new behavior
* parasolid doc_3 B3
is a recovery to initial state after making it BAD in scope of issue 0024682
* parasolid doc_3 C3 E4
are not regressions and should be changed according to new behavior
* offset with_intersect_80 L7
is an improvement: the offset shape is better than master
* bugs modalg_4 bug697_2 bug697_7 bug697_8
became the same behavior as on Linux, so the images should be get as reference
* bugs modalg_2 bug5805_45 bug5805_46 bug5805_47 bug5805_48
images are correct
As a result, please, update reference data for all the test cases above.
Thanks in advance. |
|
|
|
(0048369)
|
|
git
|
|
2015-11-19 12:19
|
|
Branch CR26252_4 has been updated by apv.
SHA-1: c3caa62c9f84a218c75b582873b152a5d2a7d55f
Detailed log of new commits:
Author: apv
Date: Thu Nov 19 12:18:59 2015 +0300
Update of test-cases according to the new behavior
|
|
|
|
(0048370)
|
|
apv
|
|
2015-11-19 12:21
|
|
|
Branch CR26252 has been created in products git-repository |
|
|
|
(0048371)
|
|
apv
|
|
2015-11-19 12:57
|
|
Dear BugMaster,
Branch CR26252_4 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: e1473fbb3e7de082d57b0d9bb5f0532453a90471
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS: 129 (129 on master)
products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)
Regressions/Differences:
Not detetcted
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 92244709 / 92796194 [-0.59%]
Total CPU difference: 19727.36999999991 / 19761.28999999987 [-0.17%]
Testing on Windows:
Total MEMORY difference: 58020907 / 57994251 [+0.05%]
Total CPU difference: 17965.44956239894 / 18209.591127398875 [-1.34%]
There are differences in images found by testdiff:
http://occt-tests/CR26252-4-master-occt-64/Debian70-64/diff-Debian70-64.html [^]
http://occt-tests/CR26252-4-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html [^] |
|
|
|
(0053090)
|
|
git
|
|
2016-04-17 14:14
|
|
Branch CR26252_1 has been deleted by kgv.
SHA-1: cf8ba8e96e5cdc79411039bf09afe404bc7719ed |
|
|
|
(0053091)
|
|
git
|
|
2016-04-17 14:14
|
|
Branch CR26252_2 has been deleted by kgv.
SHA-1: f2efb472744f078dfb3dae301805d6a6c05b939e |
|
|
|
(0053092)
|
|
git
|
|
2016-04-17 14:14
|
|
Branch CR26252_3 has been deleted by kgv.
SHA-1: 9b84e3f12bbad9333d1cea1973d6f563011f826a |
|
|
|
(0053093)
|
|
git
|
|
2016-04-17 14:14
|
|
Branch CR26252_4 has been deleted by kgv.
SHA-1: c3caa62c9f84a218c75b582873b152a5d2a7d55f |
|
parasolid_read_C9_face460_master.png (79,033) 2015-11-10 09:11