MantisBT - Community
View Issue Details
0026232Community[OCCT] OCCT:Modeling Datapublic2015-05-19 00:372015-10-23 20:51
Aaron Michalk 
bugmaster 
normalcrash 
closedfixed 
WindowsVC++ 201364 bit
[OCCT] 6.8.0 
[OCCT] 6.9.1[OCCT] 6.9.1 
Not needed
0026232: Multithreaded crash in IntAna_Int3Pln::Perform due to statics
Intermittently a crash occurs in IntAna_Int3Pln::Perform when called simultaneously by multiple threads. Crash is due to initialization of local statics inside the function.
N/A
Statics local to a function are not thread safe.
No tags attached.
Issue History
2015-05-19 00:37Aaron MichalkNew Issue
2015-05-19 00:37Aaron MichalkAssigned To => msv
2015-05-19 00:38Aaron MichalkNote Added: 0041260
2015-05-19 07:11gitNote Added: 0041261
2015-05-19 07:14abvNote Added: 0041262
2015-05-19 07:14abvStatusnew => resolved
2015-05-19 07:14abvTarget Version => 7.0.0
2015-05-19 07:14abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10485#r10485
2015-05-19 10:52msvNote Added: 0041264
2015-05-19 10:52msvAssigned Tomsv => bugmaster
2015-05-19 10:52msvStatusresolved => reviewed
2015-05-19 12:18mkvAssigned Tobugmaster => mkv
2015-05-19 12:21gitNote Added: 0041270
2015-05-20 14:30mkvNote Added: 0041312
2015-05-20 14:30mkvNote Added: 0041313
2015-05-20 14:30mkvAssigned Tomkv => bugmaster
2015-05-20 14:30mkvStatusreviewed => tested
2015-05-20 14:30mkvTest case number => Not needed
2015-05-22 12:19bugmasterChangeset attached => occt master 7e59624d
2015-05-22 12:19bugmasterStatustested => verified
2015-05-22 12:19bugmasterResolutionopen => fixed
2015-08-14 11:01gitNote Added: 0044273
2015-08-26 11:11abvTarget Version7.0.0 => 6.9.1
2015-10-16 14:56aivStatusverified => closed
2015-10-23 20:51aivFixed in Version => 6.9.1

Notes
(0041260)
Aaron Michalk   
2015-05-19 00:38   
Statics were introduced in 6.8.0.
(0041261)
git   
2015-05-19 07:11   
Branch CR26232 has been created by abv.

SHA-1: 3d632a6e008be4c9ce59a6fd37163d6ddad8e4a6


Detailed log of new commits:

Author: abv
Date: Tue May 19 07:10:35 2015 +0300

    0026232: Multithreaded crash in IntAna_Int3Pln::Perform due to statics
    
    "Static" keyword removed from local variable declarations in IntAna_Int3Pln::Perform()
(0041262)
abv   
2015-05-19 07:14   
Fix pushed to CR26232, please review.

Note that this statement:

> Statics were introduced in 6.8.0.

is false: they were present since at least beginning of OCCT Git history (6.5.0)
(0041264)
msv   
2015-05-19 10:52   
Reviewed.
(0041270)
git   
2015-05-19 12:21   
Branch CR26232 has been updated forcibly by mkv.

SHA-1: 96e5214d92191d0da1c9cf4d6332db61567907f4
(0041312)
mkv   
2015-05-20 14:30   
Dear BugMaster,
Branch CR26232 was rebased on current master of occt git-repository.
SHA-1: 96e5214d92191d0da1c9cf4d6332db61567907f4
(0041313)
mkv   
2015-05-20 14:30   
Dear BugMaster,
Branch CR26232 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 96e5214d92191d0da1c9cf4d6332db61567907f4

Number of compiler warnings:

occt component :
Linux: 25
Windows: 0 (0 on master)

products component :
Linux: 37
Windows: 0 (0 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 99781591 / 100379567 [-0.60%]
Total CPU difference: 19002.0800000001 / 19460.760000000177 [-2.36%]
products component :
Total MEMORY difference: 24182906 / 24391409 [-0.85%]
Total CPU difference: 7877.820000000015 / 7582.950000000026 [+3.89%]

Testing on Windows:
occt component :
Total MEMORY difference: 59014740 / 59221168 [-0.35%]
Total CPU difference: 17156.24117519893 / 16976.543623298945 [+1.06%]
products component :
Total MEMORY difference: 15655131 / 15659790 [-0.03%]
Total CPU difference: 6639.730162100001 / 6569.170909799987 [+1.07%]

There are no differences in images found by testdiff.
(0044273)
git   
2015-08-14 11:01   
Branch CR26232 has been deleted by inv.

SHA-1: 96e5214d92191d0da1c9cf4d6332db61567907f4