MantisBT - Open CASCADE
View Issue Details
0025991Open CASCADE[OCCT] OCCT:Codingpublic2015-03-31 09:592015-05-14 16:33
nbv 
bugmaster 
normalminor 
closedfixed 
 
[OCCT] 6.9.0[OCCT] 6.9.0 
Not needed
0025991: Fix cyclic dependency between IntPatch, GeomInt and GeomAPI packages
WOK cannot build current OCCT-master (from 27 Mar 2015) because there is Cyclic dependency between IntPatch, GeomInt and GeomAPI.

It has appeared after the fix bug #25416.
Test case is not required.
No tags attached.
related to 0021061assigned bugmaster Open CASCADE Elaborate a tool to control cyclic dependencies between toolkits 
related to 0025992closed bugmaster Open CASCADE Method Geom2dAPI_InterCurveCurve::Segment(...) requires detail revision 
Issue History
2015-03-31 09:59nbvNew Issue
2015-03-31 09:59nbvAssigned To => nbv
2015-03-31 10:49gitNote Added: 0039008
2015-03-31 11:00nbvStatusnew => assigned
2015-03-31 11:08nbvNote Added: 0039009
2015-03-31 11:08nbvAssigned Tonbv => msv
2015-03-31 11:08nbvStatusassigned => resolved
2015-03-31 11:08msvRelationship addedrelated to 0021061
2015-03-31 11:33nbvRelationship addedrelated to 0025992
2015-03-31 11:33nbvRelationship addedchild of 0025416
2015-03-31 12:01msvNote Added: 0039015
2015-03-31 12:01msvAssigned Tomsv => nbv
2015-03-31 12:01msvStatusresolved => assigned
2015-03-31 12:17gitNote Added: 0039018
2015-03-31 12:19gitNote Added: 0039019
2015-03-31 12:20nbvNote Added: 0039020
2015-03-31 12:20nbvAssigned Tonbv => msv
2015-03-31 12:20nbvStatusassigned => resolved
2015-03-31 12:36msvNote Added: 0039021
2015-03-31 12:36msvAssigned Tomsv => nbv
2015-03-31 12:36msvStatusresolved => assigned
2015-03-31 13:36gitNote Added: 0039024
2015-03-31 13:36nbvNote Added: 0039025
2015-03-31 13:36nbvAssigned Tonbv => msv
2015-03-31 13:36nbvStatusassigned => resolved
2015-03-31 14:37msvNote Added: 0039033
2015-03-31 14:37msvAssigned Tomsv => nbv
2015-03-31 14:37msvStatusresolved => assigned
2015-03-31 15:24gitNote Added: 0039038
2015-03-31 15:25nbvAssigned Tonbv => msv
2015-03-31 15:25nbvStatusassigned => resolved
2015-03-31 17:31msvNote Added: 0039051
2015-03-31 17:31msvAssigned Tomsv => bugmaster
2015-03-31 17:31msvStatusresolved => reviewed
2015-03-31 17:35mkvAssigned Tobugmaster => mkv
2015-03-31 17:54mkvAssigned Tomkv => bugmaster
2015-03-31 18:21mkvAssigned Tobugmaster => mkv
2015-04-01 14:11mkvNote Added: 0039092
2015-04-01 14:11mkvAssigned Tomkv => nbv
2015-04-01 14:11mkvStatusreviewed => assigned
2015-04-01 14:11mkvTest case number => Not needed
2015-04-01 16:42gitNote Added: 0039110
2015-04-01 16:44nbvNote Added: 0039111
2015-04-01 16:44nbvAssigned Tonbv => msv
2015-04-01 16:44nbvStatusassigned => resolved
2015-04-01 17:12gitNote Added: 0039112
2015-04-01 18:23msvNote Added: 0039119
2015-04-01 18:23msvAssigned Tomsv => bugmaster
2015-04-01 18:23msvStatusresolved => reviewed
2015-04-01 18:31mkvAssigned Tobugmaster => mkv
2015-04-01 20:09kgvSummaryCyclic dependency in OCCT detected by WOK compiler => Fix cyclic dependency between IntPatch, GeomInt and GeomAPI packages
2015-04-02 14:25mkvNote Added: 0039148
2015-04-02 14:25mkvAssigned Tomkv => bugmaster
2015-04-02 14:25mkvStatusreviewed => tested
2015-04-07 16:08bugmasterChangeset attached => occt master 7a91ad6e
2015-04-07 16:08bugmasterStatustested => verified
2015-04-07 16:08bugmasterResolutionopen => fixed
2015-05-14 15:28aivStatusverified => closed
2015-05-14 15:31aivFixed in Version => 6.9.0
2015-05-14 16:33gitNote Added: 0041051

Notes
(0039008)
git   
2015-03-31 10:49   
Branch CR25991 has been created by nbv.

SHA-1: 5235b98e2c86dcf43ac83f5f3bf5e6c7437206b3


Detailed log of new commits:

Author: nbv
Date: Mon Mar 30 13:03:02 2015 +0300

    0025991: Cyclic dependency in OCCT detected by WOK compiler
(0039009)
nbv   
2015-03-31 11:08   
Dear Mikhail!

Please review CR25991 branch.
(0039015)
msv   
2015-03-31 12:01   
Remarks:

src\GeomInt\GeomInt_IntSS_1.cxx
- 2070: this line is extra.
- 2287: Tol must be computed as distance in 3D between middle point on curve and projected point on surface.

src\IntPatch\IntPatch_ImpImpIntersection_0.gxx
- 1692: check for theExtr.NbExt() too.
(0039018)
git   
2015-03-31 12:17   
Branch CR25991 has been updated by nbv.

SHA-1: bf1c9118c795b61cdd83706ea459fb9441c34010


Detailed log of new commits:

Author: nbv
Date: Tue Mar 31 12:16:49 2015 +0300

    Changes in accordance with the last remarks

(0039019)
git   
2015-03-31 12:19   
Branch CR25991 has been updated forcibly by nbv.

SHA-1: 2888f084606d134f67333af76f55f1733662bc7f
(0039020)
nbv   
2015-03-31 12:20   
Dear Mikhail!

Please review CR25991 branch again.
(0039021)
msv   
2015-03-31 12:36   
Remarks:

src\GeomInt\GeomInt_IntSS_1.cxx
- 2284: no need to call Value, as we know it is a line, so pmidcurve2d can be computed as average between p1 and p2.
- 2287: Sorry, I was wrong in previous remark. Nor you compute distance between middle point of curve 2d lying on surface and projection of middle point of curve 3D lying also on surface. It is not correct. You should compute distance between PMid and aPC, so that to compare points got by same parameter (0.5) on both curves 2D and 3D. Projection of PMid is not needed.
(0039024)
git   
2015-03-31 13:36   
Branch CR25991 has been updated by nbv.

SHA-1: 46af72dffd20ca9c9e8f8ac7c97a42c03b8afe04


Detailed log of new commits:

Author: nbv
Date: Tue Mar 31 13:35:56 2015 +0300

    Another change in accordance with the last remark.

(0039025)
nbv   
2015-03-31 13:36   
Dear Mikhail!

Please review CR25991 branch again.
(0039033)
msv   
2015-03-31 14:37   
Remarks:

src\GeomInt\GeomInt_IntSS_1.cxx
- 2286: PMid is computed incorrect such way, earlier it was right (C->Value((f + l) * 0.5)). I told that we can get average only for 2D points. For 3D curve we don't know anything about its form.
- 2290: This expression will be more clear if we use Max function.
(0039038)
git   
2015-03-31 15:24   
Branch CR25991 has been updated by nbv.

SHA-1: 564c517b4dc7351f96ad3f320219191b5f99c7c3


Detailed log of new commits:

Author: nbv
Date: Tue Mar 31 15:23:49 2015 +0300

    Small correction in accordance with the last remark

(0039051)
msv   
2015-03-31 17:31   
Reviewed.
(0039092)
mkv   
2015-04-01 14:11   
Dear BugMaster,
Branch CR25991 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 564c517b4dc7351f96ad3f320219191b5f99c7c3

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

Linux: 4 (4 on master)
Windows: 0 (0 on master)

Regressions/Differences:
http://occt-tests/CR25991-master-occt-64/Debian60-64/summary.html [^]
http://occt-tests/CR25991-master-occt-64/Windows-64-VC10/summary.html [^]
bugs modalg_1(006) bug13209_1, bug13209_2, bug13209_3, bug13209_4, bug13211_1, bug13211_2, bug13211_3, bug13211_4, bug13211_5, bug13211_6, bug13211_7, bug13211_8, bug13211_9, bug13211_10, bug13211_11
bugs modalg_2(007) bug497_3
bugs modalg_4(009) bug6272_1, bug6272_2, bug6272_6
bugs moddata_2(012) bug26_1, bug26_2

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 86251242 / 87690639 [-1.64%]
Total CPU difference: 52494.319999999985 / 53987.32000000018 [-2.77%]
products component :
Total MEMORY difference: 23135408 / 23072364 [+0.27%]
Total CPU difference: 15270.179999999966 / 15577.929999999984 [-1.98%]

Testing on Windows:
occt component :
Total MEMORY difference: 56715025 / 56727606 [-0.02%]
Total CPU difference: 16082.923094999784 / 16045.389254399674 [+0.23%]
products component :
Total MEMORY difference: 12914976 / 12890096 [+0.19%]
Total CPU difference: 5364.312786399981 / 5360.303560699987 [+0.07%]

There are no differences in images found by testdiff.
(0039110)
git   
2015-04-01 16:42   
Branch CR25991 has been updated forcibly by nbv.

SHA-1: 7d49fcd65683a81b11edd0e4bb4c00ef324be4fa
(0039111)
nbv   
2015-04-01 16:44   
Dear Mikhail!

Please review CR25991 branch.
(0039112)
git   
2015-04-01 17:12   
Branch CR25991 has been updated forcibly by nbv.

SHA-1: f05907df59fdb39d5195cee8cdd9b0795fae49dc
(0039119)
msv   
2015-04-01 18:23   
Reviewed.
(0039148)
mkv   
2015-04-02 14:25   
Dear BugMaster,
Branch CR25991 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: f05907df59fdb39d5195cee8cdd9b0795fae49dc

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 4 (4 on master)
Windows: 0 (0 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 86810889 / 87731477 [-1.05%]
Total CPU difference: 53898.33000000041 / 54199.67000000014 [-0.56%]
products component :
Total MEMORY difference: 23137219 / 23044092 [+0.40%]
Total CPU difference: 15499.789999999985 / 15490.389999999983 [+0.06%]

Testing on Windows:
occt component :
Total MEMORY difference: 56846556 / 56859601 [-0.02%]
Total CPU difference: 16319.389410799788 / 16113.24968939968 [+1.28%]
products component :
Total MEMORY difference: 12914978 / 12890096 [+0.19%]
Total CPU difference: 5437.78925739998 / 5360.303560699987 [+1.45%]

There are no differences in images found by testdiff.
(0041051)
git   
2015-05-14 16:33   
Branch CR25991 has been deleted by inv.

SHA-1: f05907df59fdb39d5195cee8cdd9b0795fae49dc