MantisBT - Community
View Issue Details
0025955Community[OCCT] OCCT:Visualizationpublic2015-03-17 20:232015-05-14 15:31
Pawel 
bugmaster 
normaltrivial 
closedfixed 
 
[OCCT] 6.9.0[OCCT] 6.9.0 
Not needed
0025955: Visualization, AIS_Shape::UnsetColor() - fix storing color in a local variable
Quantity_Color aColor = aDefaultMat.AmbientColor();
if (myDrawer->HasLink())
{
  Quantity_Color aColor = myDrawer->Link()->ShadingAspect()->Color (myCurrentFacingModel);
}
mat.SetColor (aColor);
Not applicable.
No tags attached.
Issue History
2015-03-17 20:23PawelNew Issue
2015-03-17 20:23PawelAssigned To => Pawel
2015-03-17 20:28gitNote Added: 0038454
2015-03-17 20:29PawelNote Added: 0038455
2015-03-17 20:29PawelAssigned ToPawel => kgv
2015-03-17 20:29PawelStatusnew => resolved
2015-03-17 20:29PawelSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9648#r9648
2015-03-19 09:21kgvNote Added: 0038673
2015-03-19 09:21kgvAssigned Tokgv => bugmaster
2015-03-19 09:21kgvSeverityminor => trivial
2015-03-19 09:21kgvStatusresolved => reviewed
2015-03-19 09:21kgvProduct Version6.9.0 =>
2015-03-19 09:21kgvSummaryAIS_Shape::UnsetColor - Storing color in a local variable => Visualization, AIS_Shape::UnsetColor() - fix storing color in a local variable
2015-03-19 09:21kgvRelationship addedchild of 0025773
2015-03-19 10:22apvAssigned Tobugmaster => apv
2015-03-19 16:06apvTest case number => Not needed
2015-03-19 16:17apvNote Added: 0038695
2015-03-19 16:17apvAssigned Toapv => bugmaster
2015-03-19 16:17apvStatusreviewed => tested
2015-03-20 13:34bugmasterChangeset attached => occt master 4e2914a6
2015-03-20 13:34bugmasterStatustested => verified
2015-03-20 13:34bugmasterResolutionopen => fixed
2015-04-09 09:49gitNote Added: 0039449
2015-05-14 15:28aivStatusverified => closed
2015-05-14 15:31aivFixed in Version => 6.9.0

Notes
(0038454)
git   
2015-03-17 20:28   
Branch CR25955 has been created by Pawel.

SHA-1: d0ba264ff1a858749e0820948cc099d8433cda93


Detailed log of new commits:

Author: Pawel
Date: Tue Mar 17 18:27:49 2015 +0100

    Removed the color declaration overriding another variable.
(0038455)
Pawel   
2015-03-17 20:29   
Branch 25955 pushed. Please review.
(0038673)
kgv   
2015-03-19 09:21   
Please test the patch
(0038695)
apv   
2015-03-19 16:17   
Dear BugMaster,

Branch CR25955 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: d0ba264ff1a858749e0820948cc099d8433cda93

Number of compiler warnings:
occt component:
   Linux: 18 (18 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 11 (11 on master)
   Windows: 4 (4 on master)

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 89826858 / 90001620
Total CPU difference: 58339.789999999986 / 58911.169999999984

Testing on Windows:
Total MEMORY difference: 58088432 / 58093704
Total CPU difference: 48598.46875 / 57284.859375
(0039449)
git   
2015-04-09 09:49   
Branch CR25955 has been deleted by kgv.

SHA-1: d0ba264ff1a858749e0820948cc099d8433cda93