MantisBT - Community
View Issue Details
0025954Community[OCCT] OCCT:Modeling Algorithmspublic2015-03-17 19:382015-05-14 16:31
Pawel 
apn 
normaltweak 
closedfixed 
[OCCT] 6.8.0 
[OCCT] 6.9.0[OCCT] 6.9.0 
Not needed
0025954: GeomPlate_Surface::SetBounds formatting/logic mismatch
I suggest to convert the following lines

if ((Umin>Umax) || (Vmin>Vmax)) Standard_Failure::Raise("Bounds haven't the good sense");
  else
    myUmin=Umin;myUmax=Umax;myVmin=Vmin;myVmax=Vmax;
if ((Umin==Umax) || (Vmin==Vmax)) Standard_Failure::Raise("Bounds are equal");

into

if ((Umin>Umax) || (Vmin>Vmax)) Standard_Failure::Raise("Bounds haven't the good sense");
if ((Umin==Umax) || (Vmin==Vmax)) Standard_Failure::Raise("Bounds are equal");
myUmin=Umin;myUmax=Umax;myVmin=Vmin;myVmax=Vmax;

to avoid confusion.

The condition
else
   myUmin=Umin;myUmax=Umax;myVmin...

might be misleading because only the first assignment is performed in else-case.
Not required.
No tags attached.
Issue History
2015-03-17 19:38PawelNew Issue
2015-03-17 19:38PawelAssigned To => Pawel
2015-03-17 19:43gitNote Added: 0038451
2015-03-17 19:46PawelNote Added: 0038452
2015-03-17 19:46PawelAssigned ToPawel => msv
2015-03-17 19:46PawelStatusnew => resolved
2015-03-17 19:46PawelSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9646#r9646
2015-03-20 18:01gitNote Added: 0038765
2015-03-20 18:02gitNote Added: 0038766
2015-03-20 18:03msvNote Added: 0038767
2015-03-20 18:03msvAssigned Tomsv => bugmaster
2015-03-20 18:03msvStatusresolved => reviewed
2015-03-20 18:09mkvAssigned Tobugmaster => mkv
2015-03-23 19:01mkvNote Added: 0038814
2015-03-23 19:01mkvAssigned Tomkv => msv
2015-03-23 19:01mkvStatusreviewed => feedback
2015-03-23 19:01mkvTest case number => Not needed
2015-03-24 12:25msvNote Added: 0038828
2015-03-24 12:25msvAssigned Tomsv => bugmaster
2015-03-24 12:25msvStatusfeedback => reviewed
2015-03-24 12:25msvAssigned Tobugmaster => mkv
2015-03-24 13:04mkvNote Added: 0038833
2015-03-24 13:04mkvAssigned Tomkv => bugmaster
2015-03-24 13:04mkvStatusreviewed => tested
2015-03-27 17:42apnChangeset attached => occt master 2a8523ac
2015-03-27 17:42apnAssigned Tobugmaster => apn
2015-03-27 17:42apnStatustested => verified
2015-03-27 17:42apnResolutionopen => fixed
2015-05-14 15:28aivStatusverified => closed
2015-05-14 15:31aivFixed in Version => 6.9.0
2015-05-14 16:31gitNote Added: 0041033

Notes
(0038451)
git   
2015-03-17 19:43   
Branch CR25954 has been created by Pawel.

SHA-1: 7348b8491668b2c50be22f6b7262a610002fd019


Detailed log of new commits:

Author: Pawel
Date: Tue Mar 17 17:43:21 2015 +0100

    Corrected logic/formatting discrepancy.
(0038452)
Pawel   
2015-03-17 19:46   
Branch CR25954 pushed. Please review.
(0038765)
git   
2015-03-20 18:01   
Branch CR25954 has been updated forcibly by msv.

SHA-1: 7f224d188bd84b2968b5d705335e4b87b7c755c5
(0038766)
git   
2015-03-20 18:02   
Branch CR25954 has been updated forcibly by msv.

SHA-1: 7ae5625447b81f4f6c4ccf6a6b872be2943f9674
(0038767)
msv   
2015-03-20 18:03   
Reviewed.
I have corrected the commit message and rebased the branch on current master.
(0038814)
mkv   
2015-03-23 19:01   
Dear BugMaster,
Branch CR25954 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 7ae5625447b81f4f6c4ccf6a6b872be2943f9674

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 11 (11 on master)
Windows: 4 (4 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 88536122 / 88602162 [-0.07%]
Total CPU difference: 53804.150000000016 / 53186.30000000024 [+1.16%]
products component :
Total MEMORY difference: 23123802 / 23198252 [-0.32%]
Total CPU difference: 15102.849999999991 / 16301.109999999973 [-7.35%]

Testing on Windows:
occt component :
Total MEMORY difference: 57427344 / 56676403 [+1.32%]
Total CPU difference: 45886.984375 / 15129.694584599707 [+203.29%]
products component :
Total MEMORY difference: 15078169 / 15023928 [+0.36%]
Total CPU difference: 15809.578125 / 5841.473045099963 [+170.64%]

There are following differences in images found by testdiff.
http://occt-tests/CR25954-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html [^]
IMAGE caf presentation K1: K1.png differs
IMAGE caf presentation H1: H1.png differs
IMAGE caf presentation I1: I1.png differs
IMAGE caf presentation G1: G1.png differs
IMAGE caf presentation J1: J1.png differs
(0038828)
msv   
2015-03-24 12:25   
Dear mkv, the changes in the pictures could not be caused by this fix, because the changed code is not called at all in these test cases. On my PC these tests give the same picture as on master.
(0038833)
mkv   
2015-03-24 13:04   
OK.
Branch CR25954 is TESTED.
(0041033)
git   
2015-05-14 16:31   
Branch CR25954 has been deleted by inv.

SHA-1: 7ae5625447b81f4f6c4ccf6a6b872be2943f9674