MantisBT - Community
View Issue Details
0025953Community[OCCT] OCCT:Modeling Algorithmspublic2015-03-17 18:082015-05-14 16:31
Pawel 
apn 
normalminor 
closedfixed 
[OCCT] 6.8.0 
[OCCT] 6.9.0[OCCT] 6.9.0 
Not needed
0025953: BRepMesh_PairOfIndex::Prepend - variable assigned twice
In the lines:

myIndex[1] = myIndex[0];
myIndex[1] = theIndex;

the prependen index should probably be written into myIndex[0].
Not applicable. Code analysis / no reproducer.
No tags attached.
Issue History
2015-03-17 18:08PawelNew Issue
2015-03-17 18:08PawelAssigned To => Pawel
2015-03-17 18:15gitNote Added: 0038446
2015-03-17 18:19PawelNote Added: 0038447
2015-03-17 18:19PawelAssigned ToPawel => msv
2015-03-17 18:19PawelStatusnew => resolved
2015-03-17 18:19PawelSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9642#r9642
2015-03-20 17:21gitNote Added: 0038759
2015-03-20 17:29msvNote Added: 0038760
2015-03-20 17:31gitNote Added: 0038761
2015-03-20 17:33msvNote Added: 0038764
2015-03-20 17:33msvAssigned Tomsv => bugmaster
2015-03-20 17:33msvStatusresolved => reviewed
2015-03-20 17:35apvAssigned Tobugmaster => apv
2015-03-20 18:16PawelNote Added: 0038768
2015-03-23 17:12apvTest case number => Not needed
2015-03-23 17:13apvNote Added: 0038797
2015-03-23 17:13apvAssigned Toapv => bugmaster
2015-03-23 17:13apvStatusreviewed => tested
2015-03-27 17:42apnChangeset attached => occt master a3ac9c24
2015-03-27 17:42apnAssigned Tobugmaster => apn
2015-03-27 17:42apnStatustested => verified
2015-03-27 17:42apnResolutionopen => fixed
2015-05-14 15:28aivStatusverified => closed
2015-05-14 15:31aivFixed in Version => 6.9.0
2015-05-14 16:31gitNote Added: 0041032

Notes
(0038446)
git   
2015-03-17 18:15   
Branch CR25953 has been created by Pawel.

SHA-1: 100d4de75c7f9ad19b9897e4e6842af6ea3d0667


Detailed log of new commits:

Author: Pawel
Date: Tue Mar 17 16:15:21 2015 +0100

    Corrected index assignment.
(0038447)
Pawel   
2015-03-17 18:19   
Branch CR25953 pushed. Please review.
(0038759)
git   
2015-03-20 17:21   
Branch CR25953 has been updated forcibly by msv.

SHA-1: 1d8454bb5c69978396bb40ded35981f384b00010
(0038760)
msv   
2015-03-20 17:29   
Dear Pawel,
Thank you for this bug fix. I have analyzed the source code and can confirm that this is a misprint and your fix is right. Though it does not make sense for current OCC algorithms, because the method Prepend is not called from anywhere.

Concerning the patch preparation, I would ask you further to follow the rules listed in the "Contribution Workflow" guide, section "Resolving the issue" (http://dev.opencascade.org/doc/overview/html/occt_dev_guides__contribution_workflow.html#occt_contribution_workflow_2_4 [^]), in particular the third bullet. Now I have updated the branch as needed.
(0038761)
git   
2015-03-20 17:31   
Branch CR25953 has been updated by msv.

SHA-1: 165ff4ff24317fb464bbe3e52d48ac494037b79a


Detailed log of new commits:

Author: msv
Date: Fri Mar 20 17:31:43 2015 +0300

    Minor change in exception message.

(0038764)
msv   
2015-03-20 17:33   
Reviewed.
Dear bugmaster, I think it is not necessary to perform tests, because the changed code is not used anywhere.
(0038768)
Pawel   
2015-03-20 18:16   
Dear msv,

yes, I forgot to place the bug number in the comment. It's been a while since I committed something last time. I'll try to remember next time ;)

Pawel
(0038797)
apv   
2015-03-23 17:13   
Dear BugMaster,

Branch CR25953 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms.
SHA-1: 165ff4ff24317fb464bbe3e52d48ac494037b79a

Number of compiler warnings:
occt component:
   Linux: 18 (18 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 11 (11 on master)
   Windows: 4 (4 on master)
(0041032)
git   
2015-05-14 16:31   
Branch CR25953 has been deleted by inv.

SHA-1: 165ff4ff24317fb464bbe3e52d48ac494037b79a