MantisBT - Open CASCADE
View Issue Details
0025933Open CASCADE[OCCT] OCCT:Visualizationpublic2015-03-13 16:562015-05-14 15:31
vpa 
bugmaster 
normalminor 
closedfixed 
[OCCT] 6.8.0 
[OCCT] 6.9.0[OCCT] 6.9.0 
Not needed
0025933: Visualization - Forward AIS_InteractiveObject::Redisplay() execution to AIS_InteractiveContext
To avoid incorrect update of dependent structures after direct calls to AIS_InteractiveObject::Redisplay(), it is needed to change behavior of the method mentioned and forward its execution to AIS_InteractiveObject::Redisplay() one.
Not required
No tags attached.
related to 0024623closed bugmaster Visualization - improve selection mechanism 
Issue History
2015-03-13 16:56vpaNew Issue
2015-03-13 16:56vpaAssigned To => vpa
2015-03-13 16:57vpaStatusnew => assigned
2015-03-13 16:58vpaRelationship addedrelated to 0024623
2015-03-13 18:49gitNote Added: 0038356
2015-03-13 18:53gitNote Added: 0038357
2015-03-13 18:55vpaNote Added: 0038358
2015-03-13 18:55vpaAssigned Tovpa => san
2015-03-13 18:55vpaStatusassigned => resolved
2015-03-13 18:56abvNote Added: 0038359
2015-03-13 19:34vpaSummaryVisualization - Remove method Redisplay() from AIS_InteractiveObject => Visualization - Forward AIS_InteractiveObject::Redisplay() execution to AIS_InteractiveContext
2015-03-13 19:34vpaDescription Updatedbug_revision_view_page.php?rev_id=9614#r9614
2015-03-13 19:40gitNote Added: 0038362
2015-03-13 19:42vpaNote Added: 0038363
2015-03-13 21:51kgvNote Added: 0038364
2015-03-17 13:08sanNote Added: 0038424
2015-03-17 13:08sanAssigned Tosan => bugmaster
2015-03-17 13:08sanStatusresolved => reviewed
2015-03-17 14:35mkvAssigned Tobugmaster => mkv
2015-03-18 14:45gitNote Added: 0038640
2015-03-18 14:46mkvNote Added: 0038641
2015-03-18 14:46mkvAssigned Tomkv => bugmaster
2015-03-18 14:46mkvStatusreviewed => tested
2015-03-18 14:46mkvTest case number => Not needed
2015-03-20 13:34bugmasterChangeset attached => occt master 36132a2e
2015-03-20 13:34bugmasterStatustested => verified
2015-03-20 13:34bugmasterResolutionopen => fixed
2015-04-09 09:49gitNote Added: 0039447
2015-05-14 15:28aivStatusverified => closed
2015-05-14 15:31aivFixed in Version => 6.9.0

Notes
(0038356)
git   
2015-03-13 18:49   
Branch CR25933 has been created by vpa.

SHA-1: bd3554136c519be36b88d6effd762d488ea7c7b9


Detailed log of new commits:

Author: vpa
Date: Fri Mar 13 18:49:30 2015 +0300

    0025933: Visualization - Remove method Redisplay() from AIS_InteractiveObject
    
    All calls of AIS_InteractiveObject::Redisplay were replaced by AIS_InteractiveContext::Redisplay ones or
    correspondent updates of object
(0038357)
git   
2015-03-13 18:53   
Branch CR25933 has been updated forcibly by vpa.

SHA-1: 399b4d5670b6f4d177c5b8422be8af898ca79ae7
(0038358)
vpa   
2015-03-13 18:55   
Dear Sergey,

the patch in branch CR25933 is ready to be reviewed.
(0038359)
abv   
2015-03-13 18:56   
Would not it be convenient to keep Redisplay() in object, redirecting it to context? I imagine that I might need to do this if I have object only.
(0038362)
git   
2015-03-13 19:40   
Branch CR25933 has been updated forcibly by vpa.

SHA-1: 393091c3bdd06edff4194530a10f4e7ed384e81e
(0038363)
vpa   
2015-03-13 19:42   
Dear Andrey,

the patch in branch CR25933 was updated according to your remark.
(0038364)
kgv   
2015-03-13 21:51   
> Would not it be convenient to keep Redisplay() in object, redirecting it to context?
> I imagine that I might need to do this if I have object only.
This will be incorrect by design, because object might be displayed in several contexts. Although this is rarely happens.
(0038424)
san   
2015-03-17 13:08   
Branch CR25933 reviewed without remarks, ready for testing.
(0038640)
git   
2015-03-18 14:45   
Branch CR25933 has been updated by mkv.

SHA-1: e5e39a762ca0f9ac40867dcb2d8ecd9c0e2198b4


Detailed log of new commits:

Author: mkv
Date: Wed Mar 18 14:45:18 2015 +0300

    Small correction of test case

(0038641)
mkv   
2015-03-18 14:46   
Dear BugMaster,
Branch CR25933 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 393091c3bdd06edff4194530a10f4e7ed384e81e

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 11 (11 on master)
Windows: 4 (4 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 90159687 / 90114426
Total CPU difference: 58319.9200000002 / 58911.169999999984
products component :
Total MEMORY difference: 22959688 / 23045996
Total CPU difference: 15444.819999999982 / 16097.579999999978

Testing on Windows:
occt component :
Total MEMORY difference: 57858634 / 57860583
Total CPU difference: 50578.3125 / 54907.96875
products component :
Total MEMORY difference: 15053862 / 15056278
Total CPU difference: 16752.71875 / 16748.84375

There are no differences in images found by testdiff.
(0039447)
git   
2015-04-09 09:49   
Branch CR25933 has been deleted by kgv.

SHA-1: e5e39a762ca0f9ac40867dcb2d8ecd9c0e2198b4