MantisBT - Community
View Issue Details
0025813Community[OCCT] OCCT:Modeling Algorithmspublic2015-02-10 15:512016-04-20 15:50
shoogen 
bugmaster 
normalminor 
closedfixed 
[OCCT] 6.8.0 
[OCCT] 7.0.0[OCCT] 7.0.0 
bugs modalg_6 bug25813_1, bug25813_2, bug25813_3, bug25813_4, bug25813_5
0025813: regression in Hidden Line Removal
Some of the problems seem in HLR seem to be regressions, as OCE 0.9.1 (based on OCCT 6.5.2) gives better results then OCCT 6.8.1-dev, 6.7.0 and OCE 0.16
bug25813_1, bug25813_2, bug25813_3, bug25813_4, bug25813_5
No tags attached.
related to 0023709closed aba Open CASCADE Redesign of hlrtest command 
png hlr-bus1.png (19,199) 2015-02-10 15:51
https://tracker.dev.opencascade.org/
png hlr-bus1-oce0_9_1.png (15,111) 2015-02-10 15:52
https://tracker.dev.opencascade.org/
zip hlr-bus1.zip (22,698) 2015-02-12 02:00
https://tracker.dev.opencascade.org/
png hlr-torus1.png (4,858) 2015-02-12 22:05
https://tracker.dev.opencascade.org/
png hlr-test_normandc1m1a.png (14,276) 2015-02-14 22:13
https://tracker.dev.opencascade.org/
? hlr-test_normandc1m1-draw-Cut001.brep (30,096) 2015-02-14 22:14
https://tracker.dev.opencascade.org/
txt hlr-test_normandc1m1.txt (875) 2015-02-14 22:15
https://tracker.dev.opencascade.org/
png hlr-fillet1.png (2,023) 2015-02-20 13:57
https://tracker.dev.opencascade.org/
txt hlr-fillet1.txt (468) 2015-02-20 13:59
https://tracker.dev.opencascade.org/
png hlr-fillet2.png (5,736) 2015-04-08 17:33
https://tracker.dev.opencascade.org/
? hlr-fillet2-tcl-f.brep (108,539) 2015-04-08 17:37
https://tracker.dev.opencascade.org/
? hlr-fillet2.tcl (424) 2015-04-08 17:38
https://tracker.dev.opencascade.org/
? CR25813.gitbundle (2,820) 2015-04-09 20:21
https://tracker.dev.opencascade.org/
Issue History
2015-02-10 15:51shoogenNew Issue
2015-02-10 15:51shoogenAssigned To => msv
2015-02-10 15:51shoogenFile Added: hlr-bus1.png
2015-02-10 15:52shoogenFile Added: hlr-bus1-oce0_9_1.png
2015-02-12 02:00shoogenFile Added: hlr-bus1.zip
2015-02-12 22:05shoogenFile Added: hlr-torus1.png
2015-02-12 22:07shoogenNote Added: 0037468
2015-02-14 22:13shoogenFile Added: hlr-test_normandc1m1a.png
2015-02-14 22:14shoogenFile Added: hlr-test_normandc1m1-draw-Cut001.brep
2015-02-14 22:15shoogenFile Added: hlr-test_normandc1m1.txt
2015-02-20 13:57shoogenFile Added: hlr-fillet1.png
2015-02-20 13:59shoogenFile Added: hlr-fillet1.txt
2015-04-08 17:33shoogenFile Added: hlr-fillet2.png
2015-04-08 17:37shoogenFile Added: hlr-fillet2-tcl-f.brep
2015-04-08 17:38shoogenFile Added: hlr-fillet2.tcl
2015-04-09 11:47shoogenNote Added: 0039475
2015-04-09 12:23shoogenNote Added: 0039482
2015-04-09 12:51msvRelationship addedrelated to 0023709
2015-04-09 16:12shoogenNote Edited: 0039475bug_revision_view_page.php?bugnote_id=39475#r9885
2015-04-09 16:14shoogenNote Edited: 0039475bug_revision_view_page.php?bugnote_id=39475#r9886
2015-04-09 18:11shoogenNote Edited: 0039475bug_revision_view_page.php?bugnote_id=39475#r9901
2015-04-09 19:02shoogenNote Added: 0039530
2015-04-09 20:21shoogenFile Added: CR25813.gitbundle
2015-04-09 20:30shoogenNote Added: 0039536
2015-04-09 23:50msvRelationship addedrelated to 0023625
2015-04-10 10:00abvTarget Version => 6.9.0
2015-04-20 15:19msvAssigned Tomsv => jgv
2015-04-20 15:19msvStatusnew => assigned
2015-04-30 16:43msvTarget Version6.9.0 => 7.1.0
2016-03-09 17:47gitNote Added: 0051483
2016-03-09 17:49jgvNote Added: 0051484
2016-03-09 17:49jgvAssigned Tojgv => msv
2016-03-09 17:49jgvStatusassigned => resolved
2016-03-09 17:49jgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13144#r13144
2016-03-09 17:58msvNote Added: 0051486
2016-03-09 17:58msvAssigned Tomsv => bugmaster
2016-03-09 17:58msvStatusresolved => reviewed
2016-03-09 18:10apvAssigned Tobugmaster => apv
2016-03-10 14:03apvTest case number => bugs modalg_6 bug25813_1, bug25813_2, bug25813_3, bug25813_4, bug25813_5
2016-03-10 17:32gitNote Added: 0051529
2016-03-10 18:07apvNote Added: 0051532
2016-03-10 18:07apvAssigned Toapv => jgv
2016-03-10 18:07apvStatusreviewed => assigned
2016-03-10 18:11apvNote Added: 0051533
2016-03-11 13:37jgvNote Added: 0051553
2016-03-11 13:37jgvAssigned Tojgv => apv
2016-03-11 13:37jgvStatusassigned => feedback
2016-03-14 14:59gitNote Added: 0051594
2016-03-14 14:59apvAssigned Toapv => abv
2016-03-14 15:01apvNote Added: 0051597
2016-03-15 17:31abvNote Added: 0051665
2016-03-15 17:31abvAssigned Toabv => apv
2016-03-15 19:36apvAssigned Toapv => bugmaster
2016-03-15 19:36apvStatusfeedback => tested
2016-03-25 10:49bugmasterTarget Version7.1.0 => 7.0.0
2016-03-29 15:55bugmasterChangeset attached => occt master f6fd8f0b
2016-03-29 15:55bugmasterStatustested => verified
2016-03-29 15:55bugmasterResolutionopen => fixed
2016-04-17 13:40gitNote Added: 0052888
2016-04-20 15:43aivFixed in Version => 7.0.0
2016-04-20 15:50aivStatusverified => closed

Notes
(0037468)
shoogen   
2015-02-12 22:07   
I found a simpler example (without external shapes)

pload MODELING
ptorus Torus 10 2 -180 180 360
hprj Shape2DView_proj 0 0 0 0 1 0 0 0 1
houtl Shape2DView_outl Torus
hfill Shape2DView_outl Shape2DView_proj 0
hload Shape2DView_outl
hsetprj Shape2DView_proj
hupdate
hhide
hres2d
#compound vl v1l vnl vol vil hl h1l hnl hol hil Shape2DView
#donly Shape2DView
(0039475)
shoogen   
2015-04-09 11:47   
(edited on: 2015-04-09 18:11)
One of the problems was introduced in OCE between versions 0.12 (6.5.4) and 0.13 (6.6.0).
reverting http://git.dev.opencascade.org/gitweb/?p=occt.git;a=commitdiff;h=0a768f56848d12b18c41422554f35a40c72b6d02#patch13 [^]
solves the problem shown by "hlr-fillet2" and improves the output for "hlr-bus1".
The problem with "hlr-fillet1" was introduced between OCE versions 0.14 (6.6.0) and 0.15 (6.7.0).

(0039482)
shoogen   
2015-04-09 12:23   
please add a relation to 0023709
(0039530)
shoogen   
2015-04-09 19:02   
please add a relation to #0023625.
(0039536)
shoogen   
2015-04-09 20:30   
CR25813 does not contain a bugfix. It just proofs that the problems are regressions introduced by 0a768f5 and bda8360.
(0051483)
git   
2016-03-09 17:47   
Branch CR25813 has been created by jgv.

SHA-1: 0ac1eec4403274c51db6f932119e657aefe96abc


Detailed log of new commits:

Author: jgv
Date: Wed Mar 9 17:46:55 2016 +0300

    0025813: regression in Hidden Line Removal
    Regressions that appeared in OCCT 6.6.0 are fixed.
(0051484)
jgv   
2016-03-09 17:49   
Please review the branch CR25813.
(0051486)
msv   
2016-03-09 17:58   
Reviewed.
(0051529)
git   
2016-03-10 17:32   
Branch CR25813 has been updated by apv.

SHA-1: 099656a3e92d9a6b34591c828dee9bb4d8c2b097


Detailed log of new commits:

Author: apv
Date: Thu Mar 10 17:31:51 2016 +0300

    Correction of test cases for issue 0025813

(0051532)
apv   
2016-03-10 18:07   
Dear BugMaster,

Branch CR25813 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 0ac1eec4403274c51db6f932119e657aefe96abc

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MacOS: 0 (0 on master)
products component:
   Linux: 41 (41 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
http://occt-tests/CR25813-master-occt-64/Debian70-64/summary.html [^]
http://occt-tests/CR25813-master-occt-64/Windows-64-VC10/summary.html [^]
bugs modalg_6 bug25908

Testing cases:
bugs modalg_6 bug25813_1 - OK
http://occt-tests/CR25813-master-occt-64/Debian70-64/bugs/modalg_6/bug25813_1.html [^]
http://occt-tests/CR25813-master-occt-64/Windows-64-VC10/bugs/modalg_6/bug25813_1.html [^]
bugs modalg_6 bug25813_2 - OK
http://occt-tests/CR25813-master-occt-64/Debian70-64/bugs/modalg_6/bug25813_2.html [^]
http://occt-tests/CR25813-master-occt-64/Windows-64-VC10/bugs/modalg_6/bug25813_2.html [^]
bugs modalg_6 bug25813_3 - OK
http://occt-tests/CR25813-master-occt-64/Debian70-64/bugs/modalg_6/bug25813_3.html [^]
http://occt-tests/CR25813-master-occt-64/Windows-64-VC10/bugs/modalg_6/bug25813_3.html [^]
bugs modalg_6 bug25813_4 - OK
http://occt-tests/CR25813-master-occt-64/Debian70-64/bugs/modalg_6/bug25813_4.html [^]
http://occt-tests/CR25813-master-occt-64/Windows-64-VC10/bugs/modalg_6/bug25813_4.html [^]
bugs modalg_6 bug25813_5 - OK
http://occt-tests/CR25813-master-occt-64/Debian70-64/bugs/modalg_6/bug25813_5.html [^]
http://occt-tests/CR25813-master-occt-64/Windows-64-VC10/bugs/modalg_6/bug25813_5.html [^]

Testing on Linux:
Total MEMORY difference: 89763398 / 89810039 [-0.05%]
Total CPU difference: 19179.149999999943 / 19348.249999999996 [-0.87%]

Testing on Windows:
Total MEMORY difference: 57953193 / 58015407 [-0.11%]
Total CPU difference: 18027.007556998902 / 18102.59004149884 [-0.42%]

There is difference in images found by testdiff:
http://occt-tests/CR25813-master-occt-64/Debian70-64/diff-Debian70-64.html [^]
http://occt-tests/CR25813-master-occt-64/Windows-64-VC10/diff-Windows-64-VC10.html [^]
bugs modalg_5 bug24842_front
(0051533)
apv   
2016-03-10 18:11   
Dear jgv,

Branch CR25813 has been rejected due to:
- regressions/differences/improvements
- differences in images

Moreover, please validate modifications and images for test cases:
bugs modalg_6 bug25813_1, bug25813_2, bug25813_3, bug25813_4, bug25813_5
(0051553)
jgv   
2016-03-11 13:37   
Dear Alexey,

bugs modalg_6 bug25908
is not regression, please update reference data to new state;

difference "bugs modalg_5 bug24842_front" is improvement;

test cases are OK.
(0051594)
git   
2016-03-14 14:59   
Branch CR25813 has been updated by apv.

SHA-1: e5aaf5a4e517f23ede70a5258ca6a9d174db69be


Detailed log of new commits:

Author: apv
Date: Mon Mar 14 14:58:22 2016 +0300

    Reference data update for test case bugs/mnodalg_6 /bug25908

(0051597)
apv   
2016-03-14 15:01   
Dear Andrey,

Please validate reference data update for test case bugs/modalg_6/bug25908 in branch CR25813 from occt git-repository.
(0051665)
abv   
2016-03-15 17:31   
I have no objections
(0052888)
git   
2016-04-17 13:40   
Branch CR25813 has been deleted by kgv.

SHA-1: e5aaf5a4e517f23ede70a5258ca6a9d174db69be