MantisBT - Community
View Issue Details
0025692Community[OCCT] OCCT:Modeling Algorithmspublic2015-01-08 20:182015-05-14 15:32
Istvan Csanady 
bugmaster 
normalintegration request 
closedfixed 
 
[OCCT] 6.9.0[OCCT] 6.9.0 
Not needed
0025692: Boolean operations minor improvement
I was profiling boolean operations, and I have noticed, that a significant amount of time spent in IntPolyh_Point constructor. This is because IntPolyh_MaillageAffinage::TriContact creates lots of IntPolyh_Point objects. But these object creations can be moved after the 6 lines of 'if' instructions, reducing significantly the time spent in that constructor.
Maybe this is specific only for some shape types, but anyway, this is a reasonable change (and very easy, and also can not cause any bugs).
I have attached the patch file.
N/A
No tags attached.
diff patch.diff (1,834) 2015-01-08 20:18
https://tracker.dev.opencascade.org/
Issue History
2015-01-08 20:18Istvan CsanadyNew Issue
2015-01-08 20:18Istvan CsanadyAssigned To => msv
2015-01-08 20:18Istvan CsanadyFile Added: patch.diff
2015-01-18 23:21gitNote Added: 0036182
2015-01-18 23:25abvNote Added: 0036183
2015-01-18 23:25abvStatusnew => resolved
2015-01-18 23:25abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9084#r9084
2015-01-18 23:25abvNote Added: 0036184
2015-01-18 23:25abvAssigned Tomsv => bugmaster
2015-01-18 23:25abvStatusresolved => reviewed
2015-01-22 13:47apnTest case number => Not needed
2015-01-22 13:47apnAssigned Tobugmaster => apn
2015-01-22 13:49gitNote Added: 0036387
2015-01-23 19:33apnNote Added: 0036484
2015-01-23 19:34apnAssigned Toapn => bugmaster
2015-01-23 19:34apnStatusreviewed => tested
2015-01-30 14:00bugmasterChangeset attached => occt master dba608bb
2015-01-30 14:00bugmasterStatustested => verified
2015-01-30 14:00bugmasterResolutionopen => fixed
2015-03-18 13:35gitNote Added: 0038542
2015-05-14 15:29aivStatusverified => closed
2015-05-14 15:32aivFixed in Version => 6.9.0

Notes
(0036182)
git   
2015-01-18 23:21   
Branch CR25692 has been created by abv.

SHA-1: 8bb09f31097ed6ddf935d7bf5a5125af99168a4e


Detailed log of new commits:

(0036183)
abv   
2015-01-18 23:25   
The proposed change looks reasonable and safe, even if it does not show any change of performance of standard tests (at least, on Win 7 vc10 64-bit), now pushed to branch CR25692
(0036184)
abv   
2015-01-18 23:25   
No remarks, please test
(0036387)
git   
2015-01-22 13:49   
Branch CR25692 has been updated forcibly by apn.

SHA-1: 2b01025a675e45ddd41f6c02cebffa4e9d555df7
(0036484)
apn   
2015-01-23 19:33   
Dear BugMaster,
Branch CR25692 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested in Release mode.
SHA-1: 2b01025a675e45ddd41f6c02cebffa4e9d555df7

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
No regressions

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 370065012 / 369907280
Total CPU difference: 50068.01000000014 / 46828.580000000045

Testing on Windows:
Total MEMORY difference: 276556988 / 276837572
Total CPU difference: 35692.890625 / 39964.359375

There are not differences in images found by testdiff.
(0038542)
git   
2015-03-18 13:35   
Branch CR25692 has been deleted by inv.

SHA-1: 2b01025a675e45ddd41f6c02cebffa4e9d555df7