MantisBT - Community
View Issue Details
0025684Community[OCCT] OCCT:Codingpublic2015-01-06 06:162015-05-14 16:28
Vico Liang 
bugmaster 
normaltrivial 
closedfixed 
 
[OCCT] 6.9.0[OCCT] 6.9.0 
Not needed
0025684: Extend TCollection_ExtendedString with method IsEmpty()
TCollection_AsciiString has method IsEmpty but TCollection_ExtendedString without this method. IsEmpty seems more efficient then (Length()==0) method.
N/A
No tags attached.
Issue History
2015-01-06 06:16Vico LiangNew Issue
2015-01-06 06:16Vico LiangAssigned To => szy
2015-04-10 09:43kgvAssigned Toszy => kgv
2015-04-10 09:43kgvSeverityminor => trivial
2015-04-10 09:43kgvStatusnew => assigned
2015-04-10 09:43kgvCategoryOCCT:Application Framework => OCCT:Coding
2015-04-10 09:43kgvSummaryTCollection_ExtendedString missing method IsEmpty. => Extend TCollection_ExtendedString with method IsEmpty()
2015-04-10 09:48gitNote Added: 0039548
2015-04-10 09:49kgvNote Added: 0039549
2015-04-10 09:50kgvNote Added: 0039550
2015-04-10 09:50kgvAssigned Tokgv => bugmaster
2015-04-10 09:50kgvStatusassigned => resolved
2015-04-10 09:50kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9911#r9911
2015-04-10 09:51kgvNote Edited: 0039549bug_revision_view_page.php?bugnote_id=39549#r9913
2015-04-13 14:33abvStatusresolved => reviewed
2015-04-13 14:39mkvAssigned Tobugmaster => mkv
2015-04-13 15:00gitNote Added: 0039637
2015-04-14 18:45mkvNote Added: 0039714
2015-04-14 18:45mkvNote Added: 0039715
2015-04-14 18:45mkvAssigned Tomkv => bugmaster
2015-04-14 18:45mkvStatusreviewed => tested
2015-04-14 18:45mkvTest case number => Not needed
2015-04-17 15:40bugmasterChangeset attached => occt master a21ab2c1
2015-04-17 15:40bugmasterStatustested => verified
2015-04-17 15:40bugmasterResolutionopen => fixed
2015-05-14 15:28aivStatusverified => closed
2015-05-14 15:31aivFixed in Version => 6.9.0
2015-05-14 16:28gitNote Added: 0040984

Notes
(0039548)
git   
2015-04-10 09:48   
Branch CR25684 has been created by kgv.

SHA-1: 5e93c57bbc01ac9b0301139c6c3547d8b92d055c


Detailed log of new commits:

Author: kgv
Date: Fri Apr 10 09:48:30 2015 +0300

    0025684: Extend TCollection_ExtendedString with method IsEmpty()
(0039549)
kgv   
2015-04-10 09:49   
(edited on: 2015-04-10 09:51)
>> IsEmpty seems more efficient then (Length()==0) method.
Since Length() uses cached value, there is no difference between these two methods, besides the style.

(0039550)
kgv   
2015-04-10 09:50   
Please check patch compilation, regression testing is not needed.
(0039637)
git   
2015-04-13 15:00   
Branch CR25684 has been updated forcibly by mkv.

SHA-1: 468293f6b3ca357511e71ccbdd15f31ced7d9136
(0039714)
mkv   
2015-04-14 18:45   
Dear BugMaster,
Branch CR25684 was rebased on current master of occt git-repository.
(0039715)
mkv   
2015-04-14 18:45   
Dear BugMaster,
Branch CR25684 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: 468293f6b3ca357511e71ccbdd15f31ced7d9136

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 4 (4 on master)
Windows: 0 (0 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 94002807 / 94264006 [-0.28%]
Total CPU difference: 55672.3199999998 / 56192.569999999694 [-0.93%]
products component :
Total MEMORY difference: 23662640 / 23711227 [-0.20%]
Total CPU difference: 17944.63999999998 / 19064.96999999996 [-5.88%]

Testing on Windows:
occt component :
Total MEMORY difference: 57126745 / 57127513 [-0.00%]
Total CPU difference: 16043.922844999286 / 15976.561613198899 [+0.42%]
products component :
Total MEMORY difference: 15476993 / 15478724 [-0.01%]
Total CPU difference: 6337.899427299983 / 6217.388654799964 [+1.94%]

There are no differences in images found by testdiff.
(0040984)
git   
2015-05-14 16:28   
Branch CR25684 has been deleted by inv.

SHA-1: 468293f6b3ca357511e71ccbdd15f31ced7d9136