MantisBT - Open CASCADE
View Issue Details
0025623Open CASCADE[OCCT] OCCT:Shape Healingpublic2014-12-17 10:152016-12-09 16:37
aml 
bugmaster 
normalminor 
closedfixed 
[OCCT] 6.9.0 
[OCCT] 7.1.0[OCCT] 7.1.0 
Not needed
0025623: Some tests become worse after 22598 fix
de iges_2 A9
After fix wires not splitted into several wires, master behaviour seems to be correct.

de iges_2 C6
After fix wrong shape obtained, duplicate of surface is stored in shape res_1. Pcurves after CR22598 fix seems to be correct like in master.

de step_3 E6
New multiple problems detected via reference data.
test de iges_2 A9
No tags attached.
png Input.png (25,574) 2016-05-20 07:53
https://tracker.dev.opencascade.org/
png Result_Before_22598.png (31,648) 2016-05-20 07:54
https://tracker.dev.opencascade.org/
png Result_After_22598.png (24,542) 2016-05-20 07:54
https://tracker.dev.opencascade.org/
Issue History
2014-12-17 10:15amlNew Issue
2014-12-17 10:15amlAssigned To => aml
2016-05-20 07:53amlFile Added: Input.png
2016-05-20 07:54amlFile Added: Result_Before_22598.png
2016-05-20 07:54amlFile Added: Result_After_22598.png
2016-05-20 07:54amlNote Added: 0054147
2016-05-20 07:55gitNote Added: 0054148
2016-05-20 07:55amlAssigned Toaml => msv
2016-05-20 07:55amlStatusnew => resolved
2016-05-20 07:55amlSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13714#r13714
2016-05-20 07:56amlNote Edited: 0054147bug_revision_view_page.php?bugnote_id=54147#r13716
2016-05-20 10:30msvNote Added: 0054153
2016-05-20 10:30msvAssigned Tomsv => bugmaster
2016-05-20 10:30msvStatusresolved => reviewed
2016-05-20 11:27apvAssigned Tobugmaster => apv
2016-05-20 12:29gitNote Added: 0054246
2016-05-20 12:29apvNote Added: 0054247
2016-05-23 14:37apvTest case number => Not needed
2016-05-23 14:40apvNote Added: 0054284
2016-05-23 14:40apvAssigned Toapv => aml
2016-05-23 14:40apvStatusreviewed => assigned
2016-05-23 14:42apvNote Added: 0054285
2016-05-23 15:05amlNote Added: 0054293
2016-05-23 15:05amlAssigned Toaml => apv
2016-05-23 15:05amlStatusassigned => feedback
2016-05-23 15:34gitNote Added: 0054295
2016-05-23 15:35apvAssigned Toapv => abv
2016-05-23 15:35apvNote Added: 0054296
2016-05-24 08:48abvNote Added: 0054320
2016-05-24 08:48abvAssigned Toabv => apv
2016-05-24 10:43apvNote Added: 0054324
2016-05-24 10:43apvAssigned Toapv => bugmaster
2016-05-24 10:43apvStatusfeedback => tested
2016-05-27 13:02bugmasterChangeset attached => occt master 6b52f125
2016-05-27 13:02bugmasterStatustested => verified
2016-05-27 13:02bugmasterResolutionopen => fixed
2016-05-27 13:09gitNote Added: 0054467
2016-05-30 11:50bugmasterTarget Version => 7.1.0
2016-12-09 16:31aivStatusverified => closed
2016-12-09 16:37aivFixed in Version => 7.1.0

Notes
(0054147)
aml   
2016-05-20 07:54   
(edited on: 2016-05-20 07:56)
Dear msv,
Please check current state of the CR25623 branch.

de iges_2 C6
Fixed by azv fix 0026252

de step_3 E6
Fixed by couple of fixes: 0025553, 0026930, 0024682.

de iges_2 A9
After 22598 new "checkshape" problems are reported.
Image Input.png - contains input face before the shape healing
Image Result_Before_22598.png - contains result: three faces after shape healing (no checkshape).
Image Result_After_22598.png - contains result: one face after shape healing (2 checkshape problems).

Result before 22598 fix hides the problem of non-manifold input geometry. So, checkshape reporting is correct. Face splitting problem is related to incorrect tolerance usage and fixed in scope of the CR25623 branch.

(0054148)
git   
2016-05-20 07:55   
Branch CR25623 has been created by aml.

SHA-1: e0708bf9dd37e30a60ab7a664ad30a41164c6ca0


Detailed log of new commits:

Author: aml
Date: Thu May 19 12:54:18 2016 +0300

    0025623: Some tests become worse after 22598 fix
    
    Tolerance of line / line analytical intersection is fixed.
    Test cases are updated to the new behavior.
(0054153)
msv   
2016-05-20 10:30   
Reviewed.
(0054246)
git   
2016-05-20 12:29   
Branch CR25623 has been updated forcibly by apv.

SHA-1: fcea96286fa329095484d3d6afca995e9fdc88ae
(0054247)
apv   
2016-05-20 12:29   
Branch CR25623 has been rebased on the current master
(0054284)
apv   
2016-05-23 14:40   
Dear BugMaster,

Branch CR25623 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: fcea96286fa329095484d3d6afca995e9fdc88ae

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MacOS: 0 (0 on master)
products component:
   Linux: 72
   Windows: 4
   MacOS: 1138

Regressions/Differences:
http://occt-tests/CR25623-master-OCCT/Debian70-64/summary.html [^]
http://occt-tests/CR25623-master-OCCT/Windows-64-VC10/summary.html [^]
de iges_2 A9

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 89059816 / 88950050 [+0.12%]
Total CPU difference: 19244.999999999996 / 19256.219999999936 [-0.06%]

Testing on Windows:
Total MEMORY difference: 55686340 / 55732339 [-0.08%]
Total CPU difference: 18693.053826498763 / 18201.85347779892 [+2.70%]
(0054285)
apv   
2016-05-23 14:42   
Dear aml,

Branch CR25623 has been rejected due to:
- regressions/differences/improvements
(0054293)
aml   
2016-05-23 15:05   
Dear apv,
difference in test case "de iges_2 A9" is acceptable.
Could you please add corresponding "todo" statement?
(0054295)
git   
2016-05-23 15:34   
Branch CR25623 has been updated by apv.

SHA-1: 60bd486eb92e55863398dea8119b8b422f3d2fbf


Detailed log of new commits:

Author: apv
Date: Mon May 23 15:34:20 2016 +0300

    Update of test case according to the current behavior

(0054296)
apv   
2016-05-23 15:35   
Dear Andrey,

Please validate correction of test cases in branch CR25623
(0054320)
abv   
2016-05-24 08:48   
I see no problem, please proceed
(0054324)
apv   
2016-05-24 10:43   
Branch CR25623 is tested
(0054467)
git   
2016-05-27 13:09   
Branch CR25623 has been deleted by inv.

SHA-1: 60bd486eb92e55863398dea8119b8b422f3d2fbf