MantisBT - Community
View Issue Details
0025439Community[OCCT] OCCT:Modeling Datapublic2014-10-31 16:372014-11-12 09:55
Roman Lygin 
bugmaster 
normalintegration request 
closedfixed 
[OCCT] 6.8.0 
[OCCT] 6.8.0[OCCT] 6.8.0 
Not needed
0025439: Enabling shape binary persistence without OCAF
The fix moves BinTools to TKBRep from TKBin.

In itself, BinTools provides binary persistence of topology and geometry, and is similar to BRepTools which provides textual persistence.
Although currently it is only used in OCAF binary persistence, binary shape persistence can be useful for OCAF-less user applications.

The increased file size of TKBRep should be negligible, approximately ~100KB in release mode.

From architectural standpoint BRepTools and BinTools would deserve a refactoring and having a common writer and two different formatters (text and binary), thus following the Builder pattern. Same for reader & parsers. This could reduce code duplication and size. But this is beyond this simple integration request just to put BinTools to TKBRep.
As no documentation or DRAW commands have been explicitly used for binary persistence of shapes, they are not affected within the scope of this change request. This can be done later if needed.
No tags attached.
Issue History
2014-10-31 16:37Roman LyginNew Issue
2014-10-31 16:37Roman LyginAssigned To => abv
2014-10-31 16:42gitNote Added: 0033963
2014-10-31 16:42Roman LyginNote Added: 0033964
2014-10-31 16:42Roman LyginStatusnew => resolved
2014-10-31 16:45abvNote Added: 0033965
2014-10-31 16:45abvAssigned Toabv => bugmaster
2014-10-31 16:45abvStatusresolved => reviewed
2014-10-31 16:56mkvAssigned Tobugmaster => apv
2014-10-31 17:17apvTest case number => Not needed
2014-10-31 19:35gitNote Added: 0033991
2014-11-05 12:17apvNote Added: 0034026
2014-11-05 12:17apvAssigned Toapv => bugmaster
2014-11-05 12:17apvStatusreviewed => tested
2014-11-06 16:15bugmasterChangeset attached => occt master 2dc8b7cc
2014-11-06 16:15bugmasterStatustested => verified
2014-11-06 16:15bugmasterResolutionopen => fixed
2014-11-11 12:42aivFixed in Version => 6.8.0
2014-11-11 13:03aivStatusverified => closed
2014-11-12 09:55gitNote Added: 0034348

Notes
(0033963)
git   
2014-10-31 16:42   
Branch CR25439 has been created by Roman Lygin.

SHA-1: 5548f683c65a19c27fd9f05d0d17a8fd23e869d9


Detailed log of new commits:

Author: Roman Lygin
Date: Fri Oct 31 16:40:03 2014 +0400

    0025439: Enabling shape binary persistence without OCAF
(0033964)
Roman Lygin   
2014-10-31 16:42   
The fix has been pushed to the git repository.
(0033965)
abv   
2014-10-31 16:45   
No remarks, please check build and integrate
(0033991)
git   
2014-10-31 19:35   
Branch CR25439 has been updated forcibly by apv.

SHA-1: 76fc993be6922cdffc546ac274f4e47ba3501fd1
(0034026)
apv   
2014-11-05 12:17   
Dear BugMaster,

Branch CR25439 (and products from GIT master) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 76fc993be6922cdffc546ac274f4e47ba3501fd1

Number of compiler warnings:
occt component:
   Linux: 18 (18 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 11 (11 on master)
   Windows: 1 (1 on master)
(0034348)
git   
2014-11-12 09:55   
Branch CR25439 has been deleted by inv.

SHA-1: 76fc993be6922cdffc546ac274f4e47ba3501fd1