MantisBT - Community
View Issue Details
0025166Community[OCCT] OCCT:Data Exchangepublic2014-08-19 14:372014-11-11 12:58
drazmyslovich 
bugmaster 
normalfeature 
closedfixed 
WindowsVC++ 201064 bit
[OCCT] 6.6.0 
[OCCT] 6.8.0[OCCT] 6.8.0 
bugs step(014) bug25166
0025166: STEP Reader - allow GEOMETRIC_SET entity to accept non-geometric children
HOOPS Exchange Viewer can generate STEP files with the geometric sets, which contain non-geometric objects, but SHELL_BASED_SURFACE_MODEL objects. The current STEP import object doesn't allow such geometric sets, ignores all children and results with empty set.
The proposed change: allow GeometricRepresentationItem-s to be added to GeometricSet
Import the attached piston.stp
No tags attached.
parent of 0025176closed bugmaster Open CASCADE STEP Reader - no error report if referenced entity has wrong type 
? piston.stp (2,073,858) 2014-08-19 15:12
https://tracker.dev.opencascade.org/
Issue History
2014-08-19 14:37drazmyslovichNew Issue
2014-08-19 14:37drazmyslovichAssigned To => gka
2014-08-19 14:39gitNote Added: 0030879
2014-08-19 14:40drazmyslovichNote Added: 0030880
2014-08-19 14:40drazmyslovichStatusnew => resolved
2014-08-19 15:02kgvNote Added: 0030881
2014-08-19 15:03kgvSummarySTEP: Allow GEOMETRIC_SET entity to accept non-geometric children => STEP Reader - allow GEOMETRIC_SET entity to accept non-geometric children
2014-08-19 15:05kgvNote Added: 0030882
2014-08-19 15:12drazmyslovichFile Added: piston.stp
2014-08-19 15:14drazmyslovichNote Added: 0030883
2014-08-20 16:39gitNote Added: 0030942
2014-08-20 16:40gkaNote Added: 0030943
2014-08-20 16:40gkaStatusresolved => reviewed
2014-08-20 17:19mkvAssigned Togka => mkv
2014-08-20 18:21abvRelationship addedparent of 0025176
2014-08-21 11:49mkvNote Added: 0030981
2014-08-21 11:49gitNote Added: 0030982
2014-08-21 11:50mkvTest case number => bugs step(014) bug25166
2014-08-21 11:50mkvAssigned Tomkv => bugmaster
2014-08-21 11:50mkvStatusreviewed => tested
2014-08-22 15:42bugmasterChangeset attached => occt master 38deba5d
2014-08-22 15:42bugmasterStatustested => verified
2014-08-22 15:42bugmasterResolutionopen => fixed
2014-09-08 15:51gitNote Added: 0031476
2014-11-11 12:45aivFixed in Version => 6.8.0
2014-11-11 12:58aivStatusverified => closed

Notes
(0030879)
git   
2014-08-19 14:39   
Branch CR25166 has been created by drazmyslovich.

SHA-1: 13eaefe475a624782113bc9a58720cd3fd26e427


This branch includes the following new commits:

       new 13eaefe 0025166: Allow GEOMETRIC_SET entity to accept GeometricRepresentationItem children


Detailed log of new commits:

commit 13eaefe475a624782113bc9a58720cd3fd26e427
Author: razmyslovich
Date: Tue Aug 19 12:38:51 2014 +0200

    0025166: Allow GEOMETRIC_SET entity to accept GeometricRepresentationItem children
(0030880)
drazmyslovich   
2014-08-19 14:40   
The feature is committed. Please, review it
(0030881)
kgv   
2014-08-19 15:02   
--- a/src/StepToTopoDS/StepToTopoDS_Builder.cdl
+++ b/src/StepToTopoDS/StepToTopoDS_Builder.cdl
@@ -34,10 +34,11 @@ uses
-    NMTool                      from StepToTopoDS
+    NMTool                      from StepToTopoDS,
+    ActorRead                   from STEPControl

it looks like packages StepToTopoDS and STEPControl will have cyclic dependency, which is not good (and normally forbidden in CDL).
(0030882)
kgv   
2014-08-19 15:05   
Dear Dima,
>> Import the attached piston.stp
the attachment seems to be forgotten.
(0030883)
drazmyslovich   
2014-08-19 15:14   
Hi, kgv,
sorry, the file is now attached.
Regarding the cyclic dependencies - please, review, maybe you'll find the better way to resolve the dependencies; for me it was just the clearest possibility.
(0030942)
git   
2014-08-20 16:39   
Branch CR25166 has been updated by gka.

SHA-1: 8aaca23d7a644133f8ce7d1ac7fe21c5b525add2


      from 13eaefe 0025166: Allow GEOMETRIC_SET entity to accept GeometricRepresentationItem children
       new 8aaca23 Modification to avoid cyclic dependency between STEPControl and StepToTopoDS packages


Detailed log of new commits:

commit 8aaca23d7a644133f8ce7d1ac7fe21c5b525add2
Author: gka
Date: Wed Aug 20 16:38:55 2014 +0400

    Modification to avoid cyclic dependency between STEPControl and StepToTopoDS packages

(0030943)
gka   
2014-08-20 16:40   
Branch CR25166 is ready to be tested
(0030981)
mkv   
2014-08-21 11:49   
Dear BugMaster,

Branch CR25166 from occt git-repository (and master from products git-repository) was compiled on Linux and Windows platforms and tested.
SHA-1: 8aaca23d7a644133f8ce7d1ac7fe21c5b525add2

Number of compiler warnings:

occt component :
Linux: 15 (15 on master)
Windows: 0 (0 on master)

products component :
Linux: 11 (11 on master)
Windows: 1 (1 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
http://occt-tests/CR25166-master-occt/Debian60-64/bugs/step/bug25166.html [^]
http://occt-tests/CR25166-master-occt/Windows-32-VC10/bugs/step/bug25166.html [^]
bugs step(014) bug25166: OK

Testing on Linux:
occt component :
Total MEMORY difference: 352213364 / 351903736
Total CPU difference: 44213.05000000006 / 45953.98000000014
products component :
Total MEMORY difference: 109545196 / 109556352
Total CPU difference: 18585.019999999968 / 18691.699999999983

Testing on Windows:
occt component :
Total MEMORY difference: 239813796 / 239728968
Total CPU difference: 35134.84375 / 32650.4375
products component :
Total MEMORY difference: 66305908 / 65539272
Total CPU difference: 12263.3125 / 13013.484375

There are no differences in images found by testdiff.
(0030982)
git   
2014-08-21 11:49   
Branch CR25166 has been updated by mkv.

SHA-1: a1e838649fa2d22fdd8029605167255e808c25d9


Detailed log of new commits:

Author: mkv
Date: Thu Aug 21 11:49:01 2014 +0400

    Test cases for issue CR25166

(0031476)
git   
2014-09-08 15:51   
Branch CR25166 has been deleted by inv.

SHA-1: a1e838649fa2d22fdd8029605167255e808c25d9