MantisBT - Community
View Issue Details
0025012Community[OCCT] OCCT:Shape Healingpublic2014-06-16 18:252014-11-11 12:52
drazmyslovich 
apn 
normalmajor 
closedfixed 
WindowsVC++ 201064 bit
[OCCT] 6.6.0 
[OCCT] 6.8.0[OCCT] 6.8.0 
bugs vis(004) bug24714
0025012: ShapeFix_Wire checks the wrong parameter for the curve during SameParameter check
ShapeFix_Wire line 731:
          if( fabs(First-fp2d)>Precision::PConfusion() ||
              fabs(Last-fp2d)>Precision::PConfusion() ) {
Last should be compared with lp2d, but not fp2d
No tags attached.
Issue History
2014-06-16 18:25drazmyslovichNew Issue
2014-06-16 18:25drazmyslovichAssigned To => drazmyslovich
2014-06-16 18:28drazmyslovichNote Added: 0029785
2014-06-16 18:28drazmyslovichStatusnew => resolved
2014-06-16 18:32abvNote Added: 0029786
2014-06-16 18:32abvAssigned Todrazmyslovich => bugmaster
2014-06-16 18:32abvStatusresolved => reviewed
2014-06-16 19:54mkvAssigned Tobugmaster => mkv
2014-06-18 11:01mkvNote Added: 0029807
2014-06-18 11:02mkvTest case number => bugs vis(004) bug24714
2014-06-18 11:02mkvAssigned Tomkv => bugmaster
2014-06-18 11:02mkvStatusreviewed => tested
2014-06-19 12:57apnTarget VersionUnscheduled => 6.8.0
2014-06-20 12:54apnChangeset attached => occt master 44a87d69
2014-06-20 12:54apnAssigned Tobugmaster => apn
2014-06-20 12:54apnStatustested => verified
2014-06-20 12:54apnResolutionopen => fixed
2014-11-11 12:46aivFixed in Version => 6.8.0
2014-11-11 12:52aivStatusverified => closed

Notes
(0029785)
drazmyslovich   
2014-06-16 18:28   
The fix is committed. Please, review it.
(0029786)
abv   
2014-06-16 18:32   
No remarks, please test
(0029807)
mkv   
2014-06-18 11:01   
Dear BugMaster,

Branch CR25012 (and products from GIT master) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 75a779424bc982d003f27d8562ba52f545d3b2c9

Number of compiler warnings:

occt component :
Linux: 16 (16 on master)
Windows: 0 (0 on master)
MacOS: 200 (203 on master)

products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 348832316 / 349066800
Total CPU difference: 51932.859999999964 / 52851.98000000001

Testing on Windows:
Total MEMORY difference: 367692880 / 368324888
Total CPU difference: 37640.359375 / 42223.875

There are no differences in images found by testdiff.