MantisBT - Community
View Issue Details
0024994Community[OCCT] OCCT:Modeling Algorithmspublic2014-06-07 14:532015-10-23 20:51
guidovanhilst 
bugmaster 
normalminor 
closedfixed 
Windows7Windows7Windows7
[OCCT] 6.7.1 
[OCCT] 6.9.1[OCCT] 6.9.1 
Not needed
0024994: Missing implementation of constructor: BRepClass_FaceClassifier
BRepClass_FaceClassifier::BRepClass_FaceClassifier(
BRepClass_FaceExplorer& F,
const gp_Pnt& P,
const Standard_Real Tol)
not needed
No tags attached.
Issue History
2014-06-07 14:53guidovanhilstNew Issue
2014-06-07 14:53guidovanhilstAssigned To => ifv
2014-09-12 12:53abvTarget Version => 7.1.0
2015-04-24 20:47msvNote Added: 0040244
2015-05-25 12:01msvAssigned Toifv => isn
2015-05-25 12:02msvStatusnew => assigned
2015-05-25 12:24gitNote Added: 0041482
2015-05-25 12:26isnNote Added: 0041483
2015-05-25 12:26isnAssigned Toisn => msv
2015-05-25 12:26isnStatusassigned => resolved
2015-05-25 12:26isnSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10551#r10551
2015-05-25 12:31abvSummarymissing implematation of constructor: BRepClass_FaceClassifier => Missing implementation of constructor: BRepClass_FaceClassifier
2015-05-25 12:32msvNote Added: 0041484
2015-05-25 12:32msvAssigned Tomsv => bugmaster
2015-05-25 12:32msvStatusresolved => reviewed
2015-05-25 12:58apvAssigned Tobugmaster => apv
2015-05-26 12:12apvTest case number => Not needed
2015-05-26 12:19apvNote Added: 0041547
2015-05-26 12:19apvAssigned Toapv => bugmaster
2015-05-26 12:19apvStatusreviewed => tested
2015-05-29 14:15bugmasterChangeset attached => occt master b21ccecc
2015-05-29 14:15bugmasterStatustested => verified
2015-05-29 14:15bugmasterResolutionopen => fixed
2015-05-29 14:19bugmasterTarget Version7.1.0 => 7.0.0
2015-08-14 11:00gitNote Added: 0044264
2015-08-26 11:14abvTarget Version7.0.0 => 6.9.1
2015-10-16 14:56aivStatusverified => closed
2015-10-23 20:51aivFixed in Version => 6.9.1

Notes
(0040244)
msv   
2015-04-24 20:47   
This constructor is redundant for this class. Because it gets a 3D point. A 3D point cannot be classified in parametric 2D space of a face. It must be first projected on surface to obtain a 2D point, and then one can use the available constructor.
So, the solution is to remove the wrong declaration.
(0041482)
git   
2015-05-25 12:24   
Branch CR24994 has been created by isn.

SHA-1: 9eea4bc4c318b7f4164cc9b6be05c9998d3f132c


Detailed log of new commits:

Author: isn
Date: Mon May 25 12:24:32 2015 +0300

    0024994: missing implematation of constructor: BRepClass_FaceClassifier
(0041483)
isn   
2015-05-25 12:26   
please review branch CR24994
(0041484)
msv   
2015-05-25 12:32   
Reviewed.
No testing is needed. Just check compilation.
(0041547)
apv   
2015-05-26 12:19   
Dear BugMaster,

Branch CR24994 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 9eea4bc4c318b7f4164cc9b6be05c9998d3f132c

Number of compiler warnings:
occt component:
   Linux: 25 (25 on master)
   Windows: 0 (0 on master)
products component:
   Linux: 37 (37 on master)
   Windows: 0 (0 on master)

Regressions/Differences:
Not detected

Testing on Linux:
Total MEMORY difference: 99881310 / 99716854 [+0.16%]
Total CPU difference: 18963.019999999953 / 18298.35000000015 [+3.63%]

Testing on Windows:
Total MEMORY difference: 58997408 / 58780037 [+0.37%]
Total CPU difference: 17168.61205449915 / 16832.58590049903 [+2.00%]
(0044264)
git   
2015-08-14 11:00   
Branch CR24994 has been deleted by inv.

SHA-1: 9eea4bc4c318b7f4164cc9b6be05c9998d3f132c