MantisBT - Community
View Issue Details
0024941Community[OCCT] OCCT:Codingpublic2014-05-21 09:122014-11-11 12:52
laurie123 
apn 
normaltrivial 
closedfixed 
MacOSX
[OCCT] 6.7.1 
[OCCT] 6.8.0[OCCT] 6.8.0 
Not needed
0024941: Need whitespace between adjacent string literals for CLang in c++11 mode
The files Interface_Version.hxx and STEPControl_Controller.cxx use the macro OCC_VERSION_STRING butting up against a string literal. CLang in c++11 mode vehemently rejects this.
compile with Xcode 5.1.1 setting c++11 mode true. (on cmd line, clang -std=c++11 -stdlib=libc++)
This (trivial) problem has been present since at least OCC6.5.4, and is the only change I *must* make to the source tree to get it to compile in c++11 mode. I am not using -Werror -Wall -Weverything, though.
No tags attached.
Issue History
2014-05-21 09:12laurie123New Issue
2014-05-21 09:12laurie123Assigned To => kgv
2014-05-21 09:44abvNote Added: 0029423
2014-05-21 09:44abvAssigned Tokgv => laurie123
2014-05-21 09:44abvStatusnew => resolved
2014-05-21 17:06kgvNote Added: 0029447
2014-05-21 17:06kgvAssigned Tolaurie123 => bugmaster
2014-05-21 17:06kgvStatusresolved => reviewed
2014-05-21 17:07kgvTarget Version => 6.8.0
2014-05-21 17:17abvNote Added: 0029448
2014-05-22 11:01bugmasterAssigned Tobugmaster => apn
2014-05-23 10:12laurie123Note Added: 0029481
2014-05-23 10:56abvNote Added: 0029482
2014-05-23 10:56abvSummaryNeed whitespace between predecessor tokens for CLang in c++11 mode => Need whitespace between adjacent string literals for CLang in c++11 mode
2014-05-23 10:59laurie123Note Added: 0029483
2014-05-23 14:24apnNote Added: 0029494
2014-05-26 17:58apnTest case number => Not needed
2014-05-26 17:58apnAssigned Toapn => bugmaster
2014-05-26 17:58apnStatusreviewed => tested
2014-05-30 12:59apnChangeset attached => occt master cae42e78
2014-05-30 12:59apnAssigned Tobugmaster => apn
2014-05-30 12:59apnStatustested => verified
2014-05-30 12:59apnResolutionopen => fixed
2014-11-11 12:46aivFixed in Version => 6.8.0
2014-11-11 12:52aivStatusverified => closed

Notes
(0029423)
abv   
2014-05-21 09:44   
Fix pushed to branch CR24941, please review
(0029447)
kgv   
2014-05-21 17:06   
Please test the patch.
(0029448)
abv   
2014-05-21 17:17   
Note that similar fix is pushed to products repository, in the same-name branch CR24941
(0029481)
laurie123   
2014-05-23 10:12   
(pls can you fix the typo in the summary: predecessor→preprocessor; I don't see a way to do it myself)
(0029482)
abv   
2014-05-23 10:56   
I have changed description to refer to "adjacent string literals"; their concatenation seems to be done by C++ compiler itself, not by preprocessor
(0029483)
laurie123   
2014-05-23 10:59   
thanks and yes you are right on that :)
(0029494)
apn   
2014-05-23 14:24   
Branch will be tested with CR24897.