MantisBT - Community
View Issue Details
0024893Community[OCCT] OCCT:Codingpublic2014-05-03 01:562014-11-11 12:52
Epy 
bugmaster 
normalminor 
closedfixed 
Ubuntu 14.04 32 bitUbuntu14.04
[OCCT] 6.7.0 
[OCCT] 6.8.0[OCCT] 6.8.0 
Not needed
0024893: CLang warnings -Wlogical-not-parentheses for gce_Done comparisons
0024818 seems to have covered a lot of these already but all the comparisons using the enum gce_Done were not mentioned. gce_Done is an enumerated type so !TheError == gce_Done really makes no sense, I'm guessing the original intention was !(TheError == gce_Done) since ! is evaluated before ==.
No tags attached.
txt clang-errors.txt (42,642) 2014-05-03 01:56
https://tracker.dev.opencascade.org/
Issue History
2014-05-03 01:56EpyNew Issue
2014-05-03 01:56EpyAssigned To => kgv
2014-05-03 01:56EpyFile Added: clang-errors.txt
2014-05-03 09:09abvNote Added: 0029182
2014-05-03 09:09abvStatusnew => resolved
2014-05-03 09:09abvTarget Version => 6.8.0
2014-05-03 10:12kgvNote Added: 0029183
2014-05-03 10:12kgvAssigned Tokgv => bugmaster
2014-05-03 10:12kgvStatusresolved => reviewed
2014-05-05 10:42mkvAssigned Tobugmaster => mkv
2014-05-07 18:47mkvNote Added: 0029238
2014-05-07 18:47mkvTest case number => Not needed
2014-05-07 18:47mkvAssigned Tomkv => bugmaster
2014-05-07 18:47mkvStatusreviewed => tested
2014-05-12 16:20bugmasterChangeset attached => occt master 82fc327c
2014-05-12 16:20bugmasterStatustested => verified
2014-05-12 16:20bugmasterResolutionopen => fixed
2014-11-11 12:47aivFixed in Version => 6.8.0
2014-11-11 12:52aivStatusverified => closed

Notes
(0029182)
abv   
2014-05-03 09:09   
Fix pushed to branch CR24893, please review.

(The problem has not been reported within 0024818 because it shows up only in Debug builds)
(0029183)
kgv   
2014-05-03 10:12   
Please test the patch.
(0029238)
mkv   
2014-05-07 18:47   
Dear BugMaster,

Branch CR24893 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 8198b42c2609d6edd6afb57a3fbd9342c4153691

Number of compiler warnings:

occt component :
Linux: 18 (18 on master)
Windows: 0 (0 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 356949536 / 355561056
Total CPU difference: 50883.94000000006 / 53337.799999999814

Testing on Windows:
Total MEMORY difference: 379793796 / 379843896
Total CPU difference: 37685.328125 / 36615.28125

There are no differences in images found by testdiff.