MantisBT - Open CASCADE
View Issue Details
0024830Open CASCADE[OCCT] OCCT:Codingpublic2014-04-14 20:262014-11-11 12:52
abv 
apn 
normalintegration request 
closedfixed 
 
[OCCT] 6.8.0[OCCT] 6.8.0 
Not needed
0024830: Remove redundant keyword 'mutable' in CDL declarations
In CDL, keyword 'mutable' is required in declaration of first parameter ("me") of class methods to declare the method as non-const in C++.

However, in existing CDL files it also appears in two other locations:

- in return statements, as "returns mutable ..."
- in declarations of arguments of functions, like "Method (me; var: mutable Integer);"

These two uses have no added value but cause error in CDL extraction if corresponding type (returned or argument) is converted to non-CDL class.

Thus these declarations should be removed to allow further progress in getting rid of CDL, in particular, 0024750.
No tags attached.
child of 0024750closed abv Replace instantiations of TCollection generic classes by NCollection templates 
Issue History
2014-04-14 20:26abvNew Issue
2014-04-14 20:26abvAssigned To => kgv
2014-04-14 20:26abvRelationship addedchild of 0024750
2014-04-15 08:50abvNote Added: 0028833
2014-04-15 08:50abvStatusnew => resolved
2014-04-15 08:59kgvNote Added: 0028834
2014-04-15 08:59kgvAssigned Tokgv => bugmaster
2014-04-15 08:59kgvSeverityminor => integration request
2014-04-15 08:59kgvStatusresolved => reviewed
2014-04-15 08:59kgvTarget Version => 6.8.0
2014-04-15 15:00mkvAssigned Tobugmaster => mkv
2014-04-18 18:45mkvNote Added: 0028979
2014-04-18 18:46mkvTest case number => Not needed
2014-04-18 18:46mkvAssigned Tomkv => abv
2014-04-18 18:46mkvStatusreviewed => feedback
2014-04-18 18:53abvNote Added: 0028980
2014-04-18 18:53abvStatusfeedback => reviewed
2014-04-21 19:56mkvAssigned Toabv => mkv
2014-05-07 14:43mkvNote Added: 0029228
2014-05-07 14:44mkvAssigned Tomkv => abv
2014-05-07 14:44mkvStatusreviewed => assigned
2014-05-22 09:54abvNote Added: 0029457
2014-05-22 09:54abvAssigned Toabv => bugmaster
2014-05-22 09:54abvStatusassigned => resolved
2014-05-22 09:54abvStatusresolved => reviewed
2014-05-22 10:56bugmasterAssigned Tobugmaster => apn
2014-05-23 13:28apnNote Added: 0029491
2014-05-23 13:28apnAssigned Toapn => bugmaster
2014-05-23 13:28apnStatusreviewed => tested
2014-05-30 12:59apnChangeset attached => occt master 6e33d3ce
2014-05-30 12:59apnAssigned Tobugmaster => apn
2014-05-30 12:59apnStatustested => verified
2014-05-30 12:59apnResolutionopen => fixed
2014-11-11 12:46aivFixed in Version => 6.8.0
2014-11-11 12:52aivStatusverified => closed

Notes
(0028833)
abv   
2014-04-15 08:50   
Fix pushed to CR24830, please review
(0028834)
kgv   
2014-04-15 08:59   
Please test the patch.
(0028979)
mkv   
2014-04-18 18:45   
Dear abv,
could you please rebase CR24830 on current master, there are conflict files.
(0028980)
abv   
2014-04-18 18:53   
Branch CR24830 rebased on current master
(0029228)
mkv   
2014-05-07 14:43   
Dear BugMaster,

Branch CR24830 (and products from GIT master) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: c3096ba81f19b62a04682e81645091c6dfde3d45

There is extraction error in products part (on master):
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24830/job/mnt-CR24830-master_prepare_occt_products_linux/2/consoleFull [^]
Error : the deferred method TDF_Attribute::Paste(TDF_Attribute,TDF_RelocationTable) must
Error : have an implementation in class OMFCAF_TMesh
Error : Check of OMFCAF has failed
Error : Failed during execution
(0029457)
abv   
2014-05-22 09:54   
Fix for products pushed to CR24830. Fix for OCCT is rebased on current master and pushed to CR24830_1. Please test
(0029491)
apn   
2014-05-23 13:28   
Dear BugMaster,

Branch CR24830_1 (and products from CR24830) was compiled on Linux, Windows and MacOS platforms and tested.
SHA-1: c53249522bdf0bf6355b08dc0837495b694f64c7

Number of compiler warnings:

occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 202 (205 on master)

products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 356917396 / 357326856
Total CPU difference: 63897.32000000005 / 56363.43999999993

Testing on Windows:
Total MEMORY difference: 379293004 / 379627876
Total CPU difference: 41377.0 / 35503.40625

There are no differences in images found by testdiff.