MantisBT - Open CASCADE
View Issue Details
0024752Open CASCADE[OCCT] OCCT:Visualizationpublic2014-03-22 17:202017-08-16 14:15
kgv 
bugmaster 
normalintegration request 
closedfixed 
[OCCT] 6.7.0 
[OCCT] 6.8.0[OCCT] 6.8.0 
Not needed
0024752: Visualization - inherit OpenGl_Group from Graphic3d_Group
OpenGl_Group is logically specialization of Graphic3d_Group, but stored as pointer in it by current design.
Graphic3d_Group is now abstract class and should be instantiated using Graphic3d_Structure::NewGroup() method.
No tags attached.
related to 0024704closed bugmaster Open CASCADE Visualization - inherit OpenGl_Structure from Graphic3d_CStructure 
related to 0028990new kgv Community class Prs3d_Root can be removed 
child of 0023117closed bugmaster Open CASCADE TKV3d and TKOpenGl code clean-up 
Issue History
2014-03-22 17:20kgvNew Issue
2014-03-22 17:20kgvAssigned To => san
2014-03-22 17:20kgvRelationship addedrelated to 0024704
2014-03-22 17:21kgvRelationship addedchild of 0023117
2014-03-22 17:21kgvAssigned Tosan => kgv
2014-03-22 17:21kgvStatusnew => assigned
2014-03-23 14:57kgvNote Added: 0028434
2014-03-23 14:57kgvAssigned Tokgv => apl
2014-03-23 14:57kgvStatusassigned => resolved
2014-03-23 15:00kgvAdditional Information Updatedbug_revision_view_page.php?rev_id=7039#r7039
2014-03-25 15:56aplNote Added: 0028469
2014-03-25 15:56aplAssigned Toapl => bugmaster
2014-03-25 15:56aplStatusresolved => reviewed
2014-03-25 17:19mkvAssigned Tobugmaster => mkv
2014-03-25 19:07mkvNote Added: 0028476
2014-03-25 19:07mkvTest case number => Not needed
2014-03-25 19:07mkvAssigned Tomkv => kgv
2014-03-25 19:07mkvStatusreviewed => assigned
2014-03-26 13:04kgvNote Added: 0028486
2014-03-26 13:04kgvAssigned Tokgv => bugmaster
2014-03-26 13:04kgvStatusassigned => resolved
2014-03-26 13:04kgvStatusresolved => reviewed
2014-03-26 16:45mkvAssigned Tobugmaster => mkv
2014-03-27 14:30mkvNote Added: 0028510
2014-03-27 14:31mkvAssigned Tomkv => bugmaster
2014-03-27 14:31mkvStatusreviewed => tested
2014-03-28 16:38bugmasterChangeset attached => occt master b64d84be
2014-03-28 16:38bugmasterStatustested => verified
2014-03-28 16:38bugmasterResolutionopen => fixed
2014-04-04 11:54abvTarget Version6.7.1 => 6.8.0
2014-04-30 09:53kgvRelationship addedparent of 0024465
2014-11-11 12:47aivFixed in Version => 6.8.0
2014-11-11 12:52aivStatusverified => closed
2017-08-16 14:15kgvRelationship addedrelated to 0028990

Notes
(0028434)
kgv   
2014-03-23 14:57   
Patch is ready for review in CR24752_1 branch (history in CR24752).
(0028469)
apl   
2014-03-25 15:56   
Dear Bugmaster,

The branch is reviewed, please test.
(0028476)
mkv   
2014-03-25 19:07   
Dear BugMaster,

Branch CR24752_1 (and products from GIT master) was compiled on Linux and Windows platforms.
SHA-1: 8ef37163242ba68aeebb9447af44934bde82ea86

There are compilation errors on Linux platform:
http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24752_1/job/mnt-CR24752_1-master_build_occt_linux/1/parsed_console/? [^]

from ../../../../drv/AIS/AIS_DataMapIteratorOfDataMapOfSelStat_0.cxx:12:
../../../../inc/Handle_Prs3d_Presentation.hxx:17:42: error: Handle_Graphic3d_Structure.hxx: No such file or directory
error: Graphic3d_NameOfMaterial.hxx: No such file or directory

../../../../inc/PrsMgr_PresentationManager.hxx:20:49: error: Handle_Graphic3d_StructureManager.hxx: No such file or directory

../../../../inc/Prs3d_Presentation.hxx:20:35: error: Graphic3d_Structure.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:32:53: error: Handle_Graphic3d_DataStructureManager.hxx: No such file or directory
../../../../inc/Prs3d_Presentation.hxx:47:38: error: Handle_Graphic3d_Group.hxx: No such file or directory

....
(0028486)
kgv   
2014-03-26 13:04   
Please re-test updated branch.
(0028510)
mkv   
2014-03-27 14:30   
Dear BugMaster,

Branch CR24752_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 50b08e9efae2667f98513bdaa9a43afd80761d82

Number of compiler warnings:

occt component :
Linux: 29 (29 on master)
Windows: 0 (0 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 390736656 / 391480644
Total CPU difference: 52837.32000000001 / 51357.52999999966

Testing on Windows:
Total MEMORY difference: 434611596 / 434230736
Total CPU difference: 42828.3125 / 35761.59375

There are no differences in images found by testdiff.