MantisBT - Community
View Issue Details
0024729Community[OCCT] OCCT:Codingpublic2014-03-15 10:062017-09-29 16:29
eryar 
bugmaster 
normalminor 
closedfixed 
WindowsWindows 764 bit
[OCCT] 6.7.0 
[OCCT] 7.2.0[OCCT] 7.2.0 
Not required
0024729: Duplicate code to compute the normals for TopoDS_Face
There are duplicate code to compute the normals for the TopoDS_Face:
1. void StdPrs_ToolShadedShape::Normal (const TopoDS_Face& theFace,
                                     Poly_Connect& thePolyConnect,
                                     TColgp_Array1OfDir& theNormals)

2. In StlTransfer.cxx, also have the function to compute normals for surface:
   static void Normal(const TopoDS_Face& aFace,
           Poly_Connect& pc,
           TColgp_Array1OfDir& Nor)
   Though the normals are calcuted for the TopoDS_Face, but when output them to STL file, do not use these normals. The normals in STL file are normal of the triangle, not the vertex. So the function Normal() in StlTransfer.cxx can be removed.
N/A
No tags attached.
related to 0028840closed bugmaster Open CASCADE Data Exchange - rewrite the STL Reader/Writer 
Issue History
2014-03-15 10:06eryarNew Issue
2014-03-15 10:06eryarAssigned To => kgv
2014-09-12 14:44abvTarget Version => 7.1.0
2015-01-19 17:46kgvAssigned Tokgv => oan
2015-01-19 17:46kgvStatusnew => assigned
2016-11-01 06:41abvTarget Version7.1.0 => 7.2.0
2017-07-10 10:25kgvRelationship addedrelated to 0028840
2017-07-10 10:26kgvDescription Updatedbug_revision_view_page.php?rev_id=17055#r17055
2017-07-10 10:27kgvNote Added: 0068139
2017-07-27 11:17abvTarget Version7.2.0 => 7.4.0*
2017-08-08 08:46kgvNote Added: 0069191
2017-08-08 08:46kgvAssigned Tooan => bugmaster
2017-08-08 08:46kgvStatusassigned => feedback
2017-08-08 08:46kgvTarget Version7.4.0* => 7.2.0
2017-08-08 08:46kgvDescription Updatedbug_revision_view_page.php?rev_id=17284#r17284
2017-08-08 08:46kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17286#r17286
2017-08-08 09:55bugmasterStatusfeedback => tested
2017-08-08 09:55bugmasterStatustested => verified
2017-08-08 09:55bugmasterResolutionopen => fixed
2017-08-18 13:10bugmasterTest case number => Not required
2017-09-29 16:17aivFixed in Version => 7.2.0
2017-09-29 16:29aivStatusverified => closed

Notes
(0068139)
kgv   
2017-07-10 10:27   
StlTransfer (2) should be removed in scope of 0028840
(0069191)
kgv   
2017-08-08 08:46   
Dear bugmaster,

the issue has been fixed in scope of 0028840, this bug can be switched into VERIFIED state.