MantisBT - Open CASCADE
View Issue Details
0024547Open CASCADE[OCCT] OCCT:Codingpublic2014-01-21 12:152014-11-11 12:51
dln 
apn 
normalminor 
closedfixed 
x64Windows7
[OCCT] 6.7.0 
[OCCT] 6.8.0[OCCT] 6.8.0 
Not needed
0024547: Convertation of the generic classes to the non-generic (math)
In the package "math":

- class "math_DoubleTab" was converted to the non-generic class.
  Some changes were made in the class "math_Matrix".

- class "math_SingleTab" was converted to the non-generic template class.
  And classes "math_Vector" and "math_IntegerVector" converted to the non-cdl, because they use template class "math_SingleTab"
  
No tags attached.
child of 0024487closed abv Getting rid of generic CDL classes 
Issue History
2014-01-21 12:15dlnNew Issue
2014-01-21 12:15dlnAssigned To => abv
2014-01-21 14:05dlnDescription Updatedbug_revision_view_page.php?rev_id=6619#r6619
2014-01-21 14:09dlnRelationship addedchild of 0024487
2014-01-21 14:10dlnNote Added: 0027575
2014-01-21 14:57dlnStatusnew => resolved
2014-01-22 08:21dlnDescription Updatedbug_revision_view_page.php?rev_id=6622#r6622
2014-01-22 15:59abvAssigned Toabv => ifv
2014-01-22 15:59abvNote Added: 0027604
2014-01-22 17:19ifvNote Added: 0027610
2014-01-22 17:19ifvStatusresolved => reviewed
2014-01-22 17:42abvNote Added: 0027612
2014-01-22 17:42abvAssigned Toifv => bugmaster
2014-01-23 07:08mkvAssigned Tobugmaster => mkv
2014-01-23 15:51mkvNote Added: 0027630
2014-01-23 15:51mkvTest case number => Not needed
2014-01-23 15:51mkvAssigned Tomkv => dln
2014-01-23 15:51mkvStatusreviewed => assigned
2014-02-06 11:02dlnNote Added: 0027798
2014-02-06 11:02dlnAssigned Todln => abv
2014-02-06 11:02dlnStatusassigned => resolved
2014-02-06 12:04kgvNote Added: 0027800
2014-02-06 12:04kgvAssigned Toabv => dln
2014-02-06 12:04kgvStatusresolved => assigned
2014-02-06 12:16dlnNote Added: 0027801
2014-02-06 12:31dlnNote Edited: 0027801bug_revision_view_page.php?bugnote_id=27801#r6755
2014-02-06 12:36dlnNote Added: 0027802
2014-02-06 12:36dlnAssigned Todln => abv
2014-02-06 12:36dlnStatusassigned => resolved
2014-02-07 12:02abvNote Added: 0027811
2014-02-07 12:02abvAssigned Toabv => dln
2014-02-07 12:02abvStatusresolved => assigned
2014-02-07 18:54dlnNote Added: 0027818
2014-02-07 18:54dlnAssigned Todln => abv
2014-02-07 18:54dlnStatusassigned => resolved
2014-02-08 17:33abvNote Added: 0027821
2014-02-08 17:33abvAssigned Toabv => bugmaster
2014-02-08 17:33abvStatusresolved => reviewed
2014-02-10 13:01mkvAssigned Tobugmaster => mkv
2014-02-10 17:39mkvNote Added: 0027833
2014-02-10 17:39mkvAssigned Tomkv => bugmaster
2014-02-10 17:39mkvStatusreviewed => tested
2014-02-14 12:00apnChangeset attached => occt master 3b010a74
2014-02-14 12:00apnAssigned Tobugmaster => apn
2014-02-14 12:00apnStatustested => verified
2014-02-14 12:00apnResolutionopen => fixed
2014-04-04 12:36abvTarget Version6.7.1 => 6.8.0
2014-11-11 12:47aivFixed in Version => 6.8.0
2014-11-11 12:51aivStatusverified => closed

Notes
(0027575)
dln   
2014-01-21 14:10   
Changes are ready for review in CR24547 branch.
(0027604)
abv   
2014-01-22 15:59   
Igor, please review the fix; from my side I have no remarks
(0027610)
ifv   
2014-01-22 17:19   
Seems to be Ok
Small remark:
in my opinion, it is possible to remove math_Matrix from friends of math_IntegerVector because it is never used. Natural frieds are math_Matrix and math_Vector, it is used in some methods of math_Matrix and math_Vector.
(0027612)
abv   
2014-01-22 17:42   
I have pushed one more commit removing mentioned friend statement.
(0027630)
mkv   
2014-01-23 15:51   
Dear BugMaster,

Branch CR24547 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: a0773e04b59aa18a53256631dc829bcdbcbb50fe

Number of compiler warnings:

occt component :
Linux: 48 (48 on master)
Windows: 1 (1 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
http://occt-tests/CR24547-master-occt/Debian60-64/summary.html [^]
http://occt-tests/CR24547-master-occt/Windows-32-VC9/summary.html [^]

Testing cases:
Not needed
(0027798)
dln   
2014-02-06 11:02   
Branch CR24547 was updated, check it please.
(0027800)
kgv   
2014-02-06 12:04   
Dear dln,

+template<class T> class math_SingleTab
+{
+public:
+
+  DEFINE_STANDARD_ALLOC
+
+  Standard_EXPORT math_SingleTab(const Standard_Integer LowerIndex, const Standard_Integer UpperIndex) 
:
+      Addr(Buf),
+      isAllocated(UpperIndex - LowerIndex + 1 > aLengthOfBuf),

could you please remove Standard_EXPORT from all methods of template classes?
(0027801)
dln   
2014-02-06 12:16   
(edited on: 2014-02-06 12:31)
Dear kgv,

Ok, i'll correct it

(0027802)
dln   
2014-02-06 12:36   
Corrected. CR24547
(0027811)
abv   
2014-02-07 12:02   
Dmitry, please correct comments in the header files to be suitable for Doxygen generation:

- remove angle brackets (text within <> is considered as HTML tag by Doxygen)
- add @code ... @endcode around sample code blocks (see http://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdcode [^])
- add empty lines between the method declaration and comment to the next one

Then please verify the result by running Doxygen (command wgendoc in WOK) and checking the resulting HTML documentation
(0027818)
dln   
2014-02-07 18:54   
Dear Andrey,

Check it please. (CR24547)
(0027821)
abv   
2014-02-08 17:33   
No remarks, please test
(0027833)
mkv   
2014-02-10 17:39   
Dear BugMaster,

Branch CR24547 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: e275e53df0b56cbb019baac530ef087fcb90d9ac

Number of compiler warnings:

occt component :
Linux: 40 (40 on master)
Windows: 0 (0 on master)

products component :
Linux: 12 (12 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 381611520 / 381831144
Total CPU difference: 42478.560000000005 / 42213.76

Testing on Windows:
Total MEMORY difference: 430537788 / 431123492
Total CPU difference: 32528.59375 / 34130.65625

There are not differences in images found by testdiff.