MantisBT - Community
View Issue Details
0024508Community[OCCT] OCCT:Modeling Algorithmspublic2014-01-02 01:422017-05-28 18:17
barbier 
ifv 
normalminor 
closedfixed 
ALL
 
[OCCT] 6.9.0 
0024508: Suspect shadowed variable in BRepFeat_MakeLinearForm.cxx
Hello,

Lines 314-336 look like (Sliding is of type Standard_Boolean):

  if(Sliding) {
    Standard_Boolean Sliding = Standard_False;
    Handle(Geom_Surface) s = BRep_Tool::Surface(FirstFace);
    if (s->DynamicType() ==
    STANDARD_TYPE(Geom_RectangularTrimmedSurface)) {
      s = Handle(Geom_RectangularTrimmedSurface)::
    DownCast(s)->BasisSurface();
    }
    if(s->DynamicType() == STANDARD_TYPE(Geom_Plane) ||
       s->DynamicType() == STANDARD_TYPE(Geom_CylindricalSurface)) {
      // if plane or cylinder : sliding is possible
      Sliding = Standard_True;
    }
  }

  if(Sliding) {
  ...

But another Sliding variable is defined in the inner scope, and thus it is not modified in the outer scope.
No tags attached.
related to 0025734closed bugmaster Open CASCADE GCC warnings in Android build 
Issue History
2014-01-02 01:42barbierNew Issue
2014-01-02 01:42barbierAssigned To => ifv
2017-05-28 18:16abvRelationship addedrelated to 0025734
2017-05-28 18:17abvNote Added: 0066687
2017-05-28 18:17abvStatusnew => closed
2017-05-28 18:17abvFixed in Version => 6.9.0
2017-05-28 18:17abvResolutionopen => fixed

Notes
(0066687)
abv   
2017-05-28 18:17   
Fixed by 0025734