MantisBT - Community
View Issue Details
0024219Community[OCCT] OCCT:Meshpublic2013-10-01 17:102014-11-11 12:52
Timo 
apn 
normaltweak 
closedfixed 
[OCCT] 6.6.0 
[OCCT] 6.8.0[OCCT] 6.8.0 
Not needed
0024219: Strange if-statement in BrepMesh_IncrementalMesh
In BRepMesh_IncrementalMesh::Update(const TopoDS_Face& F) there is the following if-statement:

 if ((!myRelative && T->Deflection() <= 1.1*defface) ||
        (myRelative && T->Deflection() <= 1.1*defface))

Shouldn't it be simplified to:

 if (T->Deflection() <= 1.1*defface)


No tags attached.
Issue History
2013-10-01 17:10TimoNew Issue
2013-10-01 17:10TimoAssigned To => oan
2013-10-01 17:56TimoNote Added: 0025828
2013-12-21 10:13abvTarget Version6.7.0 => 6.7.1
2014-04-04 18:27abvTarget Version6.7.1 => 6.8.0
2014-05-19 10:32abvAssigned Tooan => azn
2014-05-19 10:32abvStatusnew => assigned
2014-05-20 09:25aznAssigned Toazn => oan
2014-05-20 09:25aznNote Added: 0029403
2014-05-20 09:25aznStatusassigned => resolved
2014-05-20 09:37abvNote Added: 0029404
2014-05-20 09:37abvAssigned Tooan => azn
2014-05-20 09:37abvStatusresolved => assigned
2014-05-21 10:07aznNote Added: 0029424
2014-05-21 10:08aznAssigned Toazn => abv
2014-05-21 10:08aznStatusassigned => resolved
2014-05-21 10:27abvNote Added: 0029425
2014-05-21 10:27abvAssigned Toabv => bugmaster
2014-05-21 10:27abvStatusresolved => reviewed
2014-05-22 11:06bugmasterAssigned Tobugmaster => apn
2014-05-26 18:51apnNote Added: 0029524
2014-05-26 18:51apnNote Edited: 0029524bug_revision_view_page.php?bugnote_id=29524#r7540
2014-05-26 18:52apnTest case number => Not needed
2014-05-26 18:52apnAssigned Toapn => bugmaster
2014-05-26 18:52apnStatusreviewed => tested
2014-05-30 12:59apnChangeset attached => occt master ab58a62b
2014-05-30 12:59apnAssigned Tobugmaster => apn
2014-05-30 12:59apnStatustested => verified
2014-05-30 12:59apnResolutionopen => fixed
2014-11-11 12:46aivFixed in Version => 6.8.0
2014-11-11 12:52aivStatusverified => closed

Notes
(0025828)
Timo   
2013-10-01 17:56   
A similar if-statement occurs in BRepMesh_IncrementalMesh::Update(const TopoDS_Edge& E)


if ((!myRelative && Poly->Deflection() <= 1.1*defedge) ||
     (myRelative && Poly->Deflection() <= 1.1*defedge))
(0029403)
azn   
2014-05-20 09:25   
Change pushed to CR24219, please review.
(0029404)
abv   
2014-05-20 09:37   
Alexander, as you decided to improve code formatting, please also translate French comments found in that file to English
(0029424)
azn   
2014-05-21 10:07   
Fixed. Please check.
(0029425)
abv   
2014-05-21 10:27   
Reviewed, please test
(0029524)
apn   
2014-05-26 18:51   
Dear BugMaster,

Branch CR24219 (and products from GIT master) was compiled on Linux, Windows and MacOS platforms and tested.
SHA-1: 1c0656fbd4783698fc944ecef01d5f60d7829030

Number of compiler warnings:

occt component :
Linux: 17 (17 on master)
Windows: 0 (0 on master)
MacOS: 202 (205 on master)

products component :
Linux: 11 (11 on master)
Windows: 2 (2 on master)

Regressions/Differences:
No regressions

Testing case:
Not needed

Testing on Linux:
Total MEMORY difference: 356721844 / 357326856
Total CPU difference: 62020.18999999979 / 56363.43999999993

Testing on Windows:
Total MEMORY difference: 379292832 / 379613888
Total CPU difference: 39599.625 / 35503.203125

There are no differences in images found by testdiff.