|
Notes |
|
|
(0025161)
|
|
omy
|
|
2013-07-25 17:39
|
|
Dear kgv,
Please, review the fixes made in branch CR24087. |
|
|
|
(0025165)
|
|
kgv
|
|
2013-07-26 10:44
|
|
Dear omy, here are my suggestions:
In function DDataStd_SetByteArray:
> for(Standard_Integer i = From; i<=To; i++) {
> Standard_Integer ival = Draw::Atoi(arg[j]);
> if(ival > 255) {
> cout << "Bad value = " << ival<< endl;
> return 1;
> }
> A->SetValue(i, (Standard_Byte)ival);
> j++;
> }
According to content of other functions ival should be checked for negative values as well.
/*static*/ int ViewerMainLoop(Standard_Integer argc, const char** argv)
Please avoid commenting code - remove it when reasonable. |
|
|
|
(0025181)
|
|
omy
|
2013-07-29 10:20
(edited on: 2013-07-29 10:21) |
|
Dear kgv,
I've made the fixes you've mentioned.
Please, review.
|
|
|
|
(0025182)
|
|
kgv
|
|
2013-07-29 10:29
|
|
|
Patch is ready for testing. |
|
|
|
(0025206)
|
|
mkv
|
|
2013-07-30 16:00
|
|
Dear BugMaster,
Branch CR24087 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 277c90ad1ba1fa18de3c22b6cf64f6ca5ccaf443
Number of compiler warnings:
occt component :
Linux: 947 (953 on master)
Windows: 916 (958 on master)
products component :
Linux: 189 (189 on master)
Windows: 288 (288 on master)
Regressions:
No regressions
Improvements:
No improvements
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 362927312 / 363320812
Total CPU difference: 46169.74000000097 / 45478.66000000069
Testing on Windows:
Total MEMORY difference: 421890944 / 422579736
Total CPU difference: 39463.953125 / 41697.453125
There are not differences in images found by testdiff. |
|