MantisBT - Community
View Issue Details
0024050Community[OCCT] OCCT:Visualizationpublic2013-06-27 15:482013-12-19 13:56
Pawel 
Pawel 
normalminor 
closedfixed 
ALL
[OCCT] 6.6.0 
[OCCT] 6.7.0[OCCT] 6.7.0 
Not needed
0024050: Voxel_FastConverter::Convert / ConvertUsingSAT - problems in multithreaded scenario
Both methods mentioned above use the following code to judge which triangles to process in the specified thread:

start_thread_triangle = (ithread - 1) * (myNbTriangles / myNbThreads) + 1;
end_thread_triangle = (ithread - 0) * (myNbTriangles / myNbThreads);

That code gives incorrect results for some cases due to the fact that the computation is carried out on integer numbers, e.g.:

myNbTriangles = 12; //Box
myNbThreads = 8;

(myNbTriangles / myNbThreads) always yields 1 and so the triangle 9 to 12 are never processed.
No tags attached.
Issue History
2013-06-27 15:48PawelNew Issue
2013-06-27 15:48PawelAssigned To => Pawel
2013-06-27 20:37PawelNote Added: 0024905
2013-06-27 20:37PawelAssigned ToPawel => vro
2013-06-27 20:37PawelStatusnew => resolved
2013-06-28 10:18vroStatusresolved => reviewed
2013-06-28 10:46mkvAssigned Tovro => mkv
2013-06-28 11:27PawelDescription Updatedbug_revision_view_page.php?rev_id=5575#r5575
2013-07-01 10:17mkvNote Added: 0024920
2013-07-01 10:17mkvTest case number => Not needed
2013-07-01 10:17mkvAssigned Tomkv => bugmaster
2013-07-01 10:17mkvStatusreviewed => tested
2013-07-05 11:57PawelChangeset attached => occt master 03679c48
2013-07-05 11:57PawelAssigned Tobugmaster => Pawel
2013-07-05 11:57PawelStatustested => verified
2013-07-05 11:57PawelResolutionopen => fixed
2013-12-19 13:53bugmasterStatusverified => closed
2013-12-19 13:56bugmasterFixed in Version => 6.7.0

Notes
(0024905)
Pawel   
2013-06-27 20:37   
Branch CR24050 pushed. Please review.
(0024920)
mkv   
2013-07-01 10:17   
Dear BugMaster,

Branch CR24050 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 80985adb13c39e6b1ccc1f5756659a2cf38d9914

Number of compiler warnings:

occt component :
Linux: 2 (2 on master)
Windows: 7 (7 on master)

products component :
Linux: 0 (0 on master)
Windows: 63 (63 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 366479568 / 366290416
Total CPU difference: 42713.9700000004 / 43406.39000000102

Testing on Windows:
Total MEMORY difference: 419173696 / 421068392
Total CPU difference: 34917.359375 / 42645.65625

There are not differences in images found by testdiff.