MantisBT - Open CASCADE
View Issue Details
0024048Open CASCADE[OCCT] OCCT:Codingpublic2013-06-26 16:092013-12-19 13:58
ibs 
ibs 
lowminor 
closedfixed 
[OCCT] 6.6.0 
[OCCT] 6.7.0[OCCT] 6.7.0 
Not needed
0024048: "Basic Runtime Checks" option of VS projects should be equal to "RTC1"
It's required changing "Basic Runtime Checks" option in VS projects (debug mode) to report, for example, when a variable is used without having been initialized (RTCu).

note: RTC1 equiv. to /RTCsu

After OCCT debug building with Visual Studio with "Basic Runtime Checks" option equals RTC1, testgrid process produces debug errors: the variable '<variable>' is being used withoud being initialized


tolreached in(src\ChFi3d\ChFi3d_Builder_6.cxx);
LocalTransition in in deb case (src\HatchGen\HatchGen_Hatcher.gxx);
vprev in(src\Blend\Blend_Walking_3.gxx);
uprev in(src\BRepBlend\BRepBlend_SurfRstLineBuilder.cxx);
lxp in (src\Interface\Interface_FloatWriter.cxx)
pBuff in (src\OSD\OSD_Process.cxx)
ier inAdvApp2Var/AdvApp2Var_ApproxF2var.cxx
FacRevolInfini inBRepFeat_MakePrism.cxx

aPrefix in (src\RWStepBasic\RWStepBasic_RWSiUnitAndPlaneAngleUnit.cxx,
src\RWStepBasic\RWStepBasic_RWSiUnit.cxx,
src\RWStepBasic\RWStepBasic_RWSiUnitAndLengthUnit.cxx,
src\RWStepBasic\RWStepBasic_RWSiUnitAndMassUnit.cxx,
src\RWStepBasic\RWStepBasic_RWSiUnitAndThermodynamicTemperatureUnit.cxx,
src\RWStepBasic\RWStepBasic_RWSiUnitAndTimeUnit.cxx)
1. wgenproj -target=vc9
2. build the solution in debug mode
3. run.bat -> testgrid
"Basic Runtime Checks" option of VS projects and generated cmake meta-project has been changed to "RTC1"

all appeared run-time errors have been fixed.

extended description of case with nomber variable in src\IGESData\IGESData_GlobalSection.cxx:
 
nombre variable (mas of chars) was expanded to 1024 (had been 20). this expansion helps avoiding the error of conversion a float number to mas of chars: the size of mas is enough for converting float number now. Interface_FloatWriter::Convert doesnt work correct with second argument which size is less 21 (in some cases).
No tags attached.
parent of 0024211closed bugmaster Definition of Basic Runtime Check parameter causes regression in debug mode 
Issue History
2013-06-26 16:09ibsNew Issue
2013-06-26 16:09ibsAssigned To => ibs
2013-06-26 16:09ibsDescription Updatedbug_revision_view_page.php?rev_id=5550#r5550
2013-06-26 16:11ibsDescription Updatedbug_revision_view_page.php?rev_id=5551#r5551
2013-06-26 16:18ibsSummaryThere are many errors in tests with "Basic Runtime Checks" option of MSVC equals to "RTC1" => "Basic Runtime Checks" option of VS projects should be equal to "RTC1"
2013-06-26 16:18ibsDescription Updatedbug_revision_view_page.php?rev_id=5552#r5552
2013-06-26 16:22ibsAdditional Information Updatedbug_revision_view_page.php?rev_id=5554#r5554
2013-06-26 18:10ibsNote Added: 0024889
2013-06-26 18:15ibsNote Edited: 0024889bug_revision_view_page.php?bugnote_id=24889#r5558
2013-06-26 18:19ibsDescription Updatedbug_revision_view_page.php?rev_id=5559#r5559
2013-06-26 18:19ibsAdditional Information Updatedbug_revision_view_page.php?rev_id=5560#r5560
2013-06-26 18:19ibsStatusnew => assigned
2013-06-26 18:25ibsDescription Updatedbug_revision_view_page.php?rev_id=5561#r5561
2013-06-27 12:44ibsDescription Updatedbug_revision_view_page.php?rev_id=5565#r5565
2013-06-28 15:09ibsNote Added: 0024911
2013-06-28 15:09ibsAssigned Toibs => bugmaster
2013-06-28 15:09ibsStatusassigned => resolved
2013-06-28 15:09ibsStatusresolved => reviewed
2013-06-28 15:10ibsNote Added: 0024912
2013-06-28 15:17ibsNote Added: 0024913
2013-06-28 15:18ibsSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5581#r5581
2013-06-28 15:20ibsNote Edited: 0024912bug_revision_view_page.php?bugnote_id=24912#r5583
2013-06-28 16:19ibsDescription Updatedbug_revision_view_page.php?rev_id=5584#r5584
2013-07-02 09:42apnNote Added: 0024938
2013-07-02 09:42apnNote Edited: 0024938bug_revision_view_page.php?bugnote_id=24938#r5590
2013-07-02 09:44apnAssigned Tobugmaster => ibs
2013-07-02 09:44apnStatusreviewed => assigned
2013-07-03 12:59ibsDescription Updatedbug_revision_view_page.php?rev_id=5597#r5597
2013-07-03 12:59ibsAdditional Information Updatedbug_revision_view_page.php?rev_id=5598#r5598
2013-07-03 14:28ibsAdditional Information Updatedbug_revision_view_page.php?rev_id=5599#r5599
2013-07-04 12:19ibsNote Added: 0024961
2013-07-04 12:20ibsNote Edited: 0024961bug_revision_view_page.php?bugnote_id=24961#r5606
2013-07-05 09:07ibsPrioritynormal => low
2013-07-09 11:52ibsStatusassigned => resolved
2013-07-09 11:57ibsNote Added: 0024996
2013-07-09 11:57ibsAssigned Toibs => bugmaster
2013-07-09 11:57ibsStatusresolved => reviewed
2013-07-09 12:04apnAssigned Tobugmaster => apn
2013-07-09 17:04apnNote Added: 0025002
2013-07-09 17:05apnNote Edited: 0025002bug_revision_view_page.php?bugnote_id=25002#r5620
2013-07-09 17:06apnTest case number => Not needed
2013-07-09 17:06apnAssigned Toapn => bugmaster
2013-07-09 17:06apnStatusreviewed => tested
2013-07-12 18:08ibsChangeset attached => occt master a8195d65
2013-07-12 18:08ibsAssigned Tobugmaster => ibs
2013-07-12 18:08ibsStatustested => verified
2013-07-12 18:08ibsResolutionopen => fixed
2013-09-30 15:19abvNote Added: 0025794
2013-09-30 15:19abvRelationship addedparent of 0024211
2013-12-19 13:52bugmasterStatusverified => closed
2013-12-19 13:58bugmasterFixed in Version => 6.7.0
2014-01-11 11:58abvCategoryOCCT Release:BUILD => OCCT:Coding

Notes
(0024889)
ibs   
2013-06-26 18:10   
(edited on: 2013-06-26 18:15)
"Basic Runtime Checks" was equal to "Both (/RTC1, equiv. to /RTCsu)" for DRAWEXE of vc7, vc8 and vc9.
"Basic Runtime Checks" was equal to "default" for DRAWEXE of vc10 and vc11 and other projects of all vc versions.

(0024911)
ibs   
2013-06-28 15:09   
Dear bugmaster,
please test these changes
(0024912)
ibs   
2013-06-28 15:10   
(edited on: 2013-06-28 15:20)
to test you should:
1. generate project: wgenproj -target=vc9
3. build this solution in debug mode
5. execute run.bat script located in casroot folder with arguments: vc9 win32 Debug
6. and run testgrid there (into draw prompt)


if debug error appear - just take screenshot of error and click "abort" button (test will be failed; next one will start to execute);
after all send this errors to me and i'll fix them

(0024913)
ibs   
2013-06-28 15:17   
if tests are good for vc9 then we should generate vc8, vc10 and vc11 projects and test them (steps above).
(0024938)
apn   
2013-07-02 09:42   
Few debug errors appear, I send screenshots by mail.
You can find results of testing in /dn60/tests_results/results_CR24048_2013-07-01T1250

(0024961)
ibs   
2013-07-04 12:19   
(edited on: 2013-07-04 12:20)
we will run test with these fixes and without ones, after that we will compare the results. if the results are equal, the one will be integrated into OCCT master

results with fixes are placed: /dn60/tests_results/results_CR24048_2013-07-03T1543

(0024996)
ibs   
2013-07-09 11:57   
Dear bugmaster,
please integrate these fixes. Also there is a need to change status (todo?) of tests: de step_5 A6, de step_5 B3; de iges_3 A9.
(0025002)
apn   
2013-07-09 17:04   
(edited on: 2013-07-09 17:05)
Dear BugMaster,

Branch CR24048 (and products from GIT master) was compiled on Linux and Windows platforms and tested in Release mode vc9.
SHA-1: d8551e5299c6546e1dbd4d646c1bb15d206cfb61

Number of compiler warnings:

occt component :
Linux: 2 (2 on master)
Windows: 7 (7 on master)

products component :
Linux: 0 (0 on master)
Windows: 63 (63 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 366180748 / 364883904
Total CPU difference: 45798.51000000106 / 44722.74000000091

Testing on Windows:
Total MEMORY difference: 422454516 / 425478060
Total CPU difference: 38640.921875 / 41686.203125

There are not differences in images found by testdiff.

Branch CR24048 in wok repository was pushed to master.

(0025794)
abv   
2013-09-30 15:19   
This fix should have been tested in Debug mode! See 0024211