MantisBT - Community
View Issue Details
0024045Community[OCCT] OCCT:Foundation Classespublic2013-06-25 21:482013-12-19 13:57
Roman Lygin 
bugmaster 
normalminor 
closedfixed 
ALL
[OCCT] 6.6.0 
[OCCT] 6.7.0[OCCT] 6.7.0 
bugs moddata_2(012) bug524
0024045: Invalid test case for matrix-vector multiplication
The fix used incompatible combination of matrix/vector dimensions. Fixed test case and added missing checks (causing exception) in Debug mode.

The fix should be integrated along with 0024044
test bugs moddata_2 bug524
No tags attached.
related to 0000524closed ifv math_Vector::Multiply(const Vector & v, const Matrix &m) broken 
parent of 0024044closed bugmaster Performance improvements: Foundation Classes (math) 
Issue History
2013-06-25 21:48Roman LyginNew Issue
2013-06-25 21:48Roman LyginAssigned To => abv
2013-06-25 21:49Roman LyginRelationship addedparent of 0024044
2013-06-25 21:59Roman LyginNote Added: 0024867
2013-06-25 21:59Roman LyginStatusnew => resolved
2013-06-26 07:01abvRelationship addedrelated to 0000524
2013-06-26 07:06abvNote Added: 0024870
2013-06-26 07:06abvStatusresolved => reviewed
2013-06-26 08:08abvNote Added: 0024871
2013-08-14 15:50abvNote Added: 0025305
2013-08-14 15:50abvAssigned Toabv => bugmaster
2013-08-14 17:11mkvAssigned Tobugmaster => mkv
2013-08-15 10:44mkvNote Added: 0025312
2013-08-15 10:45mkvTest case number => bugs moddata_2(012) bug524
2013-08-15 15:03mkvNote Added: 0025319
2013-08-15 15:05mkvAssigned Tomkv => bugmaster
2013-08-15 15:05mkvStatusreviewed => tested
2013-08-17 12:50bugmasterChangeset attached => occt master d2d893b8
2013-08-17 12:50bugmasterStatustested => verified
2013-08-17 12:50bugmasterResolutionopen => fixed
2013-08-21 14:48bugmasterTarget Version => 6.7.0
2013-12-19 13:52bugmasterStatusverified => closed
2013-12-19 13:57bugmasterFixed in Version => 6.7.0

Notes
(0024867)
Roman Lygin   
2013-06-25 21:59   
The fix has been pushed to the repository
(0024870)
abv   
2013-06-26 07:06   
Reviewed. I wonder how this worked before... User comment in 0000524 still holds...
(0024871)
abv   
2013-06-26 08:08   
Besides, is it correct that ${Vector2_2} is checked against 125 while other components are expected to be equal to 120?? The whole test seems worth revising
(0025305)
abv   
2013-08-14 15:50   
Halloo!! Test this please!
(0025312)
mkv   
2013-08-15 10:44   
Dear BugMaster,

Branch CR24045 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: 25bba42358057d3cec8f37ae8fdc2db6e70a4ab9

Number of compiler warnings:

occt component :
Linux: 917 (917 on master)
Windows: 855 (855 on master)

products component :
Linux: 188 (188 on master)
Windows: 287 (287 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
bugs moddata_2(012) bug524 - OK.

Testing on Linux:
Total MEMORY difference: 363642696 / 363259508
Total CPU difference: 56716.84000000134 / 49186.110000000495

Testing on Windows:
Total MEMORY difference: 425464108 / 424579644
Total CPU difference: 34652.78125 / 33046.4375

There are not differences in images found by testdiff.
(0025319)
mkv   
2013-08-15 15:03   
Dear BugMaster,
The fix should be integrated along with 0024044