MantisBT - Community
View Issue Details
0023965Community[OCCT] OCCT:Visualizationpublic2013-05-15 19:112013-12-19 13:55
Pawel 
Pawel 
normalminor 
closedfixed 
ALL
[OCCT] 6.6.0 
[OCCT] 6.7.0[OCCT] 6.7.0 
Not needed
0023965: Making unnecessary copies of TopoDS_Face in Voxel_FastConverter when checking triangulation
In Voxel_FastConverter.cxx there are three lines where faces are copied. Using reference should be enough.
No tags attached.
Issue History
2013-05-15 19:11PawelNew Issue
2013-05-15 19:11PawelAssigned To => Pawel
2013-05-15 19:19PawelSummaryMaking unnecessary copies of TopoDS_Face when checking triangulation => Making unnecessary copies of TopoDS_Face in Voxel_FastConverter when checking triangulation
2013-05-15 19:25PawelNote Added: 0024406
2013-05-15 19:25PawelAssigned ToPawel => bugmaster
2013-05-15 19:25PawelStatusnew => resolved
2013-05-22 12:01bugmasterNote Added: 0024459
2013-05-22 12:01bugmasterAssigned Tobugmaster => vro
2013-05-22 12:01bugmasterStatusresolved => assigned
2013-05-22 14:22vroNote Added: 0024464
2013-05-22 14:22vroStatusassigned => resolved
2013-05-22 14:22vroNote Added: 0024465
2013-05-22 14:22vroStatusresolved => reviewed
2013-05-22 14:56mkvAssigned Tovro => mkv
2013-05-29 16:24mkvNote Added: 0024545
2013-05-29 16:25mkvTest case number => Not needed
2013-05-29 16:25mkvAssigned Tomkv => bugmaster
2013-05-29 16:25mkvStatusreviewed => tested
2013-06-03 14:48PawelChangeset attached => occt master 034b4775
2013-06-03 14:48PawelAssigned Tobugmaster => Pawel
2013-06-03 14:48PawelStatustested => verified
2013-06-03 14:48PawelResolutionopen => fixed
2013-12-19 13:53bugmasterStatusverified => closed
2013-12-19 13:55bugmasterFixed in Version => 6.7.0

Notes
(0024406)
Pawel   
2013-05-15 19:25   
Branch CR23965 pushed. Please review.
(0024459)
bugmaster   
2013-05-22 12:01   
Vlad,
Please make reviewing
(0024464)
vro   
2013-05-22 14:22   
Thank you for improvement of the code!
(0024465)
vro   
2013-05-22 14:22   
Reviewed!
(0024545)
mkv   
2013-05-29 16:24   
Dear BugMaster,

Branch CR23965 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: a499ba08f4f0b04c85a3e628f5b73d6c41de45e0

Number of compiler warnings:

occt component :
Linux: 2 (2 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 64 (64 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 365998340 / 365885296
Total CPU difference: 46744.110000000976 / 45787.42000000135

Testing on Windows:
Total MEMORY difference: 417289536 / 420905440
Total CPU difference: 31821.921875 / 30779.234375

There are not differences in images found by testdiff.