MantisBT - Community
View Issue Details
0023841Community[OCCT] OCCT:DRAWpublic2013-03-20 12:232013-04-29 15:24
Pawel 
dbv 
normalminor 
closedfixed 
ALL
[OCCT] 6.5.4 
[OCCT] 6.6.0[OCCT] 6.6.0 
Not needed
0023841: Redundant assignment to itself.
In ViewerTest_ViewerCommands.cxx
Lines:

1163 / 1164
X_ButtonPress = X_ButtonPress;
Y_ButtonPress = Y_ButtonPress;

and 1251 / 1252
X_Motion = X_Motion;
Y_Motion = Y_Motion;

Not sure about the intention. Maybe some cross-assignement like
X_Motion = X_ButtonPress
was meant?
No tags attached.
child of 0023243closed bugmaster Open CASCADE Adapt OpenGL viewer for using in Cocoa applications on Mac OS X 
Issue History
2013-03-20 12:23PawelNew Issue
2013-03-20 12:23PawelAssigned To => bugmaster
2013-03-20 12:33abvAssigned Tobugmaster => dbv
2013-03-20 12:33abvStatusnew => assigned
2013-03-20 12:35abvRelationship addedchild of 0023243
2013-03-20 12:35abvNote Added: 0023811
2013-03-20 12:39abvTarget Version6.7.0 => 6.6.0
2013-03-20 13:42dbvNote Added: 0023814
2013-03-20 13:42dbvAssigned Todbv => abv
2013-03-20 13:42dbvStatusassigned => resolved
2013-03-20 14:36abvNote Added: 0023815
2013-03-20 14:36abvAssigned Toabv => bugmaster
2013-03-20 14:36abvStatusresolved => reviewed
2013-03-20 14:37abvNote Added: 0023816
2013-03-20 15:10PawelNote Added: 0023818
2013-03-20 16:30mkvAssigned Tobugmaster => mkv
2013-03-21 18:22mkvNote Added: 0023838
2013-03-21 18:23mkvTest case number => Not needed
2013-03-21 18:23mkvAssigned Tomkv => bugmaster
2013-03-21 18:23mkvStatusreviewed => tested
2013-03-25 18:39dbvChangeset attached => occt master 5c686fff
2013-03-25 18:39dbvAssigned Tobugmaster => dbv
2013-03-25 18:39dbvStatustested => verified
2013-03-25 18:39dbvResolutionopen => fixed
2013-04-23 13:35aivStatusverified => closed
2013-04-29 15:24aivFixed in Version => 6.6.0

Notes
(0023811)
abv   
2013-03-20 12:35   
The code in question has been integrated with 0023243
(0023814)
dbv   
2013-03-20 13:42   
Before patch 0023243 there were duplicate variables (X_ButtonPress == xx1, X_Motion == xx2, Y_ButtonPress == yy1, Y_Motion == yy2). So, this assignment does not carry any sense, and can be removed.

Dear Andrey, please review branch CR23841
(0023815)
abv   
2013-03-20 14:36   
No remarks, please test.
(0023816)
abv   
2013-03-20 14:37   
Pawel, thank you for reporting the issue -- it was real bug!
(0023818)
Pawel   
2013-03-20 15:10   
Hello Andrey,

no problem. I occasionally run cppcheck and/or PVS-Studio on OCCT and this is how such issues come up...
(0023838)
mkv   
2013-03-21 18:22   
Dear BugMaster,

Branch CR23841 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase.
SHA-1: fb506ad63d0e609fe97c34ff1646744f2683fa0c

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 243645256 / 241817424
Total CPU difference: 16888.970000000067 / 14998.230000000101

Testing on Windows:
Total MEMORY difference: 351739168 / 354518108
Total CPU difference: 21628.5625 / 22867.515625

There are not serious differences in images found by testdiff.