MantisBT - Open CASCADE
View Issue Details
0023760Open CASCADE[OCCT] OCCT:Visualizationpublic2013-02-14 10:412020-08-28 16:31
san 
kgv 
lowintegration request 
assignedopen 
ALL
[OCCT] 6.5.4 
[OCCT] 7.6.0* 
0023760: Visualization - drop redundant class AIS_Triangulation
- AIS_Triangulation::Compute(): hasVColors and myFlagColors variables contain identical values, so one of them should be removed.

- AIS_Triangulation::Compute(): the purpose of the following line is unclear:
const TColStd_Array1OfInteger& colors = myColor->Array1();
Is it really needed? Most likely it is to be removed, and myColor variable should be used directly in the loop below.

- General remark concerning AIS_Triangulation class: myFlagColors, myNbNodes and myNbTriangles class fields should be removed as completely useless. Consistency of the color array should be checked in Compute() method and include standard non-null handle check and array size check.

- OCCT coding rules to be applied.
No tags attached.
Issue History
2013-02-14 10:41sanNew Issue
2013-02-14 10:41sanAssigned To => san
2013-02-14 10:41sanRelationship addedrelated to 0023743
2014-02-17 16:18kgvNote Added: 0027928
2016-06-16 20:54kgvAssigned Tosan => kgv
2016-06-16 20:54kgvSeveritytweak => integration request
2016-06-16 20:54kgvStatusnew => assigned
2016-06-16 20:54kgvTarget Version => 7.1.0
2016-06-16 20:54kgvSummaryRevision of AIS_Triangulation class implementation => Visualization - drop redundant class AIS_Triangulation
2016-10-25 09:38kgvTarget Version7.1.0 => 7.2.0
2017-07-20 10:51kgvTarget Version7.2.0 => 7.4.0
2019-08-13 12:04kgvTarget Version7.4.0 => 7.5.0
2020-08-28 16:31kgvTarget Version7.5.0 => 7.6.0*

Notes
(0027928)
kgv   
2014-02-17 16:18   
This class seems to be not much usable in current state.
Probably better drop it entirely.

Remark by Roman Lygin:
> Why not use MeshVS instead?