MantisBT - Community
View Issue Details
0023373Community[OCCT] OCCT:Foundation Classespublic2012-08-07 20:272012-11-16 13:17
Pawel 
Pawel 
normaltweak 
closedfixed 
WindowsVC++ 200864 bit
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023373: MSVC++ warnings issued during compilation for 64bits, 'Sparse Arrays'
Standard_Integer should be replaced with Standard_Size to avoid compiler warnings.
Remark for release notes: interface of the class NCollection_SparseArray has changed to use Standard_Size (unsigned) for index, instead of Standard_Integer; the applications that use that class will likely need update (at least, to avoid compiler warnings)
No tags attached.
related to 0023274closed Pawel MSVC++ warnings issued during compilation for 64bits 
Issue History
2012-08-07 20:27PawelNew Issue
2012-08-07 20:27PawelAssigned To => Pawel
2012-08-08 11:55PawelNote Added: 0021216
2012-08-08 11:55PawelAssigned ToPawel => bugmaster
2012-08-08 11:55PawelStatusnew => resolved
2012-08-08 11:55PawelRelationship addedrelated to 0023274
2012-08-09 14:54bugmasterAssigned Tobugmaster => emv
2012-08-10 11:22kgvNote Added: 0021227
2012-08-10 12:21PawelNote Added: 0021228
2012-08-14 09:55bugmasterAssigned Toemv => kgv
2012-08-16 12:54kgvAssigned Tokgv => abv
2012-08-19 11:22abvNote Added: 0021285
2012-08-19 11:22abvAssigned Toabv => bugmaster
2012-08-19 11:22abvStatusresolved => reviewed
2012-08-19 11:22abvAdditional Information Updatedbug_revision_view_page.php?rev_id=4160#r4160
2012-08-21 16:51apnNote Added: 0021306
2012-08-21 17:01apnTest case number => Not needed
2012-08-21 17:01apnStatusreviewed => tested
2012-08-27 16:17PawelChangeset attached => occt master d93f7683
2012-08-27 16:18PawelAssigned Tobugmaster => Pawel
2012-08-27 16:18PawelStatustested => verified
2012-08-27 16:18PawelResolutionopen => fixed
2012-11-16 13:14bugmasterFixed in Version => 6.5.4
2012-11-16 13:17bugmasterStatusverified => closed

Notes
(0021216)
Pawel   
2012-08-08 11:55   
Corresponding git branch pushed. Please review.
(0021227)
kgv   
2012-08-10 11:22   
Not fully reviewed but please notice that some portions of code may become incorrect due to signed (Standard_Integer) -> unsigned (Standard_Size) conversion like in this place:

>Standard_Address NCollection_SparseArrayBase::setValue (const Standard_Size theIndex,
> const Standard_Address theValue)
> {
> Standard_OutOfRange_Raise_if (theIndex<0,"NCollection_SparseArray::SetValue()")
(0021228)
Pawel   
2012-08-10 12:21   
Thanks for your hints!

I have updated and pushed the branch CR23373.

In my opinion the check 'Standard_OutOfRange_Raise_if' was not necessary anymore so I removed it.

I have also removed redundant casting to 'Standard_Size' and checking if a 'Standard_Size' variable was negative.
(0021285)
abv   
2012-08-19 11:22   
Reviewed, please test.
(0021306)
apn   
2012-08-21 16:51   
Dear BugMaster,
Branch CR23373 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed