MantisBT - Community
View Issue Details
0023323Community[OCCT] OCCT:Visualizationpublic2012-07-18 13:572013-04-29 15:21
Pawel 
aba 
normaljust a question 
closedfixed 
ALL
[OCCT] 6.5.3 
[OCCT] 6.6.0[OCCT] 6.6.0 
Not needed
0023323: Duplicate if-clause in Visual3d_View.cxx
In lines 1320 and 1322 the same if-clause is specified

if (VUPIsModified || VRPIsModified || VRUIsModified || CustomIsModified) {

Not sure about the intention of that code...

Is this possible that the second 'if' should check a subset of flags from the preceding if-clause?
No tags attached.
Issue History
2012-07-18 13:57PawelNew Issue
2012-07-18 13:57PawelAssigned To => bugmaster
2012-08-17 16:44bugmasterAssigned Tobugmaster => san
2012-08-17 16:44bugmasterStatusnew => assigned
2012-10-23 11:35abvTarget Version6.5.4 => 6.6.0
2012-10-24 13:46sanAssigned Tosan => aba
2012-10-25 17:10abaNote Added: 0021957
2012-10-25 17:10abaStatusassigned => resolved
2012-10-25 17:11abaAssigned Toaba => san
2012-10-27 00:03sanNote Added: 0021980
2012-10-27 00:03sanAssigned Tosan => aba
2012-10-27 00:03sanStatusresolved => assigned
2012-10-27 00:04sanNote Edited: 0021980bug_revision_view_page.php?bugnote_id=21980#r4436
2012-11-07 15:22abaNote Added: 0022129
2012-11-07 15:23abaAssigned Toaba => san
2012-11-07 15:23abaStatusassigned => resolved
2012-11-13 19:32abaNote Edited: 0022129bug_revision_view_page.php?bugnote_id=22129#r4592
2012-11-13 19:41sanNote Added: 0022232
2012-11-13 19:41sanAssigned Tosan => bugmaster
2012-11-13 19:41sanStatusresolved => reviewed
2012-11-14 12:20mkvAssigned Tobugmaster => mkv
2012-11-16 14:58mkvNote Added: 0022279
2012-11-16 14:59mkvTest case number => Not needed
2012-11-16 14:59mkvAssigned Tomkv => aba
2012-11-16 14:59mkvStatusreviewed => assigned
2012-12-05 10:27abaNote Added: 0022557
2012-12-05 10:27abaAssigned Toaba => san
2012-12-05 10:27abaStatusassigned => resolved
2012-12-06 16:14sanNote Added: 0022595
2012-12-06 16:14sanAssigned Tosan => bugmaster
2012-12-06 16:14sanStatusresolved => reviewed
2012-12-06 20:22mkvAssigned Tobugmaster => mkv
2012-12-07 17:55mkvNote Added: 0022628
2012-12-07 17:55mkvAssigned Tomkv => bugmaster
2012-12-07 17:55mkvStatusreviewed => tested
2012-12-18 10:45abaChangeset attached => occt master bd92cc2a
2012-12-18 10:45abaAssigned Tobugmaster => aba
2012-12-18 10:45abaStatustested => verified
2012-12-18 10:45abaResolutionopen => fixed
2013-04-23 13:36aivStatusverified => closed
2013-04-29 15:21aivFixed in Version => 6.6.0

Notes
(0021957)
aba   
2012-10-25 17:10   
An outer condition in line 1320 was modified to consider the ScaleIsModified variable.

The Git branch CR23323 is ready to be reviewed.
Dear san, please review.
(0021980)
san   
2012-10-27 00:03   
(edited on: 2012-10-27 00:04)
Branch CR23323 reviewed with the following remark:

Note that CustomIsModified flag indicates a change in the custom view orientation matrix.
If this matrix is not null, then it is up to an application to update it. OCCT cannot recompute the custom view orientation matrix, hence it is necessary to check carefully if these two lines should be executed when CustomIsModified is true:

                MyMatOfOriIsModified = Standard_True;
                MyMatOfOriIsEvaluated = Standard_False;

However, adding ScaleIsModified to the outer condition looks correct and should be kept.

(0022129)
aba   
2012-11-07 15:22   
(edited on: 2012-11-13 19:32)
The Git branch CR23323 was updated.

1) MyMatOfOriIsModified and MyMatOfMapIsModified flages were removed from Visual3d_View.cxx and from Visual3d_View.pxx as unused ones.

2) MyMatOfOriIsEvaluated and MyMatOfMapIsEvaluated flags were left as they are used to check if it it necessary to get orientation and mapping matrices or they are evaluated already.

3)CustomIsModified flag was replaced with ScaleIsModified flag in checking of view matrix modification in line 1196 of SetViewOrientation method and in line 1310 of ViewOrientationReset method.

Dear san, please review.

(0022232)
san   
2012-11-13 19:41   
Branch CR23323 reviewed without remarks, ready for testing.
(0022279)
mkv   
2012-11-16 14:58   
Dear BugMaster,
Branch CR23323 (and master from occt GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
3rdparty export(001) A2 A3 A4 A6 A7
bugs demo(001) CR23410
bugs vis(004) CR23407_1 CR23407_2

chl 901 A9
chl 913 D4
chl 922 S6
chl 926 A1
chl 927 V8
chl 928 O5 R4
chl 929 E2
chl 934 C0 H1 O3 R5 V3 Z3
chl 941 B1 B6
chp 003 F3

Improvements:
Not detected

Testing cases:
Not needed

See results in /QADisk/occttests/results/KAS/dev/CR23323-master-products_15112012
See reference results in /QADisk/occttests/results/KAS/dev/IR-2012-11-09-IR-2012-11-09-products_10112012
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification [^]
(0022557)
aba   
2012-12-05 10:27   
The Git branch CR23323 was updated.

The flag 'IsInitialized' was added in Visual3d_View.pxx to check in Visual3d_View::SetViewOrientation() and Visual3d_View::ViewOrientationReset() methods whether the orientation matrix was counted or not.

Dear san, please review.
(0022595)
san   
2012-12-06 16:14   
Branch CR23323 reviewed without remarks, ready for testing.
(0022628)
mkv   
2012-12-07 17:55   
Dear BugMaster,
Branch CR23323 (and products from GIT master) was compiled on Linux and
Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed