MantisBT - Community
View Issue Details
0023311Community[OCCT] OCCT:Modeling Algorithmspublic2012-07-17 18:542012-11-16 13:17
Pawel 
Pawel 
normalminor 
closedfixed 
ALL
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023311: Duplicated check in if-clause in ChFi2d_Builder_0.cxx
In line 174 the variable 'adjEdge1' is checked twice.

 if (!IsLineOrCircle(adjEdge1,newFace)
      || !IsLineOrCircle(adjEdge1,newFace) ) {

According to the documentation building chamfer returns ChFi2d_NotAuthorized if "a curve other than a straight line or an arc of a circle is used as E, E1 or E2".

So the line should be corrected to:

if (!IsLineOrCircle(adjEdge1,newFace)
      || !IsLineOrCircle(adjEdge2,newFace) ) {
No tags attached.
Issue History
2012-07-17 18:54PawelNew Issue
2012-07-17 18:54PawelAssigned To => Pawel
2012-07-17 18:59PawelNote Added: 0021023
2012-07-17 18:59PawelAssigned ToPawel => bugmaster
2012-07-17 18:59PawelStatusnew => resolved
2012-07-18 07:54abvNote Added: 0021026
2012-07-18 07:54abvStatusresolved => reviewed
2012-07-18 15:57mkvAssigned Tobugmaster => mkv
2012-07-19 14:35mkvNote Added: 0021067
2012-07-19 14:35mkvTest case number => Not needed
2012-07-19 14:35mkvAssigned Tomkv => bugmaster
2012-07-19 14:35mkvStatusreviewed => tested
2012-07-23 12:20PawelChangeset attached => occt master 606a112a
2012-07-23 12:22PawelAssigned Tobugmaster => Pawel
2012-07-23 12:22PawelStatustested => verified
2012-07-23 12:22PawelResolutionopen => fixed
2012-11-16 13:14bugmasterFixed in Version => 6.5.4
2012-11-16 13:17bugmasterStatusverified => closed

Notes
(0021023)
Pawel   
2012-07-17 18:59   
Corresponding git branch pushed. Please review.
(0021026)
abv   
2012-07-18 07:54   
No remarks, please test
(0021067)
mkv   
2012-07-19 14:35   
Dear BugMaster,
The workbenches
KAS:dev:mkv-23311-occt (GIT branch CR23311)
KAS:dev:mkv-23311-products (GIT master)
were compiled on Linux platform and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed

See results in /QADisk/occttests/results/KAS/dev/mkv-23311-products_18072012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120706-opt_06072012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification [^]