MantisBT - Community
View Issue Details
0023309Community[OCCT] OCCT:Modeling Algorithmspublic2012-07-17 18:022013-04-29 15:23
Pawel 
emv 
normalminor 
closedfixed 
ALL
[OCCT] 6.5.3 
[OCCT] 6.6.0[OCCT] 6.6.0 
Not needed
0023309: The 'then' statement is equivalent to the 'else' statement in TopOpeBRep_EdgesFiller.cxx
In method TopOpeBRep_EdgesFiller::SetShapeTransition, line 348.

The else-if-action is equal to the else-action.

I'm not sure about the intention of the method so I just add it to the group of 'Suspicious ifs'.
No tags attached.
child of 0023132closed omy Suspicious code snippets 
Issue History
2012-07-17 18:02PawelNew Issue
2012-07-17 18:02PawelAssigned To => bugmaster
2012-07-17 18:02PawelRelationship addedchild of 0023132
2012-07-17 18:05PawelDescription Updatedbug_revision_view_page.php?rev_id=4069#r4069
2012-08-17 16:45bugmasterAssigned Tobugmaster => emv
2012-08-17 16:45bugmasterStatusnew => assigned
2012-10-23 17:09PawelSeverityjust a question => minor
2012-10-24 15:42abvTarget Version => 6.6.0
2013-03-12 12:01emvNote Added: 0023661
2013-03-12 12:01emvAssigned Toemv => abv
2013-03-12 12:01emvStatusassigned => resolved
2013-03-12 12:11abvAssigned Toabv => jgv
2013-03-12 12:12abvNote Added: 0023662
2013-03-12 18:33jgvNote Added: 0023689
2013-03-12 18:33jgvStatusresolved => reviewed
2013-03-12 19:39mkvAssigned Tojgv => mkv
2013-03-14 15:45mkvNote Added: 0023722
2013-03-14 15:45mkvTest case number => Not needed
2013-03-14 15:45mkvAssigned Tomkv => bugmaster
2013-03-14 15:45mkvStatusreviewed => tested
2013-03-18 20:48emvChangeset attached => occt master 8c720dc1
2013-03-18 20:48emvAssigned Tobugmaster => emv
2013-03-18 20:48emvStatustested => verified
2013-03-18 20:48emvResolutionopen => fixed
2013-04-23 13:35aivStatusverified => closed
2013-04-29 15:23aivFixed in Version => 6.6.0

Notes
(0023661)
emv   
2013-03-12 12:01   
Git branch CR23309 is ready to be reviewed.
(0023662)
abv   
2013-03-12 12:12   
My suspicion is that else-if clause might correspond to FACE-EDGE case
(0023689)
jgv   
2013-03-12 18:33   
Reviewed.
(0023722)
mkv   
2013-03-14 15:45   
Dear BugMaster,

Branch CR23309 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase.
SHA-1: 04ae5b2334417c38044ee6e273343fe19e52793c

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 242969116 / 243421964
Total CPU difference: 16724.459999999977 / 15476.330000000036

Testing on Windows:
Total MEMORY difference: 345993676 / 346193616
Total CPU difference: 16869.296875 / 21619.828125

There are not serious differences in images found by testdiff.