MantisBT - Community
View Issue Details
0023303Community[OCCT] OCCT:Modeling Algorithmspublic2012-07-17 16:152012-11-16 13:17
Pawel 
Pawel 
normalminor 
closedfixed 
ALL
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023303: Expression always true in ShapeFix_Face.cxx
In lines 591

if(iter.Value().Orientation() != TopAbs_FORWARD || iter.Value().Orientation() != TopAbs_REVERSED)

and 1704

(wi.Value().Orientation() != TopAbs_FORWARD || wi.Value().Orientation() != TopAbs_REVERSED))

the conditions are always true.

'||' should probably be replaced with '&&'.
No tags attached.
has duplicate 0023146closed bugmaster Community Suspicious if (4) 
Issue History
2012-07-17 16:15PawelNew Issue
2012-07-17 16:15PawelAssigned To => Pawel
2012-07-17 16:51PawelNote Added: 0021015
2012-07-17 16:51PawelAssigned ToPawel => bugmaster
2012-07-17 16:51PawelStatusnew => resolved
2012-07-17 16:57PawelRelationship addedhas duplicate 0023146
2012-07-18 08:13abvRelationship addedchild of 0013115
2012-07-18 08:14abvNote Added: 0021028
2012-07-18 08:14abvStatusresolved => reviewed
2012-07-18 15:31mkvAssigned Tobugmaster => mkv
2012-07-18 15:40mkvAssigned Tomkv => Pawel
2012-07-18 15:40mkvAssigned ToPawel => mkv
2012-07-19 14:28mkvNote Added: 0021065
2012-07-19 14:28mkvTest case number => Not needed
2012-07-19 14:28mkvAssigned Tomkv => bugmaster
2012-07-19 14:28mkvStatusreviewed => tested
2012-07-23 12:20PawelChangeset attached => occt master 56084216
2012-07-23 12:22PawelAssigned Tobugmaster => Pawel
2012-07-23 12:22PawelStatustested => verified
2012-07-23 12:22PawelResolutionopen => fixed
2012-11-16 13:14bugmasterFixed in Version => 6.5.4
2012-11-16 13:17bugmasterStatusverified => closed

Notes
(0021015)
Pawel   
2012-07-17 16:51   
Corresponding git branch pushed. Please review.

For the FixSmallAreaWire method the documentation says: "Detects wires with small area (that is less than 100*Precision::PConfusion(). Removes these wires if they are internal." The bugfix conforms to this.

For 'NeedCheckSplitWire' option in the Perform method the same assumption is made although no documentation on this could be found. Hence, it would be great if someone who is familiar with ShapeFix could have a look at this bugfix.
(0021028)
abv   
2012-07-18 08:14   
No remarks, please test
(0021065)
mkv   
2012-07-19 14:28   
Dear BugMaster,
The workbenches
KAS:dev:mkv-23303-occt (GIT branch CR23303)
KAS:dev:mkv-23303-products (GIT master)
were compiled on Linux platform and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed

See results in /QADisk/occttests/results/KAS/dev/mkv-23303-products_18072012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120706-opt_06072012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification [^]