MantisBT - Community
View Issue Details
0023289Community[OCCT] OCCT:Modeling Algorithmspublic2012-07-16 16:242012-11-16 13:18
Pawel 
aba 
normalminor 
closedfixed 
WindowsVC++ 200832 bit
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023289: IntCurve_IntPolyPolyGen.gxx, suspicious else
in lines 805:

if ((D1.LastParameter()-D1.FirstParameter()) > 0.5*(DeltaU))
    nbsamplesOnC1=(5*(nbsamplesOnC1*NbIter))/4;
      else
    nbsamplesOnC1=(5*(nbsamplesOnC1*NbIter))/4;

and 822:

 if ((D2.LastParameter()-D2.FirstParameter()) > 0.5*(DeltaV))
    nbsamplesOnC2=(5*(nbsamplesOnC2*NbIter))/4;
      else
    nbsamplesOnC2=(5*(nbsamplesOnC2*NbIter))/4;
No tags attached.
child of 0023132closed omy Suspicious code snippets 
Issue History
2012-07-16 16:24PawelNew Issue
2012-07-16 16:24PawelAssigned To => bugmaster
2012-07-16 16:25PawelRelationship addedchild of 0023132
2012-10-09 18:46oanAssigned Tobugmaster => aba
2012-10-09 18:46oanStatusnew => assigned
2012-10-17 15:05abaNote Added: 0021817
2012-10-17 15:07abaNote Added: 0021818
2012-10-17 15:07abaStatusassigned => resolved
2012-10-17 15:07abaAssigned Toaba => oan
2012-10-22 11:15oanNote Added: 0021874
2012-11-01 12:43oanAssigned Tooan => jgv
2012-11-06 13:29jgvAssigned Tojgv => aba
2012-11-06 13:32jgvNote Added: 0022097
2012-11-06 13:32jgvStatusresolved => assigned
2012-11-06 15:10abaNote Added: 0022102
2012-11-06 15:10abaAssigned Toaba => jgv
2012-11-06 15:10abaStatusassigned => resolved
2012-11-06 16:59jgvNote Added: 0022109
2012-11-06 16:59jgvStatusresolved => reviewed
2012-11-06 18:06mkvAssigned Tojgv => mkv
2012-11-07 17:10mkvNote Added: 0022137
2012-11-07 17:12mkvTest case number => Not needed
2012-11-07 17:12mkvAssigned Tomkv => bugmaster
2012-11-07 17:12mkvStatusreviewed => tested
2012-11-12 11:33abaChangeset attached => occt master 5d351552
2012-11-12 11:33abaAssigned Tobugmaster => aba
2012-11-12 11:33abaStatustested => verified
2012-11-12 11:33abaResolutionopen => fixed
2012-11-16 13:13bugmasterFixed in Version => 6.5.4
2012-11-16 13:18bugmasterStatusverified => closed

Notes
(0021817)
aba   
2012-10-17 15:05   
Conditional blocks in lines 805 and 822 were removed as lines 'nbsamplesOnC1=(5*(nbsamplesOnC1*NbIter))/4;' and 'nbsamplesOnC2=(5*(nbsamplesOnC2*NbIter))/4;' are executed in any case.
(0021818)
aba   
2012-10-17 15:07   
The git branch CR23289 is ready to be reviewed.

Dear oan, please review.
(0021874)
oan   
2012-10-22 11:15   
No comments.

Dear JGV,
Please review. Is it right to use the same equation in both cases or another coefficient should be used?
(0022097)
jgv   
2012-11-06 13:32   
Please find and correct another similar blocks where <nbsamples> is initialized by strange way.
(0022102)
aba   
2012-11-06 15:10   
Another strange initialization of 'nbsamples' variable was found in IntCurve_IntPolyPolyGen.gxx. The Git branch CR23289 was updated.
Dear jgv, please review.
(0022109)
jgv   
2012-11-06 16:59   
No remarks
(0022137)
mkv   
2012-11-07 17:10   
Dear BugMaster,
Branch CR23289 (and master from occt GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed