MantisBT - Community
View Issue Details
0023288Community[OCCT] OCCT:Modeling Algorithmspublic2012-07-16 16:162012-11-16 13:18
Pawel 
aba 
normalminor 
closedfixed 
WindowsVC++ 200832 bit
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023288: IntCurve_IntConicConic_1.cxx: if(A) {...} else if (A){...} pattern detected
In lines 200 and 244 occurs the same if-condition:

if(dO1O2 > AbsR1mR2-Tol)
No tags attached.
child of 0023132closed omy Suspicious code snippets 
Issue History
2012-07-16 16:16PawelNew Issue
2012-07-16 16:16PawelAssigned To => bugmaster
2012-07-16 16:17PawelRelationship addedchild of 0023132
2012-10-09 19:00oanAssigned Tobugmaster => aba
2012-10-09 19:01oanStatusnew => assigned
2012-10-12 15:49abaNote Added: 0021757
2012-10-12 15:52abaNote Added: 0021758
2012-10-12 15:53abaStatusassigned => resolved
2012-10-12 15:54abaAssigned Toaba => oan
2012-10-16 18:18oanNote Added: 0021807
2012-10-16 18:19oanAssigned Tooan => jgv
2012-10-19 15:15jgvNote Added: 0021852
2012-10-19 15:15jgvStatusresolved => reviewed
2012-10-23 15:48mkvAssigned Tojgv => mkv
2012-10-29 17:55mkvNote Added: 0021995
2012-10-29 17:55mkvTest case number => Not needed
2012-10-29 17:55mkvAssigned Tomkv => bugmaster
2012-10-29 17:55mkvStatusreviewed => assigned
2012-10-29 17:56mkvStatusassigned => resolved
2012-10-29 17:56mkvStatusresolved => reviewed
2012-10-29 17:56mkvStatusreviewed => tested
2012-11-06 19:02abaChangeset attached => occt master 80cead41
2012-11-06 19:03abaAssigned Tobugmaster => aba
2012-11-06 19:03abaStatustested => verified
2012-11-06 19:03abaResolutionopen => fixed
2012-11-16 13:13bugmasterFixed in Version => 6.5.4
2012-11-16 13:18bugmasterStatusverified => closed

Notes
(0021757)
aba   
2012-10-12 15:49   
In line 244 of IntCurve_IntConicConic_1.cxx there was unrealizable condition 'else if(dO1O2 > AbsR1mR2-Tol)'.
Previous condition block in line 200 covers two cases of circle intersection:
1) one circle contacts another one from inside,
2) one circle intersects another one.
(0021758)
aba   
2012-10-12 15:52   
The Git branch CR23288 is ready to be reviewed.
Dear oan, please review.
(0021807)
oan   
2012-10-16 18:18   
Dear JGV,
I have no comments.
Please consider consistency of the fix from your side.
(0021852)
jgv   
2012-10-19 15:15   
No remarks
(0021995)
mkv   
2012-10-29 17:55   
Dear BugMaster,
Branch CR23288 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed