MantisBT - Community
View Issue Details
0023147Community[OCCT] OCCT:Modeling Algorithmspublic2012-05-06 19:562012-11-16 13:18
QbProg 
omy 
normalminor 
closedfixed 
WindowsVC++ 201032 bit
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023147: Suspicious if (5)
The last one :)

src\GeomFill\GeomFill_NSections.cxx ,line 562 , line 568

if (j==jfin && vClosed)
if (j==jdeb && vClosed)

vClosed is assigned false and never reassigned.
No tags attached.
child of 0023132closed omy Suspicious code snippets 
Issue History
2012-05-06 19:56QbProgNew Issue
2012-05-06 19:56QbProgAssigned To => jgv
2012-05-07 09:19abvRelationship addedchild of 0023132
2012-05-07 09:22abvAssigned Tojgv => dbv
2012-05-07 09:22abvStatusnew => assigned
2012-05-07 09:23abvTarget Version => 6.5.4
2012-10-09 18:44oanAssigned Todbv => omy
2012-10-18 12:21omyAssigned Toomy => jgv
2012-10-18 12:21omyStatusassigned => resolved
2012-10-18 12:22omyNote Added: 0021830
2012-10-18 12:44PawelNote Added: 0021831
2012-10-18 14:21omyNote Added: 0021832
2012-10-22 11:39jgvNote Added: 0021877
2012-10-22 11:39jgvStatusresolved => reviewed
2012-10-23 16:08mkvAssigned Tojgv => mkv
2012-10-24 10:38mkvNote Added: 0021914
2012-10-24 10:39mkvTest case number => Not needed
2012-10-24 10:39mkvAssigned Tomkv => omy
2012-10-24 10:39mkvStatusreviewed => assigned
2012-10-25 12:14omyNote Added: 0021937
2012-10-25 12:14omyAssigned Toomy => mkv
2012-10-25 12:14omyStatusassigned => resolved
2012-10-25 12:55abvStatusresolved => reviewed
2012-10-30 11:19apnNote Added: 0022005
2012-10-30 11:20apnAssigned Tomkv => bugmaster
2012-10-30 11:20apnStatusreviewed => tested
2012-11-06 19:02omyChangeset attached => occt master 9046e4fc
2012-11-06 19:03omyAssigned Tobugmaster => omy
2012-11-06 19:03omyStatustested => verified
2012-11-06 19:03omyResolutionopen => fixed
2012-11-16 13:13bugmasterFixed in Version => 6.5.4
2012-11-16 13:18bugmasterStatusverified => closed

Notes
(0021830)
omy   
2012-10-18 12:22   
Dear JGV,
Fix is integrated to branch CR23147 (see commit message for details). Please review.
(0021831)
Pawel   
2012-10-18 12:44   
Dear omy,

in the proposed solution in line 536 there is an 'else' without the corresponding 'if'. Please, have a look at it. Thank you.

Pawel
(0021832)
omy   
2012-10-18 14:21   
Dear Pawel,

I've fixed the mistake. Thank you for finding it.
(0021877)
jgv   
2012-10-22 11:39   
No remarks
(0021914)
mkv   
2012-10-24 10:38   
Dear BugMaster,
Branch CR23147 (and products from GIT master) was compiled on Linux and Windows platforms.
There is compilation error on Linux platform:
http://jenkins-test-01.nnov.opencascade.com/user/mnt/my-views/view/CR23147/job/mnt-CR23147-master_build_occt_linux/1/parsed_console/? [^]
../../../src/GeomFill/GeomFill_NSections.cxx: In member function 'void GeomFill_NSections::ComputeSurface()':
../../../src/GeomFill/GeomFill_NSections.cxx:557: error: 's2Point' was not declared in this scope
make[2]: *** [GeomFill_NSections.lo] Error 1
(0021937)
omy   
2012-10-25 12:14   
Dear MKV,
I've fixed this error. Please, test
(0022005)
apn   
2012-10-30 11:19   
Dear BugMaster,
Branch CR23147 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed