MantisBT - Community
View Issue Details
0023145Community[OCCT] OCCT:Modeling Algorithmspublic2012-05-06 19:502012-11-16 13:18
QbProg 
ika 
normalminor 
closedfixed 
WindowsVC++ 201032 bit
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023145: Suspicious else (2)
src\LocalAnalysis\LocalAnalysis_SurfaceContinuity.cxx , LocalAnalysis_SurfaceContinuity::SurfC1

There are two if/else that have the same behavoir.

if (norm1v >= norm2v )
        myLambda1V= norm2v / norm1v;
else myLambda1V = norm2v / norm1v;
(... and another below)
No tags attached.
child of 0023132closed omy Suspicious code snippets 
Issue History
2012-05-06 19:50QbProgNew Issue
2012-05-06 19:50QbProgAssigned To => jgv
2012-05-07 09:18abvRelationship addedchild of 0023132
2012-05-07 09:25abvAssigned Tojgv => dbv
2012-05-07 09:25abvStatusnew => assigned
2012-05-07 09:26abvTarget Version => 6.5.4
2012-10-09 18:40oanAssigned Todbv => ika
2012-10-16 18:16ikaNote Added: 0021806
2012-10-16 18:17ikaStatusassigned => resolved
2012-10-16 18:17ikaAssigned Toika => oan
2012-10-16 19:59oanAssigned Tooan => jgv
2012-10-16 19:59oanNote Added: 0021810
2012-10-19 16:03jgvNote Added: 0021856
2012-10-19 16:03jgvStatusresolved => reviewed
2012-10-23 15:57mkvAssigned Tojgv => mkv
2012-10-29 18:10mkvNote Added: 0021996
2012-10-29 18:11mkvTest case number => Not needed
2012-10-29 18:11mkvAssigned Tomkv => bugmaster
2012-10-29 18:11mkvStatusreviewed => tested
2012-11-06 19:02ikaChangeset attached => occt master 9a79c952
2012-11-06 19:03ikaAssigned Tobugmaster => ika
2012-11-06 19:03ikaStatustested => verified
2012-11-06 19:03ikaResolutionopen => fixed
2012-11-16 13:13bugmasterFixed in Version => 6.5.4
2012-11-16 13:18bugmasterStatusverified => closed

Notes
(0021806)
ika   
2012-10-16 18:16   
Else statement was incorrect, is has been changed.

Git branch CR23145 is ready to be reviewed.

Dear Oleg,
Please review.
(0021810)
oan   
2012-10-16 19:59   
Dear JGV,
Please review.
(0021856)
jgv   
2012-10-19 16:03   
No remarks
(0021996)
mkv   
2012-10-29 18:10   
Dear BugMaster,
Branch CR23145 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed