MantisBT - Community
View Issue Details
0023144Community[OCCT] OCCT:Modeling Algorithmspublic2012-05-06 19:472013-04-29 15:21
QbProg 
omy 
normalminor 
closedfixed 
WindowsVC++ 201032 bit
[OCCT] 6.5.3 
[OCCT] 6.6.0[OCCT] 6.6.0 
Not needed
0023144: Suspicious if (3)
inc\intpatch_impimpintersection_5.gxx , line 111

if (aR1>aR1)

if always false?


No tags attached.
child of 0023132closed omy Suspicious code snippets 
Issue History
2012-05-06 19:47QbProgNew Issue
2012-05-06 19:47QbProgAssigned To => abv
2012-05-07 09:18abvRelationship addedchild of 0023132
2012-05-07 09:27abvAssigned Toabv => dbv
2012-05-07 09:27abvStatusnew => assigned
2012-05-07 09:27abvCategoryOCCT:Foundation Classes => OCCT:Modeling Algorithms
2012-05-07 09:27abvTarget Version => 6.5.4
2012-10-09 18:37oanAssigned Todbv => omy
2012-10-12 18:45omyNote Added: 0021762
2012-10-12 18:46omyAssigned Toomy => oan
2012-10-12 18:47omyStatusassigned => resolved
2012-10-16 12:41oanNote Added: 0021790
2012-10-16 12:41oanAssigned Tooan => omy
2012-10-16 12:41oanStatusresolved => reviewed
2012-10-16 12:43oanStatusreviewed => assigned
2012-10-18 10:53omyNote Added: 0021829
2012-10-18 10:53omyStatusassigned => resolved
2012-10-18 10:54omyAssigned Toomy => oan
2012-10-22 09:46oanAssigned Tooan => jgv
2012-10-22 09:47oanNote Added: 0021869
2012-10-22 13:52jgvNote Added: 0021880
2012-10-22 13:52jgvStatusresolved => reviewed
2012-10-23 09:54abvTarget Version6.5.4 => 6.6.0
2012-10-23 16:17mkvAssigned Tojgv => mkv
2012-10-31 18:25apnNote Added: 0022037
2012-10-31 18:26apnTest case number => Not needed
2012-10-31 18:26apnAssigned Tomkv => bugmaster
2012-10-31 18:26apnStatusreviewed => tested
2012-11-16 13:03omyChangeset attached => occt master 8f905bca
2012-11-16 13:03omyAssigned Tobugmaster => omy
2012-11-16 13:03omyStatustested => verified
2012-11-16 13:03omyResolutionopen => fixed
2012-12-10 17:16omyChangeset attached => occt master 8f905bca
2013-04-23 13:36aivStatusverified => closed
2013-04-29 15:21aivFixed in Version => 6.6.0

Notes
(0021762)
omy   
2012-10-12 18:45   
Dear oan,
Fix is integrated to branch CR23144 (see commit message for details). Please review.
(0021790)
oan   
2012-10-16 12:41   
Dear OMY,
the case when result of intersection is IntAna_Line and number of solutions equals one is possible when apices of the given cones are coincident.

If second cone is inside the first, the distance between a point laying on intersection line and line which direction consides with axis of second cone should be less than distance between described point and line of the first cone. So, I guess that aR1 > aR2 is the right solution, isn't it?

Could you please perform detail check in touch of these statements?
(0021829)
omy   
2012-10-18 10:53   
Dear OAN,
You are correct in your suggestion. I've fixed it. Please, review.
(0021869)
oan   
2012-10-22 09:47   
Dear JGV,
please review the changes
(0021880)
jgv   
2012-10-22 13:52   
No remarks
(0022037)
apn   
2012-10-31 18:25   
Dear BugMaster,
Branch CR23144 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed