MantisBT - Community
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023142Community[OCCT] OCCT:Modeling Algorithmspublic2012-05-06 19:422013-04-29 15:21
ReporterQbProg 
Assigned Toika 
PrioritynormalSeverityminor 
StatusclosedResolutionfixed 
PlatformWindowsOSVC++ 2010OS Version32 bit
Product Version[OCCT] 6.5.3 
Target Version[OCCT] 6.6.0Fixed in Version[OCCT] 6.6.0 
Test case numberNot needed
Summary0023142: GccAna : suspicious else
Descriptionsrc\GccAna\GccAna_Circ2d2TanRad.cxx , line 474

if (R1 < R2) { signe = -1; }
else { signe = -1; }

probably the else should be signe = +1 ?

but I'm not sure.
Steps To Reproduce
Additional information
and documentation updates
TagsNo tags attached.
Relationships
child of 0023132closed omy Suspicious code snippets 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-05-06 19:42QbProgNew Issue
2012-05-06 19:42QbProgAssigned To => abv
2012-05-07 09:17abvRelationship addedchild of 0023132
2012-05-07 09:29abvAssigned Toabv => dbv
2012-05-07 09:29abvStatusnew => assigned
2012-05-07 09:30abvCategoryOCCT:Foundation Classes => OCCT:Modeling Algorithms
2012-05-07 09:30abvTarget Version => 6.5.4
2012-10-09 18:33oanAssigned Todbv => ika
2012-10-11 16:50ikaNote Added: 0021730
2012-10-11 16:50ikaAssigned Toika => oan
2012-10-12 18:51oanStatusassigned => resolved
2012-10-16 18:15oanNote Added: 0021804
2012-10-16 18:15oanAssigned Tooan => jgv
2012-10-19 15:04jgvNote Added: 0021851
2012-10-19 15:04jgvStatusresolved => reviewed
2012-10-23 15:47mkvAssigned Tojgv => mkv
2012-10-23 18:41abvTarget Version6.5.4 => 6.6.0
2012-10-31 11:53apnNote Added: 0022028
2012-10-31 11:53apnTest case number => Not needed
2012-10-31 11:53apnAssigned Tomkv => bugmaster
2012-10-31 11:53apnStatusreviewed => tested
2012-11-16 13:03ikaChangeset attached => occt master 33a08553
2012-11-16 13:03ikaAssigned Tobugmaster => ika
2012-11-16 13:03ikaStatustested => verified
2012-11-16 13:03ikaResolutionopen => fixed
2012-12-10 17:16ikaChangeset attached => occt master 33a08553
2013-04-23 13:36aivStatusverified => closed
2013-04-29 15:21aivFixed in Version => 6.6.0

Notes
(0021730)
ika   
2012-10-11 16:50   
Yes, the else should be signe = +1, I have fixed this issue.

Git branch CR23142 is ready to be reviewed.

Dear Oleg,
Please review.
(0021804)
oan   
2012-10-16 18:15   
Dear JGV,
Could you please review the fix?
(0021851)
jgv   
2012-10-19 15:04   
No remarks
(0022028)
apn   
2012-10-31 11:53   
Dear BugMaster,
Branch CR23142 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed