MantisBT - Community
View Issue Details
0023140Community[OCCT] OCCT:Modeling Algorithmspublic2012-05-06 19:382012-11-16 13:18
QbProg 
aba 
normalminor 
closedfixed 
WindowsVC++ 201032 bit
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023140: Suspicious if
src\BRepFill\BRepFill_TrimEdgeTool.cxx , line 0000183

if(AC.GetType() != GeomAbs_Circle || AC.GetType() != GeomAbs_Line) {
    Tol *= 100.;
  }

Condition is always true, I don't know if the original intention was to agument the tolerance only for cicle and lines, or the opposite
No tags attached.
child of 0023132closed omy Suspicious code snippets 
Issue History
2012-05-06 19:38QbProgNew Issue
2012-05-06 19:38QbProgAssigned To => jgv
2012-05-07 09:16abvRelationship addedchild of 0023132
2012-05-07 09:31abvAssigned Tojgv => dbv
2012-05-07 09:31abvStatusnew => assigned
2012-05-07 09:31abvTarget Version => 6.5.4
2012-10-09 18:35oanAssigned Todbv => aba
2012-10-17 10:45abaNote Added: 0021812
2012-10-17 10:45abaStatusassigned => resolved
2012-10-17 10:46abaAssigned Toaba => oan
2012-10-22 09:55oanNote Added: 0021870
2012-10-22 09:56oanAssigned Tooan => jgv
2012-10-23 15:54jgvNote Added: 0021906
2012-10-23 15:54jgvStatusresolved => reviewed
2012-10-23 16:24mkvAssigned Tojgv => mkv
2012-10-30 11:12apnNote Added: 0022004
2012-10-30 11:12apnTest case number => Not needed
2012-10-30 11:12apnAssigned Tomkv => bugmaster
2012-10-30 11:12apnStatusreviewed => tested
2012-11-06 19:02abaChangeset attached => occt master 5768cd55
2012-11-06 19:03abaAssigned Tobugmaster => aba
2012-11-06 19:03abaStatustested => verified
2012-11-06 19:03abaResolutionopen => fixed
2012-11-16 13:13bugmasterFixed in Version => 6.5.4
2012-11-16 13:18bugmasterStatusverified => closed

Notes
(0021812)
aba   
2012-10-17 10:45   
Condition that is always true was replaced with assigning a variable 'Tol' to Precision::Confusion().

The Git branch CR23140 is ready to be reviewed.
Dear oan, please review.
(0021870)
oan   
2012-10-22 09:55   
Dear JGV,
please review.
(0021906)
jgv   
2012-10-23 15:54   
No remarks
(0022004)
apn   
2012-10-30 11:12   
Dear BugMaster,
Branch CR23140 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed