MantisBT - Community | | View Issue Details |
| | ID | Project | Category | View Status | Date Submitted | Last Update | | 0023140 | Community | [OCCT] OCCT:Modeling Algorithms | public | 2012-05-06 19:38 | 2012-11-16 13:18 |
| | Reporter | QbProg | | | Assigned To | aba | | | Priority | normal | Severity | minor | | | Status | closed | Resolution | fixed | | | Platform | Windows | OS | VC++ 2010 | OS Version | 32 bit | | Product Version | [OCCT] 6.5.3 | | | Target Version | [OCCT] 6.5.4 | Fixed in Version | [OCCT] 6.5.4 | | | Test case number | Not needed |
| | Summary | 0023140: Suspicious if | | Description | src\BRepFill\BRepFill_TrimEdgeTool.cxx , line 0000183
if(AC.GetType() != GeomAbs_Circle || AC.GetType() != GeomAbs_Line) {
Tol *= 100.;
}
Condition is always true, I don't know if the original intention was to agument the tolerance only for cicle and lines, or the opposite | | Steps To Reproduce | | Additional information
and documentation updates | | | Tags | No tags attached. | | Relationships | | child of | 0023132 | closed | omy | Suspicious code snippets |
| | Attached Files | |
| | Issue History | | Date Modified | Username | Field | Change | | 2012-05-06 19:38 | QbProg | New Issue | | | 2012-05-06 19:38 | QbProg | Assigned To | => jgv | | 2012-05-07 09:16 | abv | Relationship added | child of 0023132 | | 2012-05-07 09:31 | abv | Assigned To | jgv => dbv | | 2012-05-07 09:31 | abv | Status | new => assigned | | 2012-05-07 09:31 | abv | Target Version | => 6.5.4 | | 2012-10-09 18:35 | oan | Assigned To | dbv => aba | | 2012-10-17 10:45 | aba | Note Added: 0021812 | | | 2012-10-17 10:45 | aba | Status | assigned => resolved | | 2012-10-17 10:46 | aba | Assigned To | aba => oan | | 2012-10-22 09:55 | oan | Note Added: 0021870 | | | 2012-10-22 09:56 | oan | Assigned To | oan => jgv | | 2012-10-23 15:54 | jgv | Note Added: 0021906 | | | 2012-10-23 15:54 | jgv | Status | resolved => reviewed | | 2012-10-23 16:24 | mkv | Assigned To | jgv => mkv | | 2012-10-30 11:12 | apn | Note Added: 0022004 | | | 2012-10-30 11:12 | apn | Test case number | => Not needed | | 2012-10-30 11:12 | apn | Assigned To | mkv => bugmaster | | 2012-10-30 11:12 | apn | Status | reviewed => tested | | 2012-11-06 19:02 | aba | Changeset attached | => occt master 5768cd55 | | 2012-11-06 19:03 | aba | Assigned To | bugmaster => aba | | 2012-11-06 19:03 | aba | Status | tested => verified | | 2012-11-06 19:03 | aba | Resolution | open => fixed | | 2012-11-16 13:13 | bugmaster | Fixed in Version | => 6.5.4 | | 2012-11-16 13:18 | bugmaster | Status | verified => closed |
|
Notes |
|
|
(0021812)
|
|
aba
|
|
2012-10-17 10:45
|
|
Condition that is always true was replaced with assigning a variable 'Tol' to Precision::Confusion().
The Git branch CR23140 is ready to be reviewed.
Dear oan, please review. |
|
|
|
(0021870)
|
|
oan
|
|
2012-10-22 09:55
|
|
|
|
|
(0021906)
|
|
jgv
|
|
2012-10-23 15:54
|
|
|
|
|
(0022004)
|
|
apn
|
|
2012-10-30 11:12
|
|
Dear BugMaster,
Branch CR23140 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
Regression:
Not detected
Improvements:
Not detected
Testing case:
Not needed |
|
|