MantisBT - Community
View Issue Details
0023098Community[OCCT] OCCT:Configurationpublic2012-04-11 15:432012-11-16 13:18
Pawel 
dbv 
normalminor 
closedfixed 
WindowsVC++ 200832 bit
[OCCT] 6.5.3 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023098: Cppcheck warnings/errors in QA files
There are multiple QAxxx files in the distribution that can be pulled from the server. I assume they are some quality assurance routines bur wasn't sure about that.

Cppcheck 1.53 diagnoses multiple problems within those file.

As I don't know how to compile the files I attach a screenshot with the cppcheck report.
No tags attached.
has duplicate 0023266closed ika cppcheck warning: Logical disjunction always evaluates to true 
png cppcheck_QA_problems.png (54,382) 2012-04-11 15:43
https://tracker.dev.opencascade.org/
? D1 (569) 2012-10-08 14:17
https://tracker.dev.opencascade.org/
Issue History
2012-04-11 15:43PawelNew Issue
2012-04-11 15:43PawelAssigned To => bugmaster
2012-04-11 15:43PawelFile Added: cppcheck_QA_problems.png
2012-04-11 19:58abvAssigned Tobugmaster => dbv
2012-04-11 19:58abvStatusnew => assigned
2012-06-22 13:23dbvNote Added: 0020762
2012-06-22 13:23dbvAssigned Todbv => abv
2012-06-22 13:23dbvStatusassigned => resolved
2012-06-22 18:29abvNote Added: 0020772
2012-06-22 18:29abvAssigned Toabv => dbv
2012-06-22 18:29abvStatusresolved => assigned
2012-10-03 18:58dbvNote Added: 0021647
2012-10-03 18:58dbvAssigned Todbv => abv
2012-10-03 18:58dbvStatusassigned => resolved
2012-10-03 19:07abvNote Added: 0021648
2012-10-03 19:07abvAssigned Toabv => bugmaster
2012-10-03 19:07abvStatusresolved => reviewed
2012-10-04 11:59PawelRelationship addedhas duplicate 0023266
2012-10-04 12:36mkvAssigned Tobugmaster => mkv
2012-10-05 12:11mkvNote Added: 0021666
2012-10-05 12:13mkvTest case number => Not needed
2012-10-05 12:13mkvAssigned Tomkv => dbv
2012-10-05 12:13mkvStatusreviewed => assigned
2012-10-05 13:26dbvNote Added: 0021668
2012-10-05 13:26dbvAssigned Todbv => abv
2012-10-05 13:26dbvStatusassigned => resolved
2012-10-05 14:29abvNote Added: 0021671
2012-10-05 14:29abvAssigned Toabv => bugmaster
2012-10-05 14:29abvStatusresolved => reviewed
2012-10-05 18:03mkvAssigned Tobugmaster => mkv
2012-10-08 14:13mkvNote Added: 0021677
2012-10-08 14:17mkvFile Added: D1
2012-10-08 14:20mkvAssigned Tomkv => dbv
2012-10-08 14:20mkvStatusreviewed => assigned
2012-10-08 14:55mkvNote Edited: 0021677bug_revision_view_page.php?bugnote_id=21677#r4314
2012-10-09 11:46dbvNote Added: 0021692
2012-10-09 11:46dbvStatusassigned => resolved
2012-10-09 11:46dbvAssigned Todbv => abv
2012-10-09 20:53abvNote Added: 0021703
2012-10-09 20:53abvStatusresolved => reviewed
2012-10-10 18:49mkvAssigned Toabv => mkv
2012-10-12 12:31mkvNote Added: 0021746
2012-10-12 12:32mkvAssigned Tomkv => bugmaster
2012-10-12 12:32mkvStatusreviewed => tested
2012-10-16 15:21dbvChangeset attached => occt master f1e162f2
2012-10-16 15:21dbvAssigned Tobugmaster => dbv
2012-10-16 15:21dbvStatustested => verified
2012-10-16 15:21dbvResolutionopen => fixed
2012-10-24 17:08abvTarget Version => 6.5.4
2012-11-16 13:14bugmasterFixed in Version => 6.5.4
2012-11-16 13:18bugmasterStatusverified => closed
2014-01-11 11:58abvCategoryOCCT:Development Environment => OCCT:Configuration

Notes
(0020762)
dbv   
2012-06-22 13:23   
The first two errors relate to accesses violation test and divide by zero test, respectively. So, it is normal that Cppcheck reports them. All other listed error has been fixed.

Git branch CR23098 is ready to be reviewed.

Dear Andrey,
Please review.
(0020772)
abv   
2012-06-22 18:29   
In QABugs_3.cxx, line 229 still contains delete without []. Please revise the code around: it has no sense (I guess unreacheable code warning should be reported). I suggest this function should accept complete path instead of trying to construct it with use of environment variable; this will eliminate the need to allocate the memory and its consequences.

In QADNaming_IteratorsCommands.cxx, please use either TCollection_AsciiString or automatic variable.

In QANewModTopOpe.cxx, why not reverting to use of math_Mat which is there but commented out?

In QANewDBRepNaming_FeatureCommands.cxx: is the command under question used in tests? it seems it should never work before... The same is worth to be checked for all other commands.
(0021647)
dbv   
2012-10-03 18:58   
Remarks have been fixed.

Branch has been rebased and pushed to the git CR23098_1

Dear Andrey,
Please review.
(0021648)
abv   
2012-10-03 19:07   
No remarks, please test
(0021666)
mkv   
2012-10-05 12:11   
Dear BugMaster,
Branch CR23098_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
chl 902 D1
nam 001 A2

Improvements:
Not detected

Testing cases:
Not needed

See results in /QADisk/occttests/results/KAS/dev/CR23098-master-products_04102012/lin
See reference results in /QADisk/occttests/results/KAS/dev/IR-2012-09-27-master-products_27092012/lin
See test cases in /QADisk/occttests/tests/ED
(0021668)
dbv   
2012-10-05 13:26   
Dear mkv,

Function BUC60609 from src/QABugs/QABugs_3.cxx now accept full path to the file instead of constructing it from environment variable. Thus test case chl 902 D1 should be modified.

Regression nam 001 A2 has been fixed.

Dear Andrey,
Please review.
(0021671)
abv   
2012-10-05 14:29   
No remarks (sorry for oversight!), please test
(0021677)
mkv   
2012-10-08 14:13   
(edited on: 2012-10-08 14:55)
Dear BugMaster,
Branch CR23098_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
nam 001 A2

Improvements:
Not detected

Testing cases:
Not needed

See results in /QADisk/occttests/results/KAS/dev/CR23098-master-2-products_05102012/lin
See reference results in /QADisk/occttests/results/KAS/dev/IR-2012-09-27-master-products_27092012/lin
See test cases in /QADisk/occttests/tests/ED

Test case chl 902 D1 will be modified after raising this fix.

(0021692)
dbv   
2012-10-09 11:46   
Regression fixed.

Please review.

(0021703)
abv   
2012-10-09 20:53   
No remarks, please test
(0021746)
mkv   
2012-10-12 12:31   
Dear BugMaster,
Branch CR23098_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed

See results in /QADisk/occttests/results/KAS/dev/CR23098-master-2-products_05102012/lin
See reference results in /QADisk/occttests/results/KAS/dev/IR-2012-09-27-master-products_27092012/lin
See test cases in /QADisk/occttests/tests/ED

Test case chl 902 D1 will be modified after raising this fix.