MantisBT - Community
View Issue Details
0023086Community[OCCT] OCCT:Application Frameworkpublic2012-04-06 15:452012-11-16 13:17
szy 
szy 
normalmajor 
closedfixed 
[OCCT] 6.5.2 
[OCCT] 6.5.4[OCCT] 6.5.4 
Not needed
0023086: OCC 6.5.2 DNaming bug
Post from the Forum [Valeriu Catina] - http://www.opencascade.org/org/forum/thread_23075/ [^] .
"...
in package TKDCAF, module DNaming, file DNaming_TransformationDriver.cxx, function LoadNamingDS contains code similar to:

---

TNaming_Builder* pB1;

// ... irrelevant code

if(aF) {
const TDF_Label& aFLabel = theResultLabel.FindChild(FACES_TAG, Standard_True);
TNaming_Builder aFBuilder(aFLabel);
pB1 = &aFBuilder
aF = Standard_False;
}
// ... irrelevant code
pB1->Modify(anIt.Key(), newShape);

---

pB1 takes the address of a temporary (aFBuilder in our case). As aFBuilder is destroyed at the end of the if block pB1 is invalid when pB1->Modify(anIt.Key(), newShape) is reached."
No tags attached.
has duplicate 0023355closed bugmaster Community Pointer to local variable 'TNaming_Builder' is stored outside the scope of this variable. Such a pointer will become invalid. 
related to 0021977closed szy Open CASCADE Unsafe implementation of TNaming_Builder 
Issue History
2012-04-06 15:45szyNew Issue
2012-04-06 15:45szyAssigned To => szy
2012-04-11 19:47szyNote Added: 0020340
2012-04-11 19:47szyAssigned Toszy => vro
2012-04-11 19:47szyStatusnew => resolved
2012-04-11 19:52abvNote Added: 0020341
2012-04-12 10:24vroNote Added: 0020349
2012-04-12 10:24vroAssigned Tovro => mkv
2012-04-12 10:24vroStatusresolved => reviewed
2012-04-12 10:27szyNote Added: 0020350
2012-04-12 11:02szyTarget Version6.5.4 => 6.5.3
2012-04-12 11:02apnAssigned Tomkv => apn
2012-04-12 11:02apnDescription Updatedbug_revision_view_page.php?rev_id=3810#r3810
2012-04-12 11:54mkvTest case number => Not needed
2012-04-13 14:50mkvNote Added: 0020383
2012-04-13 14:50mkvAssigned Toapn => bugmaster
2012-04-13 14:50mkvStatusreviewed => tested
2012-04-26 18:47abvTarget Version6.5.3 => 6.5.4
2012-04-26 18:47abvAssigned Tobugmaster => abv
2012-04-26 18:47abvStatustested => feedback
2012-08-17 16:55abvRelationship addedhas duplicate 0023355
2012-08-17 17:25szyNote Edited: 0020350bug_revision_view_page.php?bugnote_id=20350#r4156
2012-09-07 09:34abvRelationship addedrelated to 0021977
2012-09-07 09:51abvNote Added: 0021427
2012-09-07 09:51abvAssigned Toabv => szy
2012-09-07 09:51abvStatusfeedback => resolved
2012-09-07 14:19szyNote Added: 0021433
2012-09-07 14:19szyStatusresolved => reviewed
2012-09-07 16:00szyAssigned Toszy => mkv
2012-09-13 14:56apnNote Added: 0021477
2012-09-13 14:56apnAssigned Tomkv => bugmaster
2012-09-13 14:56apnStatusreviewed => tested
2012-09-17 17:29szyChangeset attached => occt master d4832c3e
2012-09-17 17:34szyAssigned Tobugmaster => szy
2012-09-17 17:34szyStatustested => verified
2012-09-17 17:34szyResolutionopen => fixed
2012-11-16 13:14bugmasterFixed in Version => 6.5.4
2012-11-16 13:17bugmasterStatusverified => closed

Notes
(0020340)
szy   
2012-04-11 19:47   
Fixed in branch CR23086.
Review, please.
(0020341)
abv   
2012-04-11 19:52   
Please provide meaningful description of the change made
(0020349)
vro   
2012-04-12 10:24   
The changes are Ok.
(0020350)
szy   
2012-04-12 10:27   
(edited on: 2012-08-17 17:25)
Technical solution: static TNaming_Buildrer is replaced by corresponding pair [new, delete]. Dynamic management of the Builder creation/deletion is added.

(0020383)
mkv   
2012-04-13 14:50   
Dear BugMaster,
Workbench KAS:dev:apn-23086-occt was created from git branch CR23086
(and apn-23086-products from svn trunk) and compiled on Linux platform.

There are not regressions in apn-23086-products regarding to KAS:dev:products-20120406-opt
There are not improvements in apn-23086-products regarding to KAS:dev:products-20120406-opt

See results in /QADisk/occttests/results/KAS/dev/apn-23086-products_12042012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120406-opt_07042012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification [^]
(0021427)
abv   
2012-09-07 09:51   
The alternative implementation of the fix (using Handles instead of plain C pointers) is integrated to the same-name branch CR23086; please review
(0021433)
szy   
2012-09-07 14:19   
Reviewed. It's Ok.
(0021477)
apn   
2012-09-13 14:56   
Dear BugMaster,
Branch CR23086 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed