MantisBT - Open CASCADE
View Issue Details
0022974Open CASCADE[OCCT] OCCT:Visualizationpublic2012-02-02 13:582014-05-05 13:38
vro 
aba 
lowminor 
closedfixed 
WindowsVC++ 200532 bit
[OCCT] 6.5.0 
[OCCT] 6.7.1[OCCT] 6.7.1 
No opportunity to create test case
0022974: A crash on dragging a dimension for an object with a big coordinate
A diameter or a radius dimension crashes on attempt to drag it if a coordinate of the dimension is very great, for example X = 1e18 mm.
A scenario to reproduce:
1. Create a circle with radius = 1 and X = 1e18;
2. Display a diameter or a radius dimension in the viewer 3d;
3. Drag the dimension by mouse -> Crash.

The test case for diameter and radius dimensions:

vpoint p1 0 0 30
vpoint p2 30 0 0
vpoint p3 60 0 30
vcircle circle p1 p2 p3 0
# create radius dimension
vdimension radius name=dim circle
# For diameter dimension use command below
#vdimension diameter name=dim circle

vdisplay dim

vzoom 0.05
vpan -150 150

vmovedim dim
# press ctrl and press new text position
vfit
No tags attached.
parent of 0023159closed vro Community Draw commands vradiusdim and vdiameterdim on Linux don't work (crash) 
Issue History
2012-02-02 13:58vroNew Issue
2012-02-02 13:58vroAssigned To => vro
2012-02-02 15:15vroNote Added: 0019359
2012-02-02 15:15vroAssigned Tovro => kgv
2012-02-02 15:15vroStatusnew => resolved
2012-02-02 16:47kgvNote Added: 0019363
2012-02-02 16:47kgvAssigned Tokgv => bugmaster
2012-02-02 16:47kgvStatusresolved => reviewed
2012-02-07 13:28apnNote Added: 0019432
2012-02-07 15:29apnNote Edited: 0019432bug_revision_view_page.php?bugnote_id=19432#r3398
2012-02-07 15:30apnTest case number => No opportunity to create test case
2012-02-07 15:30apnStatusreviewed => tested
2012-02-10 17:34bugmasterNote Added: 0019519
2012-02-22 11:31bugmasterNote Added: 0019716
2012-02-22 11:31bugmasterAssigned Tobugmaster => vro
2012-02-22 11:31bugmasterStatustested => feedback
2012-02-22 11:35vroNote Added: 0019718
2012-02-22 11:35vroStatusfeedback => assigned
2012-02-22 16:13sanNote Added: 0019737
2012-03-12 07:40abvNote Added: 0019922
2012-03-12 07:40abvStatusassigned => feedback
2012-03-14 10:21vroNote Added: 0019963
2012-03-14 10:21vroStatusfeedback => assigned
2012-03-14 10:21vroAssigned Tovro => bugmaster
2012-03-14 10:21vroStatusassigned => resolved
2012-05-12 17:17mkvAssigned Tobugmaster => abv
2012-05-12 17:29abvNote Added: 0020522
2012-05-12 17:29abvAssigned Toabv => vro
2012-05-12 17:29abvStatusresolved => assigned
2012-05-14 12:13vroNote Added: 0020525
2012-05-14 12:14vroAssigned Tovro =>
2012-05-14 12:14vroAssigned To => abv
2012-05-14 12:15vroNote Added: 0020526
2012-05-14 15:10vroStatusassigned => resolved
2012-05-14 15:14abvNote Added: 0020528
2012-05-14 15:14abvAssigned Toabv => vro
2012-05-14 15:14abvStatusresolved => reviewed
2012-05-14 16:58apnAssigned Tovro => apn
2012-05-15 12:06apnNote Added: 0020535
2012-05-15 12:07apnAssigned Toapn => vro
2012-05-15 12:07apnStatusreviewed => assigned
2012-05-16 10:11vroNote Added: 0020538
2012-05-16 16:26vroRelationship addedparent of 0023159
2012-05-31 09:42abvTarget Version6.5.3 => 6.5.4
2012-05-31 09:43vroNote Added: 0020616
2012-09-03 09:18vroAssigned Tovro => san
2012-10-02 14:56bugmasterProjectInternal => Open CASCADE
2012-10-21 11:41abvTarget Version6.5.4 => 6.6.0
2013-02-26 18:43sanTarget Version6.6.0 => 6.7.0
2013-04-18 15:10vroNote Added: 0024207
2013-04-18 15:39abvNote Added: 0024208
2013-11-28 16:16sanRelationship addedrelated to 0024412
2013-11-28 16:17sanTarget Version6.7.0 => 6.7.1
2013-11-29 18:41sanAssigned Tosan => aba
2013-11-29 18:42sanRelationship addedrelated to 0024133
2014-02-12 11:50abaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6775#r6775
2014-02-12 11:53abaNote Added: 0027853
2014-02-12 11:53abaAssigned Toaba => bugmaster
2014-02-12 11:53abaStatusassigned => feedback
2014-02-27 18:05bugmasterAssigned Tobugmaster => aba
2014-02-27 18:05bugmasterStatusfeedback => tested
2014-02-27 18:05bugmasterNote Added: 0028055
2014-02-27 18:05bugmasterStatustested => verified
2014-02-27 18:05bugmasterResolutionopen => fixed
2014-05-05 13:34aivStatusverified => closed
2014-05-05 13:38aivFixed in Version => 6.7.1

Notes
(0019359)
vro   
2012-02-02 15:15   
Dear Kirill,
Review please my changes in 22974.
There are some minor changes in:
AIS_RadiusDimension.cxx
AIS_DiameterDimension.cxx
DsgPrs_DiameterPresentation.cxx
Select3D_SensitiveTriangulation.cxx
There are just small checks on validity of data (null vector, colinear vectors, ...).
(0019363)
kgv   
2012-02-02 16:47   
2vro, please avoid meaningless commit description like 'A fix of the bug' and emotional comments in it like 'Code duplication is removed. Thank you! :-)'!

Dear Bugmaster, please test the patch.
(0019432)
apn   
2012-02-07 13:28   
(edited on: 2012-02-07 15:29)
Dear BugMaster,
 Workbench KAS:dev:apn-22974-occt was created from SVN branch http://svn/svn/occt/branches/22974 [^]
 (and apn-22974-products from trunk) and compiled on Linux and WIndows platforms.
 
 There are not regressions in apn-22974-products regarding to KAS:dev:products-20120203-opt
 
Unstable test cases:
che 003 C3
chl 929 L5
 
Commands "vradiusdim" and "vdiameterdim" dont'work. That's why we don't have any opportunity to reproduce and check this fix.

 See results in /QADisk/occttests/results/KAS/dev/ apn-22974-products_06022012/lin
 See reference results in /QADisk/occttests/results/KAS/dev/products-20120203-opt_03022012/lin
 See test cases in /QADisk/occttests/tests/ED

(0019519)
bugmaster   
2012-02-10 17:34   
Fix will not be verified till DRAW command vradiusdim, vdiameterdim and etc will be debugged.
(0019716)
bugmaster   
2012-02-22 11:31   
Vlad,

DRAW command vradiusdim, vdiameterdim and etc must be debugged in order to check fix
(0019718)
vro   
2012-02-22 11:35   
Dear bugmaster,

What time in HRMT might I use to perform this job?
(0019737)
san   
2012-02-22 16:13   
Usually it is the same as for the bug correction itself. Creation/debugging of necessary DRAW commands is always implied.
(0019922)
abv   
2012-03-12 07:40   
Dear Vlad,

Please finalize the fix during this week to ensure it can be taken to OCCT 6.5.3
(0019963)
vro   
2012-03-14 10:21   
The draw-command vradiusdim is corrected. The modified file ViewerTest_ViewerCommands.cxx is put into a branch http://svn/svn/occt/branches/22974 [^]
(0020522)
abv   
2012-05-12 17:29   
Please move the changes to Git and correct comparisons of vector to zero in AIS_DiameterDimension.cxx:193 and DsgPrs_DiameterPresentation.cxx:60: square distance should be compared to squared tolerance
(0020525)
vro   
2012-05-14 12:13   
The branch is successfully moved to Git + the comparison operation is corrected.
(0020526)
vro   
2012-05-14 12:15   
The branch name in Git is CR22974.
(0020528)
abv   
2012-05-14 15:14   
No remarks, please test
(0020535)
apn   
2012-05-15 12:06   
Dear BugMaster,
        Workbench KAS:dev:apn-22974-1-occt was created from git branch CR22974(and apn-22974-1-products from svn trunk) and compiled on Linux platform.
    
        There are not regressions in apn-22974-1-products regarding to KAS:dev:products-20120415-opt
       
        There are not improvements in apn-22974-1-products regarding to KAS:dev:products-20120415-opt
   
        Draw commands vradiusdim, vdiameterdim and etc still crash on dragging a dimension for an object even with a small coordinate
    
        See results in /QADisk/occttests/results/KAS/dev/apn-22974-1-products_14052012/lin
        See reference results in /QADisk/occttests/results/KAS/dev/products-20120415-opt_13042012/lin
        See test cases in /QADisk/occttests/tests/ED
(0020538)
vro   
2012-05-16 10:11   
Selection of circles is corrected so that the draw-commands vradiusdim and vdiameterdim are able to select the edges for visualization of the dimensions.
(0020616)
vro   
2012-05-31 09:43   
The bug depends on 23159. Just it is fixed, testing will be possible.
(0024207)
vro   
2013-04-18 15:10   
More than an year has passed since this bug was registered. Even more, the fix was put immediately the same date, but... the fix is not integrated into Open CASCADE yet. What do we wait, the end of the world?
(0024208)
abv   
2013-04-18 15:39   
Vlad, the last report by apn (0022974:0020535) indicate that the reported problem has not been fixed ("commands vradiusdim, vdiameterdim and etc still crash"), and you indicated in 0022974:0020616 that this fix requires 0023159. The latter has not been fixed yet due to low priority. If this issue is important for you, you are welcome to provide the fix.
(0027853)
aba   
2014-02-12 11:53   
Dear Bugmaster,

This issue was fixed in the scope of the issue 0024412.

Please test it.
(0028055)
bugmaster   
2014-02-27 18:05   
The issue was fixed in the scope of the issue 0024412.