MantisBT - Community
View Issue Details
0022969Community[OCCT] OCCT:Modeling Algorithmspublic2012-02-01 20:312012-04-03 13:30
Roberto Ciarloni 
bugmaster 
urgentintegration request 
closedfixed 
WindowsVC++ 201064 bit
[OCCT] 6.5.1 
[OCCT] 6.5.3[OCCT] 6.5.3 
Test case is not required
0022969: Wrong confusion in BRepLib_MakeEdge
I am afraid I have found a bug in
BRepLib_MakeEdge::Init(const Handle(Geom_Curve)& CC,
           const TopoDS_Vertex& VV1,
           const TopoDS_Vertex& VV2,
           const Standard_Real pp1,
           const Standard_Real pp2)
in file src\BRepLib\BRepLib_MakeEdge.cxx at line 766:
Standard_Real epsilon = Precision::Confusion();

This "epsilon" is used to check if two parameters on a curve are coincident.
But Precision::Confusion() is a 3d tolerance, not 1d.
It seems to me Precision::PConfusion() should be used, which is made for parameters.
fixed in attachment
No tags attached.
cxx BRepLib_MakeEdge.cxx (30,793) 2012-02-01 20:31
https://tracker.dev.opencascade.org/
docx To_OCC-1_Contribution.docx (24,795) 2012-02-02 11:30
https://tracker.dev.opencascade.org/
Issue History
2012-02-01 20:31Roberto CiarloniNew Issue
2012-02-01 20:31Roberto CiarloniAssigned To => jgv
2012-02-01 20:31Roberto CiarloniFile Added: BRepLib_MakeEdge.cxx
2012-02-02 07:42abvAssigned Tojgv => dbv
2012-02-02 07:42abvStatusnew => assigned
2012-02-02 10:38bugmasterProjectOpen CASCADE => Community
2012-02-02 11:30szyFile Added: To_OCC-1_Contribution.docx
2012-02-02 11:30szyNote Added: 0019344
2012-02-09 12:03dbvStatusassigned => resolved
2012-02-09 12:05dbvNote Added: 0019486
2012-02-09 12:05dbvStatusresolved => reviewed
2012-02-10 15:08apnNote Added: 0019510
2012-02-10 15:11apnTest case number => Test case is not required
2012-02-10 15:11apnStatusreviewed => tested
2012-02-10 17:13bugmasterTarget Version => 6.5.3
2012-02-10 17:14bugmasterNote Added: 0019516
2012-02-10 17:14bugmasterStatustested => verified
2012-02-10 17:14bugmasterResolutionopen => fixed
2012-03-29 17:26bugmasterChangeset attached => occt master da9d480f
2012-04-03 13:30abvAssigned Todbv => Roberto Ciarloni

Notes
(0019344)
szy   
2012-02-02 11:30   
Added additional file with description - To_OCC-1_Contribution.docx.
(0019486)
dbv   
2012-02-09 12:05   
Fix has been applied and reviewed without remarks.

Branch http://svn/svn/occt/branches/OCC22969 [^] is ready for testing.

Please test.
(0019510)
apn   
2012-02-10 15:08   
Dear BugMaster,
   Workbench KAS:dev:mkv-22969-occt was created from SVN branch http://svn/svn/occt/branches/OCC22969 [^]
   (and mkv-22969-products from trunk) and compiled on Linux and Windows platforms.
   
   There are not regressions in mkv-22969-products regarding to KAS:dev:products-20120203-opt
   
   See results in /QADisk/occttests/results/KAS/dev/ mkv-22969-products_09022012/lin
   See reference results in /QADisk/occttests/results/KAS/dev/products-20120203-opt_03022012/lin
   See test cases in /QADisk/occttests/tests/ED
(0019516)
bugmaster   
2012-02-10 17:14   
Integrated into trunk of occt repository

Date: 2012-02-10 16:57:17 +0400 (Fri, 10 Feb 2012)
New Revision: 10421

Modified:
   trunk/src/BRepLib/BRepLib_MakeEdge.cxx