MantisBT - Community
View Issue Details
0022953Community[OCCT] OCCT:Foundation Classespublic2012-01-31 14:022012-04-16 12:47
Pawel 
bugmaster 
normalminor 
closedfixed 
ALL
[OCCT] 6.5.2 
[OCCT] 6.5.3[OCCT] 6.5.3 
test case is not required
0022953: strcat expects null-terminated destination string
The problem is in line 182 in OSD_Host.cxx:

char noaddress[100];
strcat(noaddress,"NO-ETHERNET-ADDRESS-AVAILABLE-ON-");

Solution: use strcpy instead of strcat.

strcpy (noaddress, "NO-ETHERNET-ADDRESS-AVAILABLE-ON-");
No tags attached.
Issue History
2012-01-31 14:02PawelNew Issue
2012-01-31 14:02PawelAssigned To => abv
2012-02-02 08:34abvNote Added: 0019340
2012-02-02 08:34abvAssigned Toabv => dbv
2012-02-02 08:34abvStatusnew => assigned
2012-02-02 11:32atpSummarystrcat expects null-terminated ddestinatino string => strcat expects null-terminated destination string
2012-02-15 10:55dbvNote Added: 0019564
2012-02-15 10:55dbvAssigned Todbv => abv
2012-02-15 10:55dbvStatusassigned => resolved
2012-02-15 12:08abvNote Added: 0019566
2012-02-15 12:08abvAssigned Toabv => dbv
2012-02-15 12:08abvStatusresolved => reviewed
2012-02-15 13:41mkvAssigned Todbv => aan
2012-02-16 12:39aanTest case number => test case is not required
2012-02-16 13:04aanNote Added: 0019597
2012-02-16 13:04aanStatusreviewed => tested
2012-02-17 11:59bugmasterAssigned Toaan => Pawel
2012-02-17 11:59bugmasterTarget Version => 6.5.3
2012-02-17 11:59bugmasterNote Added: 0019612
2012-02-17 11:59bugmasterStatustested => verified
2012-02-17 11:59bugmasterResolutionopen => fixed
2012-03-29 17:26bugmasterChangeset attached => occt master f78c0415
2012-04-16 12:47PawelAssigned ToPawel => bugmaster
2012-04-16 12:47PawelNote Added: 0020396

Notes
(0019340)
abv   
2012-02-02 08:34   
Please remove all the stuff related to getting ethernet address on ancient platforms (search for "Ethernet"). The ones I find are: file Standard_Geteth.cxx, files ethernet.h-* in OSD, method EthernetAddress in OSD::Host, and related static stuff in the cxx file.
(0019564)
dbv   
2012-02-15 10:55   
Stuff related to getting Ethernet address on ancient platforms has been removed:
1. file src/Standard/Standard_Geteth.cxx
2. files src/OSD/ethernet.h-*
3. method EthernetAddress in OSD::Host and related static stuff in the file src/OSD/OSD_Host.cxx

Branch http://svn/svn/occt/branches/OCC22953 [^] is ready to be reviewed.

Dear Andrey,
Please review.
(0019566)
abv   
2012-02-15 12:08   
No remarks, please test
(0019597)
aan   
2012-02-16 13:04   
Dear BugMaster,
Workbench aan-22953-occt was created from SVN branch http://svn/svn/occt/branches/OCC22953 [^]
(and aan-22953-products from trunk) and compiled on Linux platform.

There are not regressions in aan-22953-products regarding to KAS:dev:products-20120210-opt

See results in /QADisk/occttests/results/KAS/dev/aan-22953-products_15022012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120210-opt_10022012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification [^]
(0019612)
bugmaster   
2012-02-17 11:59   
Integrated into trunk of occt repository

Date: 2012-02-17 11:58:20 +0400 (Fri, 17 Feb 2012)
New Revision: 10495

Removed:
   trunk/src/OSD/ethernet.h-dec
   trunk/src/OSD/ethernet.h-sgi
   trunk/src/Standard/Standard_Geteth.cxx
Modified:
   trunk/src/OSD/FILES
   trunk/src/OSD/OSD_Host.cdl
   trunk/src/OSD/OSD_Host.cxx
   trunk/src/Standard/FILES
(0020396)
Pawel   
2012-04-16 12:47   
Verified. Please close.